| Message ID | 1595264494-2400-2-git-send-email-skomatineni@nvidia.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Sowjanya, On Mon, Jul 20, 2020 at 10:01:33AM -0700, Sowjanya Komatineni wrote: > This patch adds IMX274 optional external clock input and voltage > supplies to device tree bindings. > > Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > index 80f2e89..0727079 100644 > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt > @@ -13,6 +13,11 @@ Required Properties: > > Optional Properties: > - reset-gpios: Sensor reset GPIO > +- clocks: Reference to the input clock. > +- clock-names: Should be "inck". > +- VANA-supply: Sensor 2.8v analog supply. > +- VDIG-supply: Sensor 1.8v digital core supply. > +- VDDL-supply: Sensor digital IO 1.2v supply. I believe lower case is preferred. > > The imx274 device node should contain one 'port' child node with > an 'endpoint' subnode. For further reading on port node refer to
On Fri, Jul 31, 2020 at 07:19:08PM +0300, Sakari Ailus wrote: > > +- VANA-supply: Sensor 2.8v analog supply. > > +- VDIG-supply: Sensor 1.8v digital core supply. > > +- VDDL-supply: Sensor digital IO 1.2v supply. > I believe lower case is preferred. Either is fine from my POV. The code always used to use upper case but it's not clear if that's the best choice when it makes its way into bindings.
diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt index 80f2e89..0727079 100644 --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt @@ -13,6 +13,11 @@ Required Properties: Optional Properties: - reset-gpios: Sensor reset GPIO +- clocks: Reference to the input clock. +- clock-names: Should be "inck". +- VANA-supply: Sensor 2.8v analog supply. +- VDIG-supply: Sensor 1.8v digital core supply. +- VDDL-supply: Sensor digital IO 1.2v supply. The imx274 device node should contain one 'port' child node with an 'endpoint' subnode. For further reading on port node refer to