diff mbox series

[02/14] dt-bindings: arm: renesas: Add HopeRun RZ/G2H boards

Message ID 1594138692-16816-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com
State Not Applicable
Headers show
Series Add core support for Renesas RZ/G2H SoC | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Lad Prabhakar July 7, 2020, 4:18 p.m. UTC
From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

This patch adds board HiHope RZ/G2H (the main board, powered by the
R8A774E1) and board HiHope RZ/G2 EX (the expansion board that sits on top
of the HiHope RZ/G2H). Both boards are made by Jiangsu HopeRun Software
Co., Ltd. (a.k.a. HopeRun).

Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Geert Uytterhoeven July 8, 2020, 9:09 a.m. UTC | #1
On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> This patch adds board HiHope RZ/G2H (the main board, powered by the
> R8A774E1) and board HiHope RZ/G2 EX (the expansion board that sits on top
> of the HiHope RZ/G2H). Both boards are made by Jiangsu HopeRun Software
> Co., Ltd. (a.k.a. HopeRun).
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.9.

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven July 8, 2020, 9:17 a.m. UTC | #2
On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> This patch adds support for identifying the RZ/G2H (r8a774e1) SoC.
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.9.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geert Uytterhoeven July 8, 2020, 9:22 a.m. UTC | #3
Hi Prabhakar,

On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> Add configuration option for the RZ/G2H (R8A774E1) SoC.
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for the patch!

> @@ -296,6 +303,10 @@ config SYSC_R8A774C0
>         bool "RZ/G2E System Controller support" if COMPILE_TEST
>         select SYSC_RCAR
>
> +config SYSC_R8A774E1
> +       bool "RZ/G2H System Controller support" if COMPILE_TEST
> +       select SYSC_RCAR
> +
>  config SYSC_R8A7779
>         bool "R-Car H1 System Controller support" if COMPILE_TEST
>         select SYSC_RCAR

This hunk belongs to "[PATCH 07/14] soc: renesas: rcar-sysc: Add
r8a774e1 support". Might fix that while applying, we'll see.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven July 8, 2020, 9:55 a.m. UTC | #4
Hi Prabhakar,

On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> Add support for RZ/G2H (R8A774E1) SoC power areas to the R-Car SYSC
> driver.
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

with the Kconfig part moved in, and reordered before 4/14:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geert Uytterhoeven July 8, 2020, 10:01 a.m. UTC | #5
On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> Add support for RZ/G2H (R8A774E1) to the R-Car RST driver.
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.9.

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven July 8, 2020, 11:29 a.m. UTC | #6
Hi Prabhakar,

On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> Add support for the RZ/G2H (R8A774E1) SoC to the Renesas Clock
> Pulse Generator / Module Standby and Software Reset driver.
>
> Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in clk-renesas-for-v5.9.

> --- /dev/null
> +++ b/drivers/clk/renesas/r8a774e1-cpg-mssr.c

> +static const unsigned int r8a774e1_crit_mod_clks[] __initconst = {

As per commit f23f1101ad0ef1ac ("clk: renesas: rcar-gen3: Mark RWDT
clocks as critical"), I'll add a line

    MOD_CLK_ID(402),        /* RWDT */

while applying.

> +       MOD_CLK_ID(408),        /* INTC-AP (GIC) */
> +};

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven July 8, 2020, 11:56 a.m. UTC | #7
On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Renesas RZ/G2H (r8a774e1) is pin compatible with R-Car H3 (R8A77951),
> however it doesn't have several automotive specific peripherals. Add
> automotive-specific pin groups/functions along with common pin
> groups/functions for supporting both r8a77951 and r8a774e1 SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in sh-pfc-for-v5.9.

Gr{oetje,eeting}s,

                        Geert
Lad, Prabhakar July 8, 2020, 4:56 p.m. UTC | #8
Hi Geert,

On Wed, Jul 8, 2020 at 12:29 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, Jul 7, 2020 at 6:18 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> >
> > Add support for the RZ/G2H (R8A774E1) SoC to the Renesas Clock
> > Pulse Generator / Module Standby and Software Reset driver.
> >
> > Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in clk-renesas-for-v5.9.
>
> > --- /dev/null
> > +++ b/drivers/clk/renesas/r8a774e1-cpg-mssr.c
>
> > +static const unsigned int r8a774e1_crit_mod_clks[] __initconst = {
>
> As per commit f23f1101ad0ef1ac ("clk: renesas: rcar-gen3: Mark RWDT
> clocks as critical"), I'll add a line
>
>     MOD_CLK_ID(402),        /* RWDT */
>
> while applying.
>
Thank you for taking care of it.

Cheers,
--Prabhakar Lad

> > +       MOD_CLK_ID(408),        /* INTC-AP (GIC) */
> > +};
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
index c5f8d925ce6e..d8fd25bccbf5 100644
--- a/Documentation/devicetree/bindings/arm/renesas.yaml
+++ b/Documentation/devicetree/bindings/arm/renesas.yaml
@@ -152,6 +152,14 @@  properties:
 
       - description: RZ/G2H (R8A774E1)
         items:
+          - enum:
+              - hoperun,hihope-rzg2h # HopeRun HiHope RZ/G2H platform
+          - const: renesas,r8a774e1
+
+      - items:
+          - enum:
+              - hoperun,hihope-rzg2-ex # HopeRun expansion board for HiHope RZ/G2 platforms
+          - const: hoperun,hihope-rzg2h
           - const: renesas,r8a774e1
 
       - description: R-Car M1A (R8A77781)