| Message ID | 1591094883-11674-2-git-send-email-vbadigan@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Internal voltage control for qcom SDHC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
+Mark B On Tue, Jun 02, 2020 at 04:17:54PM +0530, Veerabhadrarao Badiganti wrote: > Supply the max load needed for driving the mmc supplies. > > Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> > --- > Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > index acc9f10871d4..d95219721fa1 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -290,6 +290,12 @@ properties: > description: > Supply for the bus IO line power > > + vmmc-supply-max-microamp: > + description: Maximum load for the card power. > + > + vqmmc-supply-max-microamp: > + description: Maximum load for the bus IO line power. By a 'common regulator property' I meant documented with regulator binding like *-supply, not common to MMC. How is MMC special? Thinking about this some more, what's wrong with the max current in the regulator nodes? I suppose you could have more than one load and need to define the loads separately? Rob
On Tue, Jun 09, 2020 at 05:02:16PM -0600, Rob Herring wrote: > On Tue, Jun 02, 2020 at 04:17:54PM +0530, Veerabhadrarao Badiganti wrote: > > + vmmc-supply-max-microamp: > > + description: Maximum load for the card power. > > + vqmmc-supply-max-microamp: > > + description: Maximum load for the bus IO line power. > By a 'common regulator property' I meant documented with regulator > binding like *-supply, not common to MMC. How is MMC special? TBH I'm surprised that these aren't defined by the MMC spec or by the ID information from the part we find connected - I'd not expect the board to be defining these at all. > Thinking about this some more, what's wrong with the max current in the > regulator nodes? I suppose you could have more than one load and need to > define the loads separately? One of the bigger reasons to think about the loads would be to dynamically configure the mode the regulator is in to go into a more efficient mode when some of the devices attached to it are turned off.
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml index acc9f10871d4..d95219721fa1 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml @@ -290,6 +290,12 @@ properties: description: Supply for the bus IO line power + vmmc-supply-max-microamp: + description: Maximum load for the card power. + + vqmmc-supply-max-microamp: + description: Maximum load for the bus IO line power. + mmc-pwrseq: $ref: /schemas/types.yaml#/definitions/phandle description:
Supply the max load needed for driving the mmc supplies. Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> --- Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+)