| Message ID | 1590582292-13314-2-git-send-email-sivaprak@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add APSS clock controller support for IPQ6018 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, May 27, 2020 at 05:54:48PM +0530, Sivaprakash Murugesan wrote: > cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 > pll found on ipq6018 devices. > > Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org> > --- > * [V6] > re-ordered compatible string, dropped Rob's review tag for this change. Not really significant enough to drop it, but if you really want me to stare at this again... > .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml > index 20d2638..a4f2d01 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml > @@ -15,6 +15,7 @@ description: > > properties: > compatible: > + const: qcom,ipq6018-a53pll > const: qcom,msm8916-a53pll > > reg: > @@ -23,6 +24,14 @@ properties: > '#clock-cells': > const: 0 > > + clocks: > + items: > + - description: board XO clock > + > + clock-names: > + items: > + - const: xo > + > required: > - compatible > - reg > @@ -38,3 +47,12 @@ examples: > reg = <0xb016000 0x40>; > #clock-cells = <0>; > }; > + #Example 2 - A53 PLL found on IPQ6018 devices > + - | > + a53pll_ipq: clock@b116000 { clock-controller@... > + compatible = "qcom,ipq6018-a53pll"; > + reg = <0x0b116000 0x40>; > + #clock-cells = <0>; > + clocks = <&xo>; > + clock-names = "xo"; > + }; > -- > 2.7.4 >
diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml index 20d2638..a4f2d01 100644 --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml @@ -15,6 +15,7 @@ description: properties: compatible: + const: qcom,ipq6018-a53pll const: qcom,msm8916-a53pll reg: @@ -23,6 +24,14 @@ properties: '#clock-cells': const: 0 + clocks: + items: + - description: board XO clock + + clock-names: + items: + - const: xo + required: - compatible - reg @@ -38,3 +47,12 @@ examples: reg = <0xb016000 0x40>; #clock-cells = <0>; }; + #Example 2 - A53 PLL found on IPQ6018 devices + - | + a53pll_ipq: clock@b116000 { + compatible = "qcom,ipq6018-a53pll"; + reg = <0x0b116000 0x40>; + #clock-cells = <0>; + clocks = <&xo>; + clock-names = "xo"; + };
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices. Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org> --- * [V6] re-ordered compatible string, dropped Rob's review tag for this change. .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)