| Message ID | 1589860547-3207-2-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Covert i.MX GPT/TPM/SYSCTR timer binding to json-schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 80 lines checked |
| robh/dt-meta-schema | success |
> From: Anson Huang <Anson.Huang@nxp.com> > Sent: Tuesday, May 19, 2020 11:56 AM > > Convert the i.MX GPT binding to DT schema format using json-schema. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> Regards Aisheng
On Tue, May 19, 2020 at 11:55:45AM +0800, Anson Huang wrote: > Convert the i.MX GPT binding to DT schema format using json-schema. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V1: > - remove unnecessary compatible item descriptions; > - remove unnecessary maxItems for clocks/clock-names; > --- > .../devicetree/bindings/timer/fsl,imxgpt.txt | 45 ------------ > .../devicetree/bindings/timer/fsl,imxgpt.yaml | 80 ++++++++++++++++++++++ > 2 files changed, 80 insertions(+), 45 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.txt > create mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt > deleted file mode 100644 > index 5d8fd5b..0000000 > --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt > +++ /dev/null > @@ -1,45 +0,0 @@ > -Freescale i.MX General Purpose Timer (GPT) > - > -Required properties: > - > -- compatible : should be one of following: > - for i.MX1: > - - "fsl,imx1-gpt"; > - for i.MX21: > - - "fsl,imx21-gpt"; > - for i.MX27: > - - "fsl,imx27-gpt", "fsl,imx21-gpt"; > - for i.MX31: > - - "fsl,imx31-gpt"; > - for i.MX25: > - - "fsl,imx25-gpt", "fsl,imx31-gpt"; > - for i.MX50: > - - "fsl,imx50-gpt", "fsl,imx31-gpt"; > - for i.MX51: > - - "fsl,imx51-gpt", "fsl,imx31-gpt"; > - for i.MX53: > - - "fsl,imx53-gpt", "fsl,imx31-gpt"; > - for i.MX6Q: > - - "fsl,imx6q-gpt", "fsl,imx31-gpt"; > - for i.MX6DL: > - - "fsl,imx6dl-gpt"; > - for i.MX6SL: > - - "fsl,imx6sl-gpt", "fsl,imx6dl-gpt"; > - for i.MX6SX: > - - "fsl,imx6sx-gpt", "fsl,imx6dl-gpt"; > -- reg : specifies base physical address and size of the registers. > -- interrupts : should be the gpt interrupt. > -- clocks : the clocks provided by the SoC to drive the timer, must contain > - an entry for each entry in clock-names. > -- clock-names : must include "ipg" entry first, then "per" entry. > - > -Example: > - > -gpt1: timer@10003000 { > - compatible = "fsl,imx27-gpt", "fsl,imx21-gpt"; > - reg = <0x10003000 0x1000>; > - interrupts = <26>; > - clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>, > - <&clks IMX27_CLK_PER1_GATE>; > - clock-names = "ipg", "per"; > -}; > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > new file mode 100644 > index 0000000..5479290 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/fsl,imxgpt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX General Purpose Timer (GPT) > + > +maintainers: > + - Sascha Hauer <s.hauer@pengutronix.de> > + > +properties: > + compatible: > + oneOf: > + - const: "fsl,imx1-gpt" > + - const: "fsl,imx21-gpt" > + - items: > + - const: "fsl,imx27-gpt" > + - const: "fsl,imx21-gpt" > + - const: "fsl,imx31-gpt" > + - items: > + - const: "fsl,imx25-gpt" > + - const: "fsl,imx31-gpt" > + - items: > + - const: "fsl,imx50-gpt" > + - const: "fsl,imx31-gpt" > + - items: > + - const: "fsl,imx51-gpt" > + - const: "fsl,imx31-gpt" > + - items: > + - const: "fsl,imx53-gpt" > + - const: "fsl,imx31-gpt" > + - items: > + - const: "fsl,imx6q-gpt" > + - const: "fsl,imx31-gpt" > + - const: "fsl,imx6dl-gpt" > + - items: > + - const: "fsl,imx6sl-gpt" > + - const: "fsl,imx6dl-gpt" > + - items: > + - const: "fsl,imx6sx-gpt" > + - const: "fsl,imx6dl-gpt" Don't need quotes. Group all the ones with the same fallback to a single 'items' list using enum for the first entry. Rob
diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt deleted file mode 100644 index 5d8fd5b..0000000 --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt +++ /dev/null @@ -1,45 +0,0 @@ -Freescale i.MX General Purpose Timer (GPT) - -Required properties: - -- compatible : should be one of following: - for i.MX1: - - "fsl,imx1-gpt"; - for i.MX21: - - "fsl,imx21-gpt"; - for i.MX27: - - "fsl,imx27-gpt", "fsl,imx21-gpt"; - for i.MX31: - - "fsl,imx31-gpt"; - for i.MX25: - - "fsl,imx25-gpt", "fsl,imx31-gpt"; - for i.MX50: - - "fsl,imx50-gpt", "fsl,imx31-gpt"; - for i.MX51: - - "fsl,imx51-gpt", "fsl,imx31-gpt"; - for i.MX53: - - "fsl,imx53-gpt", "fsl,imx31-gpt"; - for i.MX6Q: - - "fsl,imx6q-gpt", "fsl,imx31-gpt"; - for i.MX6DL: - - "fsl,imx6dl-gpt"; - for i.MX6SL: - - "fsl,imx6sl-gpt", "fsl,imx6dl-gpt"; - for i.MX6SX: - - "fsl,imx6sx-gpt", "fsl,imx6dl-gpt"; -- reg : specifies base physical address and size of the registers. -- interrupts : should be the gpt interrupt. -- clocks : the clocks provided by the SoC to drive the timer, must contain - an entry for each entry in clock-names. -- clock-names : must include "ipg" entry first, then "per" entry. - -Example: - -gpt1: timer@10003000 { - compatible = "fsl,imx27-gpt", "fsl,imx21-gpt"; - reg = <0x10003000 0x1000>; - interrupts = <26>; - clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>, - <&clks IMX27_CLK_PER1_GATE>; - clock-names = "ipg", "per"; -}; diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml new file mode 100644 index 0000000..5479290 --- /dev/null +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/fsl,imxgpt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX General Purpose Timer (GPT) + +maintainers: + - Sascha Hauer <s.hauer@pengutronix.de> + +properties: + compatible: + oneOf: + - const: "fsl,imx1-gpt" + - const: "fsl,imx21-gpt" + - items: + - const: "fsl,imx27-gpt" + - const: "fsl,imx21-gpt" + - const: "fsl,imx31-gpt" + - items: + - const: "fsl,imx25-gpt" + - const: "fsl,imx31-gpt" + - items: + - const: "fsl,imx50-gpt" + - const: "fsl,imx31-gpt" + - items: + - const: "fsl,imx51-gpt" + - const: "fsl,imx31-gpt" + - items: + - const: "fsl,imx53-gpt" + - const: "fsl,imx31-gpt" + - items: + - const: "fsl,imx6q-gpt" + - const: "fsl,imx31-gpt" + - const: "fsl,imx6dl-gpt" + - items: + - const: "fsl,imx6sl-gpt" + - const: "fsl,imx6dl-gpt" + - items: + - const: "fsl,imx6sx-gpt" + - const: "fsl,imx6dl-gpt" + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: SoC GPT ipg clock + - description: SoC GPT per clock + + clock-names: + items: + - const: ipg + - const: per + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx27-clock.h> + + timer@10003000 { + compatible = "fsl,imx27-gpt", "fsl,imx21-gpt"; + reg = <0x10003000 0x1000>; + interrupts = <26>; + clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>, + <&clks IMX27_CLK_PER1_GATE>; + clock-names = "ipg", "per"; + };
Convert the i.MX GPT binding to DT schema format using json-schema. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V1: - remove unnecessary compatible item descriptions; - remove unnecessary maxItems for clocks/clock-names; --- .../devicetree/bindings/timer/fsl,imxgpt.txt | 45 ------------ .../devicetree/bindings/timer/fsl,imxgpt.yaml | 80 ++++++++++++++++++++++ 2 files changed, 80 insertions(+), 45 deletions(-) delete mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.txt create mode 100644 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml