| Message ID | 1586299709-14222-1-git-send-email-tanmay@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote: > Add Display Port HPD GPIO description in bindings > > This Patch depends on: > https://patchwork.kernel.org/patch/11468505/ This belongs below the '---' and probably means you should send all this as one series. > > Signed-off-by: Tanmay Shah <tanmay@codeaurora.org> > --- > Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > index 761a01d..003f5f7 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > @@ -155,6 +155,11 @@ properties: > data-lanes: > description: Maximum number of lanes that can be used for Display port. > > + dp-hpd-gpio: We already have a standard property for this. Use it. It belongs in the connector node as HPD is part of the connector. > + maxItems: 1 > + description: Specifies HPD gpio for DP connector without > + USB PHY or AUX switch. > + > usbplug-cc-gpio: Note that this too should be in a connector node. > maxItems: 1 > description: Specifies the usbplug orientation gpio. > @@ -282,6 +287,8 @@ examples: > aux-sel-gpio = <&msmgpio 110 1>; > usbplug-cc-gpio = <&msmgpio 90 1>; > > + dp-hpd-gpio = <&msmgpio 117 0>; > + > ports { > #address-cells = <1>; > #size-cells = <0>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
Thanks Rob for reviews. We are using Display Port Controller block to detect hot plug. So we won't be using that pin as GPIO. I found now that we don't need any bindings for that pin in such case. So I am abandoning this patch series and upload new patch. Thanks. On 2020-04-15 08:24, Rob Herring wrote: > On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote: >> Add Display Port HPD GPIO description in bindings >> >> This Patch depends on: >> https://patchwork.kernel.org/patch/11468505/ > > This belongs below the '---' and probably means you should send all > this > as one series. > >> >> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org> >> --- >> Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7 > +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git > a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml >> index 761a01d..003f5f7 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml >> @@ -155,6 +155,11 @@ properties: >> data-lanes: >> description: Maximum number of lanes that can be used for > Display port. >> >> + dp-hpd-gpio: > > We already have a standard property for this. Use it. > > It belongs in the connector node as HPD is part of the connector. > >> + maxItems: 1 >> + description: Specifies HPD gpio for DP connector without >> + USB PHY or AUX switch. >> + >> usbplug-cc-gpio: > > Note that this too should be in a connector node. > >> maxItems: 1 >> description: Specifies the usbplug orientation gpio. >> @@ -282,6 +287,8 @@ examples: >> aux-sel-gpio = <&msmgpio 110 1>; >> usbplug-cc-gpio = <&msmgpio 90 1>; >> >> + dp-hpd-gpio = <&msmgpio 117 0>; >> + >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, >> a Linux Foundation Collaborative Project > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml index 761a01d..003f5f7 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml @@ -155,6 +155,11 @@ properties: data-lanes: description: Maximum number of lanes that can be used for Display port. + dp-hpd-gpio: + maxItems: 1 + description: Specifies HPD gpio for DP connector without + USB PHY or AUX switch. + usbplug-cc-gpio: maxItems: 1 description: Specifies the usbplug orientation gpio. @@ -282,6 +287,8 @@ examples: aux-sel-gpio = <&msmgpio 110 1>; usbplug-cc-gpio = <&msmgpio 90 1>; + dp-hpd-gpio = <&msmgpio 117 0>; + ports { #address-cells = <1>; #size-cells = <0>;
Add Display Port HPD GPIO description in bindings This Patch depends on: https://patchwork.kernel.org/patch/11468505/ Signed-off-by: Tanmay Shah <tanmay@codeaurora.org> --- Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7 +++++++ 1 file changed, 7 insertions(+)