| Message ID | 1582856099-105484-1-git-send-email-jianxin.pan@amlogic.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [RESEND] dt-bindings: power: Fix dt_binding_check error | expand |
Hi Jianxin, Jianxin Pan <jianxin.pan@amlogic.com> writes: > Missing ';' in the end of secure-monitor example node. > > Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings") Thanks for the fix, but where did this commit ID come from? I think this is the right upstream commit: Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings") Also, when you resend, can you cc soc@kernel.org. The soc maintainers are who queue my amlogic tree. I will ack and they can submit to Linus for v5.7 so Stephen doesn't have to carry his local linux-next fix anymore. Thanks, Kevin > Reported-by: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml > index af32209..bc4e037 100644 > --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml > +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml > @@ -36,5 +36,5 @@ examples: > compatible = "amlogic,meson-a1-pwrc"; > #power-domain-cells = <1>; > }; > - } > + }; > > -- > 2.7.4
Hi Kevin, On 2020/3/1 0:28, Kevin Hilman wrote: > Hi Jianxin, > > Jianxin Pan <jianxin.pan@amlogic.com> writes: > >> Missing ';' in the end of secure-monitor example node. >> >> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings") > > Thanks for the fix, but where did this commit ID come from? I think > this is the right upstream commit: > > Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings") > > Also, when you resend, can you cc soc@kernel.org. The soc maintainers > are who queue my amlogic tree. I will ack and they can submit to Linus > for v5.7 so Stephen doesn't have to carry his local linux-next fix > anymore. > > Thanks, The commit id is not correct, it from my local branch. I corrected it and added soc maintainers to the cc list. Thanks for your time. > > Kevin > >> Reported-by: Rob Herring <robh+dt@kernel.org> >> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> >> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> index af32209..bc4e037 100644 >> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> @@ -36,5 +36,5 @@ examples: >> compatible = "amlogic,meson-a1-pwrc"; >> #power-domain-cells = <1>; >> }; >> - } >> + }; >> >> -- >> 2.7.4 > > . >
diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml index af32209..bc4e037 100644 --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml @@ -36,5 +36,5 @@ examples: compatible = "amlogic,meson-a1-pwrc"; #power-domain-cells = <1>; }; - } + };
Missing ';' in the end of secure-monitor example node. Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings") Reported-by: Rob Herring <robh+dt@kernel.org> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)