From patchwork Thu Sep 26 20:26:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Goldsworthy X-Patchwork-Id: 1168146 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="NYxqD2Rx"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="NYxqD2Rx"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46fRKB4Wxwz9sP3 for ; Fri, 27 Sep 2019 06:26:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727944AbfIZU0V (ORCPT ); Thu, 26 Sep 2019 16:26:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46728 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727868AbfIZU0V (ORCPT ); Thu, 26 Sep 2019 16:26:21 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7360660BE8; Thu, 26 Sep 2019 20:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569529580; bh=klE2jRqKJUtnFiAopZbhMcFxlATTT1rWa/g3XpqnOZ8=; h=From:To:Cc:Subject:Date:From; b=NYxqD2RxAGWwAMkyEjJ/VYccMgqpM4SJleo+1iy7S/zaJF1avpffloXMjVURWzHbl e5TtrLI+7W342pirPpSNBkDu7gKLk6mvhDFISOsPP86G5zN9mfdfq1w6SeQ6Lyu+Uv IYkD2id/ocsiD6S+eJI7211+1GAKBRePP5vEDjNo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from cgoldswo-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cgoldswo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B21A7602CC; Thu, 26 Sep 2019 20:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569529580; bh=klE2jRqKJUtnFiAopZbhMcFxlATTT1rWa/g3XpqnOZ8=; h=From:To:Cc:Subject:Date:From; b=NYxqD2RxAGWwAMkyEjJ/VYccMgqpM4SJleo+1iy7S/zaJF1avpffloXMjVURWzHbl e5TtrLI+7W342pirPpSNBkDu7gKLk6mvhDFISOsPP86G5zN9mfdfq1w6SeQ6Lyu+Uv IYkD2id/ocsiD6S+eJI7211+1GAKBRePP5vEDjNo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B21A7602CC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cgoldswo@codeaurora.org From: Chris Goldsworthy To: Rob Herring Cc: Chris Goldsworthy , devicetree@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] of: reserved_mem: add missing of_node_put() for proper ref-counting Date: Thu, 26 Sep 2019 13:26:10 -0700 Message-Id: <1569529570-23530-1-git-send-email-cgoldswo@codeaurora.org> X-Mailer: git-send-email 2.7.4 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Commit d698a388146c ("of: reserved-memory: ignore disabled memory-region nodes") added an early return in of_reserved_mem_device_init_by_idx(), but didn't call of_node_put() on a device_node whose ref-count was incremented in the call to of_parse_phandle() preceding the early exit. Fixes: d698a388146c ("of: reserved-memory: ignore disabled memory-region nodes") Signed-off-by: Chris Goldsworthy To: Rob Herring Cc: devicetree@vger.kernel.org Cc: stable@vger.kernel.org --- drivers/of/of_reserved_mem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 7989703..6bd610e 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -324,8 +324,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev, if (!target) return -ENODEV; - if (!of_device_is_available(target)) + if (!of_device_is_available(target)) { + of_node_put(target); return 0; + } rmem = __find_rmem(target); of_node_put(target);