| Message ID | 1522321466-21755-5-git-send-email-mgautam@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | phy: qcom: Updates for USB PHYs on SDM845 | expand |
Hi, On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam <mgautam@codeaurora.org> wrote: > Update compatible strings for USB3 PHYs on SDM845. > One is QMPv3 DisplayPort-USB combo PHY and other one > is USB UNI PHY which is single lane USB3 PHY without > DP capability. While at it also remove "qcom,qmp-v3-usb3-phy" > compatible string which was earlier added for sdm845 > only as there wouldn't be any user of same. > > Reviewed-by: Rob Herring <robh@kernel.org> IMHO you should remove Rob's Review until he re-reviews. I want to make sure he's OK with the removal of the "qcom,qmp-v3-usb3-phy". Rob: that compatible string was _just_ added and was intended for SDM845. It's not expected that there are any users yet. IMHO that means it's OK to remove, but it would be good to get your confirmation that you agree. See the discussion at <https://patchwork.kernel.org/patch/10302761/>. > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> > --- > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Douglas Anderson <dianders@chromium.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt index dcf1b8f..266a1bb 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt @@ -9,7 +9,8 @@ Required properties: "qcom,ipq8074-qmp-pcie-phy" for PCIe phy on IPQ8074 "qcom,msm8996-qmp-pcie-phy" for 14nm PCIe phy on msm8996, "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996, - "qcom,qmp-v3-usb3-phy" for USB3 QMP V3 phy. + "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, + "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845. - reg: offset and length of register set for PHY's common serdes block.