| Message ID | 1513854776-4149-2-git-send-email-hayashi.kunihiko@socionext.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | add UniPhier AVE ethernet support | expand |
> +Optional properties: > + - resets: A phandle to the reset control for the MAC > + - local-mac-address: See ethernet.txt in the same directory. > + > +Required subnode: > + - mdio: Device tree subnode with the following required properties: > + > +Example: It sounds like there should be some properties before the Example. Andrew > + > + ether: ethernet@65000000 { > + compatible = "socionext,uniphier-ld20-ave4"; > + reg = <0x65000000 0x8500>; > + interrupts = <0 66 4>; > + phy-mode = "rgmii"; > + phy-handle = <ðphy>; > + clocks = <&sys_clk 6>; > + resets = <&sys_rst 6>; > + local-mac-address = [00 00 00 00 00 00]; Typically you would put a blank line here, before the mdio node. > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + ethphy: ethphy@1 { > + reg = <1>; > + }; > + }; > + }; Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Andrew, On Thu, 21 Dec 2017 12:32:54 +0100 Andrew Lunn <andrew@lunn.ch> wrote: > > +Optional properties: > > + - resets: A phandle to the reset control for the MAC > > + - local-mac-address: See ethernet.txt in the same directory. > > + > > +Required subnode: > > + - mdio: Device tree subnode with the following required properties: > > + > > +Example: > > It sounds like there should be some properties before the Example. Indeed, this is my carelessness. > > Andrew > > > + > > + ether: ethernet@65000000 { > > + compatible = "socionext,uniphier-ld20-ave4"; > > + reg = <0x65000000 0x8500>; > > + interrupts = <0 66 4>; > > + phy-mode = "rgmii"; > > + phy-handle = <ðphy>; > > + clocks = <&sys_clk 6>; > > + resets = <&sys_rst 6>; > > + local-mac-address = [00 00 00 00 00 00]; > > Typically you would put a blank line here, before the mdio node. Okay, I'll put it. > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + ethphy: ethphy@1 { > > + reg = <1>; > > + }; > > + }; > > + }; > > Andrew Thank you, --- Best Regards, Kunihiko Hayashi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt new file mode 100644 index 0000000..c73a6f2 --- /dev/null +++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt @@ -0,0 +1,45 @@ +* Socionext AVE ethernet controller + +This describes the devicetree bindings for AVE ethernet controller +implemented on Socionext UniPhier SoCs. + +Required properties: + - compatible: Should be + - "socionext,uniphier-pro4-ave4" : for Pro4 SoC + - "socionext,uniphier-pxs2-ave4" : for PXs2 SoC + - "socionext,uniphier-ld11-ave4" : for LD11 SoC + - "socionext,uniphier-ld20-ave4" : for LD20 SoC + - reg: Address where registers are mapped and size of region. + - interrupts: Should contain the MAC interrupt. + - phy-mode: See ethernet.txt in the same directory. Allow to choose + "rgmii", "rmii", or "mii" according to the PHY. + - phy-handle: Should point to the external phy device. + See ethernet.txt file in the same directory. + - clocks: A phandle to the clock for the MAC. + +Optional properties: + - resets: A phandle to the reset control for the MAC + - local-mac-address: See ethernet.txt in the same directory. + +Required subnode: + - mdio: Device tree subnode with the following required properties: + +Example: + + ether: ethernet@65000000 { + compatible = "socionext,uniphier-ld20-ave4"; + reg = <0x65000000 0x8500>; + interrupts = <0 66 4>; + phy-mode = "rgmii"; + phy-handle = <ðphy>; + clocks = <&sys_clk 6>; + resets = <&sys_rst 6>; + local-mac-address = [00 00 00 00 00 00]; + mdio { + #address-cells = <1>; + #size-cells = <0>; + ethphy: ethphy@1 { + reg = <1>; + }; + }; + };