diff mbox

[2/3] dt-bindings: mtd: add a common label property to all mtd devices

Message ID 1484573225-19095-3-git-send-email-clg@kaod.org
State Superseded, archived
Headers show

Commit Message

Cédric Le Goater Jan. 16, 2017, 1:27 p.m. UTC
This can be used to easily identify a specific chip on a system with
multiple chips.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 Documentation/devicetree/bindings/mtd/common.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/common.txt

Comments

Boris Brezillon Jan. 16, 2017, 1:52 p.m. UTC | #1
On Mon, 16 Jan 2017 14:27:04 +0100
Cédric Le Goater <clg@kaod.org> wrote:

> This can be used to easily identify a specific chip on a system with
> multiple chips.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  Documentation/devicetree/bindings/mtd/common.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/common.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt
> new file mode 100644
> index 000000000000..a781641a3b00
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/common.txt
> @@ -0,0 +1,12 @@
> +* Common properties of all MTD devices
> +
> +Optional properties:
> +- label : name to assign to mtd. If omitted, the label is the MTD device name.

Hm, the description is not really clear. How about:

"
- label: user-defined MTD device name. Can be used to assign user
  friendly names to MTD devices (instead of the flash model or flash
  controller based name) in order to ease flash device identification
  and/or describe what they are used for.
"

Otherwise,

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

> +
> +Example:
> +
> +	flash@0 {
> +		label = "System-firmware";
> +
> +		/* flash type specific properties */
> +	};

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Cédric Le Goater Jan. 16, 2017, 2:39 p.m. UTC | #2
On 01/16/2017 02:52 PM, Boris Brezillon wrote:
> On Mon, 16 Jan 2017 14:27:04 +0100
> Cédric Le Goater <clg@kaod.org> wrote:
> 
>> This can be used to easily identify a specific chip on a system with
>> multiple chips.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>>  Documentation/devicetree/bindings/mtd/common.txt | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mtd/common.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt
>> new file mode 100644
>> index 000000000000..a781641a3b00
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/common.txt
>> @@ -0,0 +1,12 @@
>> +* Common properties of all MTD devices
>> +
>> +Optional properties:
>> +- label : name to assign to mtd. If omitted, the label is the MTD device name.
> 
> Hm, the description is not really clear. How about:
> 
> "
> - label: user-defined MTD device name. Can be used to assign user
>   friendly names to MTD devices (instead of the flash model or flash
>   controller based name) in order to ease flash device identification
>   and/or describe what they are used for.
> "

yes. I will use that in a v2.
 
Thanks,

C. 

> Otherwise,
> 
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Thanks,
> 
> Boris
> 
>> +
>> +Example:
>> +
>> +	flash@0 {
>> +		label = "System-firmware";
>> +
>> +		/* flash type specific properties */
>> +	};
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt
new file mode 100644
index 000000000000..a781641a3b00
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/common.txt
@@ -0,0 +1,12 @@ 
+* Common properties of all MTD devices
+
+Optional properties:
+- label : name to assign to mtd. If omitted, the label is the MTD device name.
+
+Example:
+
+	flash@0 {
+		label = "System-firmware";
+
+		/* flash type specific properties */
+	};