[v2,1/4] dma: mmp_pdma: Add the #dma-requests DT property documentation

For pxa based platforms, the number of requestor lines should be
specified, so that the driver can check if the flow control should be
activated (when a requestor line is asked for) or not.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
Since v1: rename of property to #dma-requests
      	  modify default value to 32 as suggested by Vinod
---
 Documentation/devicetree/bindings/dma/mmp-dma.txt | 2 ++
 1 file changed, 2 insertions(+)

On Mon, Feb 15, 2016 at 09:57:45PM +0100, Robert Jarzmik wrote:
> For pxa based platforms, the number of requestor lines should be
> specified, so that the driver can check if the flow control should be
> activated (when a requestor line is asked for) or not.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v1: rename of property to #dma-requests
>       	  modify default value to 32 as suggested by Vinod
> ---
>  Documentation/devicetree/bindings/dma/mmp-dma.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> The current number of requestor lines is limited to 31. This was an
> error of a previous commit, as this number is platform dependent, and is
> actually :
>  - for pxa25x: 40 requestor lines
>  - for pxa27x: 75 requestor lines
>  - for pxa3xx: 100 requestor lines
>
> The previous testing did not reveal the faulty constant as on pxa[23]xx
> platforms, only camera, MSL and USB are above requestor 32, and in these
> only the camera has a driver using dma.
>
> Fixes: e87ffbdf0697 ("dmaengine: pxa_dma: fix the no-requestor case")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v1: change to #dma-requests the of property name
>       	  default to 32 requestors and warn as suggested by Vinod

Hi Vinod,

Are you happy with this version ?
If so could you provide me your Acked-by please ?

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Mon, Feb 15, 2016 at 09:57:48PM +0100, Robert Jarzmik wrote:
> The current number of requestor lines is limited to 31. This was an
> error of a previous commit, as this number is platform dependent, and is
> actually :
>  - for pxa25x: 40 requestor lines
>  - for pxa27x: 75 requestor lines
>  - for pxa3xx: 100 requestor lines
> 
> The previous testing did not reveal the faulty constant as on pxa[23]xx
> platforms, only camera, MSL and USB are above requestor 32, and in these
> only the camera has a driver using dma.
> 
> Fixes: e87ffbdf0697 ("dmaengine: pxa_dma: fix the no-requestor case")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

Acked-by: Vinod Koul <vinod.koul@intel.com>

Which tree is this targetted thru?

Vinod Koul <vinod.koul@intel.com> writes:

> On Mon, Feb 15, 2016 at 09:57:48PM +0100, Robert Jarzmik wrote:
>> The current number of requestor lines is limited to 31. This was an
>> error of a previous commit, as this number is platform dependent, and is
>> actually :
>>  - for pxa25x: 40 requestor lines
>>  - for pxa27x: 75 requestor lines
>>  - for pxa3xx: 100 requestor lines
>> 
>> The previous testing did not reveal the faulty constant as on pxa[23]xx
>> platforms, only camera, MSL and USB are above requestor 32, and in these
>> only the camera has a driver using dma.
>> 
>> Fixes: e87ffbdf0697 ("dmaengine: pxa_dma: fix the no-requestor case")
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> Which tree is this targetted thru?
PXA for-next tree, my tree, once I gather the acks.

Cheers.

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> The DMA chip has a fixed number of requestor lines used for flow
> control. This number is platform dependent. The pxa_dma dma driver will
> use this value to activate or not the flow control.
>
> There won't be any impact on mmp_pdma driver.
Haojian,

Even if mmp_pdma will not be impacted, it would be good to have have your ack on
this trivial patch.

Cheers.

--
Robert

[1] The patch
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>  include/linux/platform_data/mmp_dma.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/platform_data/mmp_dma.h b/include/linux/platform_data/mmp_dma.h
> index 2a330ec9e2af..d1397c8ed94e 100644
> --- a/include/linux/platform_data/mmp_dma.h
> +++ b/include/linux/platform_data/mmp_dma.h
> @@ -14,6 +14,7 @@
>  
>  struct mmp_dma_platdata {
>  	int dma_channels;
> +	int nb_requestors;
>  };
>  
>  #endif /* MMP_DMA_H */

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> Vinod Koul <vinod.koul@intel.com> writes:
>
>> On Mon, Feb 15, 2016 at 09:57:48PM +0100, Robert Jarzmik wrote:
>>> The current number of requestor lines is limited to 31. This was an
>>> error of a previous commit, as this number is platform dependent, and is
>>> actually :
>>>  - for pxa25x: 40 requestor lines
>>>  - for pxa27x: 75 requestor lines
>>>  - for pxa3xx: 100 requestor lines
>>> 
>>> The previous testing did not reveal the faulty constant as on pxa[23]xx
>>> platforms, only camera, MSL and USB are above requestor 32, and in these
>>> only the camera has a driver using dma.
>>> 
>>> Fixes: e87ffbdf0697 ("dmaengine: pxa_dma: fix the no-requestor case")
>>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>>
>> Acked-by: Vinod Koul <vinod.koul@intel.com>
>>
>> Which tree is this targetted thru?
> PXA for-next tree, my tree, once I gather the acks.
>
> Cheers.

Queued into pxa/for-next, thanks.