| Message ID | 1447981511-29653-2-git-send-email-vz@mleia.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Friday 20 November 2015 03:05:01 Vladimir Zapolskiy wrote: > NXP LPC32xx SoC has a clocking and power control unit (CPC) as a part > of system control block (SCB). CPC is supplied by two external > oscillators and it manages core and most of peripheral > clocks, the change adds description of DT bindings for clock > controller found on LPC32xx SoC series. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > --- > .../devicetree/bindings/clock/nxp,lpc3220-clk.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt > > diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt > new file mode 100644 > index 0000000..20cbca3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt > @@ -0,0 +1,30 @@ > +NXP LPC32xx Clock Controller > + > +Required properties: > +- compatible: should be "nxp,lpc3220-clk" Please use a specific model number without 'xx' wildcards. If you have multiple chips that are mutually compatible, pick one as the base number and then list the others as more specific instances, like compatible = "nxp,lpc3250-clk", "nxp,lpc3220-clk"; Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnd, On 20.11.2015 15:58, Arnd Bergmann wrote: > On Friday 20 November 2015 03:05:01 Vladimir Zapolskiy wrote: >> NXP LPC32xx SoC has a clocking and power control unit (CPC) as a part >> of system control block (SCB). CPC is supplied by two external >> oscillators and it manages core and most of peripheral >> clocks, the change adds description of DT bindings for clock >> controller found on LPC32xx SoC series. >> >> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> >> --- >> .../devicetree/bindings/clock/nxp,lpc3220-clk.txt | 30 ++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt >> >> diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt >> new file mode 100644 >> index 0000000..20cbca3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt >> @@ -0,0 +1,30 @@ >> +NXP LPC32xx Clock Controller >> + >> +Required properties: >> +- compatible: should be "nxp,lpc3220-clk" > > Please use a specific model number without 'xx' wildcards. If you have > multiple chips that are mutually compatible, pick one as the base number > and then list the others as more specific instances, like > > compatible = "nxp,lpc3250-clk", "nxp,lpc3220-clk"; Do you ask me to change a title? You may see that compatible property does not contain any wildcards? -- Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 20 November 2015 20:01:00 Vladimir Zapolskiy wrote: > > > > Please use a specific model number without 'xx' wildcards. If you have > > multiple chips that are mutually compatible, pick one as the base number > > and then list the others as more specific instances, like > > > > compatible = "nxp,lpc3250-clk", "nxp,lpc3220-clk"; > > Do you ask me to change a title? You may see that compatible property > does not contain any wildcards? > Nevermind, I saw so many 'xx's that I didn't notice you got the important one right. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt new file mode 100644 index 0000000..20cbca3 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt @@ -0,0 +1,30 @@ +NXP LPC32xx Clock Controller + +Required properties: +- compatible: should be "nxp,lpc3220-clk" +- reg: should contain clock controller registers location and length +- #clock-cells: must be 1, the cell holds id of a clock provided by the + clock controller +- clocks: phandles of external oscillators, the list must contain one + 32768 Hz oscillator and may have one optional high frequency oscillator +- clock-names: list of external oscillator clock names, must contain + "xtal_32k" and may have optional "xtal" + +Examples: + + /* System Control Block */ + scb { + compatible = "simple-bus"; + ranges = <0x0 0x040004000 0x00001000>; + #address-cells = <1>; + #size-cells = <1>; + + clk: clock-controller@0 { + compatible = "nxp,lpc3220-clk"; + reg = <0x00 0x114>; + #clock-cells = <1>; + + clocks = <&xtal_32k>, <&xtal>; + clock-names = "xtal_32k", "xtal"; + }; + };
NXP LPC32xx SoC has a clocking and power control unit (CPC) as a part of system control block (SCB). CPC is supplied by two external oscillators and it manages core and most of peripheral clocks, the change adds description of DT bindings for clock controller found on LPC32xx SoC series. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- .../devicetree/bindings/clock/nxp,lpc3220-clk.txt | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/nxp,lpc3220-clk.txt