| Message ID | 1436018110-3903-6-git-send-email-martink@posteo.de |
|---|---|
| State | Needs Review / ACK, archived |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
| robh/patch-applied | success |
On 04/07/15 14:55, Martin Kepplinger wrote: > Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com> > Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> This is trivial enough I'll take it without a device tree ack (after a few days) but convention is to CC all device tree patches to the maintainers of devicetree bindings as well as the devicetree list. Jonathan > --- > .../devicetree/bindings/iio/accel/mma8452.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/mma8452.txt > > diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt > new file mode 100644 > index 0000000..8d98e05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt > @@ -0,0 +1,21 @@ > +Freescale MMA8452Q, MMA8453Q, MMA8652FC or MMA8653FC triaxial accelerometer > + > +Required properties: > + > + - compatible: should be "fsl,mma8653", "fsl,mma8652", "fsl,mma8453" or > + "fsl,mma8452" respectively. > + - reg: the I2C address of the chip > + > +Optional properties: > + > + - interrupt-parent: should be the phandle for the interrupt controller > + - interrupts: interrupt mapping for GPIO IRQ > + > +Example: > + > + mma8653fc@1d { > + compatible = "fsl,mma8653"; > + reg = <0x1d>; > + interrupt-parent = <&gpio1>; > + interrupts = <5 0>; > + }; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 2015-07-05 um 13:48 schrieb Jonathan Cameron: > On 04/07/15 14:55, Martin Kepplinger wrote: >> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com> >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> > This is trivial enough I'll take it without a device tree ack (after a few days) > but convention is to CC all device tree patches to the maintainers of devicetree > bindings as well as the devicetree list. > > Jonathan Thanks a lot so far. I'll send a next version based on your review and will add devicetree people. Maybe you can take the series cleanly in one go after that. Someone that quickly runs it, other than me, would be awesome of course ;) martin >> --- >> .../devicetree/bindings/iio/accel/mma8452.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/accel/mma8452.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >> new file mode 100644 >> index 0000000..8d98e05 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >> @@ -0,0 +1,21 @@ >> +Freescale MMA8452Q, MMA8453Q, MMA8652FC or MMA8653FC triaxial accelerometer >> + >> +Required properties: >> + >> + - compatible: should be "fsl,mma8653", "fsl,mma8652", "fsl,mma8453" or >> + "fsl,mma8452" respectively. >> + - reg: the I2C address of the chip >> + >> +Optional properties: >> + >> + - interrupt-parent: should be the phandle for the interrupt controller >> + - interrupts: interrupt mapping for GPIO IRQ >> + >> +Example: >> + >> + mma8653fc@1d { >> + compatible = "fsl,mma8653"; >> + reg = <0x1d>; >> + interrupt-parent = <&gpio1>; >> + interrupts = <5 0>; >> + }; >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/07/15 12:50, Martin Kepplinger wrote: > Am 2015-07-05 um 13:48 schrieb Jonathan Cameron: >> On 04/07/15 14:55, Martin Kepplinger wrote: >>> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com> >>> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> >> This is trivial enough I'll take it without a device tree ack (after a few days) >> but convention is to CC all device tree patches to the maintainers of devicetree >> bindings as well as the devicetree list. >> >> Jonathan > > Thanks a lot so far. I'll send a next version based on your review and > will add devicetree people. Maybe you can take the series cleanly in one > go after that. Someone that quickly runs it, other than me, would be > awesome of course ;) Wuss ;) You'd be amazed how many invasive changes go in without anyone every finding anyone to test them on particular obscure parts. Still it is indeed always nice. > > martin >>> --- >>> .../devicetree/bindings/iio/accel/mma8452.txt | 21 +++++++++++++++++++++ >>> 1 file changed, 21 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/iio/accel/mma8452.txt >>> >>> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >>> new file mode 100644 >>> index 0000000..8d98e05 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >>> @@ -0,0 +1,21 @@ >>> +Freescale MMA8452Q, MMA8453Q, MMA8652FC or MMA8653FC triaxial accelerometer >>> + >>> +Required properties: >>> + >>> + - compatible: should be "fsl,mma8653", "fsl,mma8652", "fsl,mma8453" or >>> + "fsl,mma8452" respectively. >>> + - reg: the I2C address of the chip >>> + >>> +Optional properties: >>> + >>> + - interrupt-parent: should be the phandle for the interrupt controller >>> + - interrupts: interrupt mapping for GPIO IRQ >>> + >>> +Example: >>> + >>> + mma8653fc@1d { >>> + compatible = "fsl,mma8653"; >>> + reg = <0x1d>; >>> + interrupt-parent = <&gpio1>; >>> + interrupts = <5 0>; >>> + }; >>> >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/07/15 13:48, Jonathan Cameron wrote: > On 04/07/15 14:55, Martin Kepplinger wrote: >> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com> >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> > This is trivial enough I'll take it without a device tree ack (after a few days) > but convention is to CC all device tree patches to the maintainers of devicetree > bindings as well as the devicetree list. Currently the binding is covered by Documentation/devicetree/bindings/i2c/trivial-devices.txt Shouldn't that one be removed now that a full binding document is being created? Regards, Martin > Jonathan >> --- >> .../devicetree/bindings/iio/accel/mma8452.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/accel/mma8452.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >> new file mode 100644 >> index 0000000..8d98e05 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >> @@ -0,0 +1,21 @@ >> +Freescale MMA8452Q, MMA8453Q, MMA8652FC or MMA8653FC triaxial accelerometer >> + >> +Required properties: >> + >> + - compatible: should be "fsl,mma8653", "fsl,mma8652", "fsl,mma8453" or >> + "fsl,mma8452" respectively. >> + - reg: the I2C address of the chip >> + >> +Optional properties: >> + >> + - interrupt-parent: should be the phandle for the interrupt controller >> + - interrupts: interrupt mapping for GPIO IRQ >> + >> +Example: >> + >> + mma8653fc@1d { >> + compatible = "fsl,mma8653"; >> + reg = <0x1d>; >> + interrupt-parent = <&gpio1>; >> + interrupts = <5 0>; >> + }; >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 2015-07-06 um 10:06 schrieb Martin Fuzzey: > On 05/07/15 13:48, Jonathan Cameron wrote: >> On 04/07/15 14:55, Martin Kepplinger wrote: >>> Signed-off-by: Martin Kepplinger >>> <martin.kepplinger@theobroma-systems.com> >>> Signed-off-by: Christoph Muellner >>> <christoph.muellner@theobroma-systems.com> >> This is trivial enough I'll take it without a device tree ack (after a >> few days) >> but convention is to CC all device tree patches to the maintainers of >> devicetree >> bindings as well as the devicetree list. > > Currently the binding is covered by > Documentation/devicetree/bindings/i2c/trivial-devices.txt > Shouldn't that one be removed now that a full binding document is being > created? > True, thanks very much! Included for the new version of the patches. > Regards, > > Martin > >> Jonathan >>> --- >>> .../devicetree/bindings/iio/accel/mma8452.txt | 21 >>> +++++++++++++++++++++ >>> 1 file changed, 21 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/iio/accel/mma8452.txt >>> >>> diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt >>> b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >>> new file mode 100644 >>> index 0000000..8d98e05 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt >>> @@ -0,0 +1,21 @@ >>> +Freescale MMA8452Q, MMA8453Q, MMA8652FC or MMA8653FC triaxial >>> accelerometer >>> + >>> +Required properties: >>> + >>> + - compatible: should be "fsl,mma8653", "fsl,mma8652", >>> "fsl,mma8453" or >>> + "fsl,mma8452" respectively. >>> + - reg: the I2C address of the chip >>> + >>> +Optional properties: >>> + >>> + - interrupt-parent: should be the phandle for the interrupt >>> controller >>> + - interrupts: interrupt mapping for GPIO IRQ >>> + >>> +Example: >>> + >>> + mma8653fc@1d { >>> + compatible = "fsl,mma8653"; >>> + reg = <0x1d>; >>> + interrupt-parent = <&gpio1>; >>> + interrupts = <5 0>; >>> + }; >>> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt new file mode 100644 index 0000000..8d98e05 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt @@ -0,0 +1,21 @@ +Freescale MMA8452Q, MMA8453Q, MMA8652FC or MMA8653FC triaxial accelerometer + +Required properties: + + - compatible: should be "fsl,mma8653", "fsl,mma8652", "fsl,mma8453" or + "fsl,mma8452" respectively. + - reg: the I2C address of the chip + +Optional properties: + + - interrupt-parent: should be the phandle for the interrupt controller + - interrupts: interrupt mapping for GPIO IRQ + +Example: + + mma8653fc@1d { + compatible = "fsl,mma8653"; + reg = <0x1d>; + interrupt-parent = <&gpio1>; + interrupts = <5 0>; + };