From patchwork Tue May 19 08:48:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 473783 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7A49214007F for ; Tue, 19 May 2015 18:48:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752955AbbESIsL (ORCPT ); Tue, 19 May 2015 04:48:11 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:40016 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753892AbbESIsH (ORCPT ); Tue, 19 May 2015 04:48:07 -0400 Received: from paszta.hi.pengutronix.de ([2001:67c:670:100:96de:80ff:fec2:9969] helo=paszta) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1YudBx-0005vX-Br; Tue, 19 May 2015 10:48:01 +0200 Message-ID: <1432025280.3182.6.camel@pengutronix.de> Subject: Re: [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board From: Philipp Zabel To: hs@denx.de Cc: Shawn Guo , linux-kernel@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Date: Tue, 19 May 2015 10:48:00 +0200 In-Reply-To: <555AE192.8010700@denx.de> References: <1431334974-27531-1-git-send-email-hs@denx.de> <20150518113135.GD1071@dragon> <555AE192.8010700@denx.de> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Heiko, Shawn, Am Dienstag, den 19.05.2015, 09:09 +0200 schrieb Heiko Schocher: [...] > > What is this? I failed to find it in Documentation/devicetree/bindings/ > > Ah, this is not documentated, see commit: > > commit 628f435be4359e6ae8ecfdda9b492053be76a057 > Author: Philipp Zabel > Date: Tue Feb 25 11:55:04 2014 +0100 > > imx-drm: parallel-display: Add drm_panel support > > added Philipp to cc ... This was meant to be a temporary solution to connect a drm_panel to the parallel-display when the of-graph bindings were not yet available. I'd very much prefer to switch to the common of-graph bindings similarly to the LDB driver instead. Could you check if this would work for you: -----8<----- From: Philipp Zabel Subject: [PATCH] drm/imx: parallel-display: fix drm_panel support The parallel-display driver used an undocumented, non-standard property "fsl,panel" to optionally associate with a drm_panel device. This patch fixes the driver to use the OF graph bindings, just as the LDB driver: parallel-display { compatible = "fsl,imx-parallel-display"; ... port@1 { reg = <1>; parallel_out: endpoint { remote_endpoint = <&panel_in>; }; }; }; panel { ... port { panel_in: endpoint { remote-endpoint = <¶llel_out>; }; }; }; Signed-off-by: Philipp Zabel Tested-by: Heiko Schocher --- .../devicetree/bindings/drm/imx/fsl-imx-drm.txt | 26 ++++++++++++++++++++-- drivers/gpu/drm/imx/parallel-display.c | 21 ++++++++++++----- 2 files changed, 39 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt b/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt index e75f0e5..971c3ee 100644 --- a/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt +++ b/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt @@ -65,8 +65,10 @@ Optional properties: - edid: verbatim EDID data block describing attached display. - ddc: phandle describing the i2c bus handling the display data channel -- port: A port node with endpoint definitions as defined in +- port@[0-1]: Port nodes with endpoint definitions as defined in Documentation/devicetree/bindings/media/video-interfaces.txt. + Port 0 is the input port connected to the IPU display interface, + port 1 is the output port connected to a panel. example: @@ -75,9 +77,29 @@ display@di0 { edid = [edid-data]; interface-pix-fmt = "rgb24"; - port { + port@0 { + reg = <0>; + display_in: endpoint { remote-endpoint = <&ipu_di0_disp0>; }; }; + + port@1 { + reg = <1>; + + display_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; +}; + +panel { + ... + + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; }; diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c index 74a9ce4..b4deb9c 100644 --- a/drivers/gpu/drm/imx/parallel-display.c +++ b/drivers/gpu/drm/imx/parallel-display.c @@ -21,6 +21,7 @@ #include #include #include