| Message ID | 1430761002-9327-7-git-send-email-abrestic@chromium.org |
|---|---|
| State | Needs Review / ACK, archived |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
| robh/patch-applied | success |
On Mon, May 4, 2015 at 10:36 AM, Andrew Bresticker <abrestic@chromium.org> wrote: > + - compatible: For Tegra124, must contain "nvidia,tegra124-xusb-mbox". > + Otherwise, must contain '"nvidia,<chip>-xusb-mbox", > + "nvidia,tegra124-xusb-mbox"' where <chip> is tegra132. The driver doesn't seem to have any particular entry for tegra132, so that would be a bad example.
On Fri, May 8, 2015 at 1:42 PM, Benson Leung <bleung@chromium.org> wrote: > On Mon, May 4, 2015 at 10:36 AM, Andrew Bresticker > <abrestic@chromium.org> wrote: >> + - compatible: For Tegra124, must contain "nvidia,tegra124-xusb-mbox". >> + Otherwise, must contain '"nvidia,<chip>-xusb-mbox", >> + "nvidia,tegra124-xusb-mbox"' where <chip> is tegra132. > > The driver doesn't seem to have any particular entry for tegra132, so > that would be a bad example. The convention on Tegra is to use "nvidia,<chip>-<ip>" for each IP block. Additionally, since the XUSB-related blocks on Tegra132 are identical to Tegra124, these devices on Tegra132 are 'compatible' with their Tegra124 variants. For some context, see Paul's comments in commit 193c9d23 ("Documentation: DT bindings: add more Tegra chip compatible strings"). Thanks, Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 8, 2015 at 1:53 PM, Andrew Bresticker <abrestic@chromium.org> wrote: > > The convention on Tegra is to use "nvidia,<chip>-<ip>" for each IP > block. Additionally, since the XUSB-related blocks on Tegra132 are > identical to Tegra124, these devices on Tegra132 are 'compatible' with > their Tegra124 variants. > > For some context, see Paul's comments in commit 193c9d23 > ("Documentation: DT bindings: add more Tegra chip compatible > strings"). Ah, understood. Thanks for the clarification! Reviewed-by: Benson Leung <bleung@chromium.org>
diff --git a/Documentation/devicetree/bindings/mailbox/nvidia,tegra124-xusb-mbox.txt b/Documentation/devicetree/bindings/mailbox/nvidia,tegra124-xusb-mbox.txt new file mode 100644 index 0000000..7eb72ce --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/nvidia,tegra124-xusb-mbox.txt @@ -0,0 +1,32 @@ +NVIDIA Tegra XUSB mailbox +========================= + +The Tegra XUSB mailbox is used by the Tegra xHCI controller's firmware to +communicate requests to the host and PHY drivers. + +Refer to ./mailbox.txt for generic information about mailbox device-tree +bindings. + +Required properties: +-------------------- + - compatible: For Tegra124, must contain "nvidia,tegra124-xusb-mbox". + Otherwise, must contain '"nvidia,<chip>-xusb-mbox", + "nvidia,tegra124-xusb-mbox"' where <chip> is tegra132. + - interrupts: Must contain the XUSB mailbox interrupt. + - #mbox-cells: Should be 0. There is only one physical channel. + +Example: +-------- + xusb_mbox: mailbox { + compatible = "nvidia,tegra124-xusb-mbox"; + interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; + + #mbox-cells = <0>; + }; + + usb-host@0,70090000 { + ... + mboxes = <&xusb_mbox>; + mbox-names = "xusb"; + ... + };
Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra xHCI controller's firmware and the host processor. Signed-off-by: Andrew Bresticker <abrestic@chromium.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> Cc: Kumar Gala <galak@codeaurora.org> Cc: Jassi Brar <jassisinghbrar@gmail.com> --- Changes from v7: - Added back interrupts property. Changes from v6: - Removed reg/interrupts properties. No changes from v3/v4/v5. Changes from v2: - Dropped channel specifier. - Added pointer to mailbox documentation. Changes from v1: - Updated to use common mailbox bindings. --- .../bindings/mailbox/nvidia,tegra124-xusb-mbox.txt | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/nvidia,tegra124-xusb-mbox.txt