From patchwork Wed Mar 4 19:12:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Porter X-Patchwork-Id: 446381 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 32A1D140146 for ; Thu, 5 Mar 2015 06:13:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758118AbbCDTNF (ORCPT ); Wed, 4 Mar 2015 14:13:05 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:32833 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758110AbbCDTNE (ORCPT ); Wed, 4 Mar 2015 14:13:04 -0500 Received: by iecar1 with SMTP id ar1so69923240iec.0 for ; Wed, 04 Mar 2015 11:13:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=g3IblflFShN6gockHZpdzdl7aFzukE8xUJn2GyP/PLU=; b=K7KHW/PUv47h1IzqbqFXy69Madp+7QaZKQHNJMNTbXp7mkx9Mxz7bvn6zyTfkppklU eiZMVxTPeO42ADOga0Z4m0GgTV0kqT2ipjN+u3pRdxv0E+VMDXIQo0kN7QWoXlvdVI4F dbian1olYKGhn7Ea+qZUzvWWHmUmM/DBu9iUwxhVN6VbKMntcFGw2MeqWB8PR/FTCLQY MTrz3jkIwHo/ebw5/XaPrSo5iolpLXbR3LQvoejJkM838Zxlf9KGo0xKEHa81GFbf7bu KimPaozCPVW44AKIEwVS5AUeSsQFrtKfowKHqfo+XfLFzukYjYGscfhpxP2eB54zzL0i NAXA== X-Gm-Message-State: ALoCoQk8OnFYycFUkZNzXG4DNej52drFcfYJ11ihGMcR3JRWExQRNKqzmXThj8wTxe0GGyMK7y4a X-Received: by 10.107.128.219 with SMTP id k88mr13850367ioi.27.1425496382666; Wed, 04 Mar 2015 11:13:02 -0800 (PST) Received: from beef.ohporter.com (cpe-107-10-23-53.neo.res.rr.com. [107.10.23.53]) by mx.google.com with ESMTPSA id y142sm3390556iod.25.2015.03.04.11.13.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Mar 2015 11:13:02 -0800 (PST) From: Matt Porter To: Devicetree List , Mark Brown Cc: Rob Herring , Mark Rutland , Marek Vasut , Robin Gong , Pantelis Antoniou , Linux Kernel Mailing List Subject: [PATCH] dt: spi: fsl-imx-cspi: add explicit compatible strings and required clock properties Date: Wed, 4 Mar 2015 14:12:58 -0500 Message-Id: <1425496378-16561-1-git-send-email-mporter@konsulko.com> X-Mailer: git-send-email 1.8.4 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The fsl-imx-cspi binding contains language indicating compatible strings to be used that is not valid for all supported parts e.g. Should be "fsl,-cspi" or "fsl,-ecspi". Fix this by enumerating the set of valid compatible strings. The binding is also missing the clocks/clock-names properties so document these and the two required ipg and per clocks. Signed-off-by: Matt Porter --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt index aad527b..523341a 100644 --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt @@ -2,11 +2,21 @@ (CSPI/eCSPI) for i.MX Required properties: -- compatible : Should be "fsl,-cspi" or "fsl,-ecspi" +- compatible : + - "fsl,imx1-cspi" for SPI compatible with the one integrated on i.MX1 + - "fsl,imx21-cspi" for SPI compatible with the one integrated on i.MX21 + - "fsl,imx27-cspi" for SPI compatible with the one integrated on i.MX27 + - "fsl,imx31-cspi" for SPI compatible with the one integrated on i.MX31 + - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 + - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 - reg : Offset and length of the register set for the device - interrupts : Should contain CSPI/eCSPI interrupt - fsl,spi-num-chipselects : Contains the number of the chipselect - cs-gpios : Specifies the gpio pins to be used for chipselects. +- clocks : Clock specifiers for both ipg and per clocks. +- clock-names : Clock names should include both "ipg" and "per" +See the clock consumer binding, + Documentation/devicetree/bindings/clock/clock-bindings.txt - dmas: DMA specifiers for tx and rx dma. See the DMA client binding, Documentation/devicetree/bindings/dma/dma.txt - dma-names: DMA request names should include "tx" and "rx" if present.