diff mbox

[alsa-devel,v2,RESEND,2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

Message ID 1420185829-24886-3-git-send-email-ideal.song@samsung.com
State New, archived
Headers show

Commit Message

Inha Song Jan. 2, 2015, 8:03 a.m. UTC
This patch update DT binding to support OUTn_MONO init_data. Each
output signal can be configurated as a mono differential output.
The mono differential configuration is selected using the OUTn_MONO
registers.

Signed-off-by: Inha Song <ideal.song@samsung.com>
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Charles Keepax Jan. 6, 2015, 9:17 a.m. UTC | #1
On Fri, Jan 02, 2015 at 05:03:49PM +0900, Inha Song wrote:
> This patch update DT binding to support OUTn_MONO init_data. Each
> output signal can be configurated as a mono differential output.
> The mono differential configuration is selected using the OUTn_MONO
> registers.
> 
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones Jan. 20, 2015, 12:20 p.m. UTC | #2
On Fri, 02 Jan 2015, Inha Song wrote:

> This patch update DT binding to support OUTn_MONO init_data. Each
> output signal can be configurated as a mono differential output.
> The mono differential configuration is selected using the OUTn_MONO
> registers.

This requires a DT Ack and an entry in the example.

> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 7bd1273..cf11d42 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -49,6 +49,13 @@ Optional properties:
>      input singals. If values less than the number of input signals, elements
>      that has not been specifed are set to 0 by default.
>  
> +  - wlf,out-mono : A list of OUTn_MONO register values, where n is the number
> +    of output signals. Valid values are 0 (Disabled) and 1 (Enabled). If absent,
> +    OUTn_MONO registers set to 0 by default. If present, values must be specified
> +    less than or equal to the number of output signals. If values less than the
> +    number of input signals, elements that has not been specified are set to 0
> +    by default.
> +
>    - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
>      they are being externally supplied. As covered in
>      Documentation/devicetree/bindings/regulator/regulator.txt
Mark Brown Jan. 20, 2015, 1:20 p.m. UTC | #3
On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> On Fri, 02 Jan 2015, Inha Song wrote:

> > This patch update DT binding to support OUTn_MONO init_data. Each
> > output signal can be configurated as a mono differential output.
> > The mono differential configuration is selected using the OUTn_MONO
> > registers.

> This requires a DT Ack and an entry in the example.

The DT maintainers have said they're OK with maintainers just merging
things if they're comfortable with it (see the bindings specific
submitting-patches.txt) and given their workload and general resulting
responsiveness it's going to make it difficult go get anything done.
Charles Keepax Jan. 20, 2015, 3:49 p.m. UTC | #4
On Fri, Jan 02, 2015 at 05:03:49PM +0900, Inha Song wrote:
> This patch update DT binding to support OUTn_MONO init_data. Each
> output signal can be configurated as a mono differential output.
> The mono differential configuration is selected using the OUTn_MONO
> registers.
> 
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---

Agree with Lee an example probably would be nice. But otherwise
this looks fine.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones Jan. 20, 2015, 4:02 p.m. UTC | #5
On Tue, 20 Jan 2015, Mark Brown wrote:

> On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> > On Fri, 02 Jan 2015, Inha Song wrote:
> 
> > > This patch update DT binding to support OUTn_MONO init_data. Each
> > > output signal can be configurated as a mono differential output.
> > > The mono differential configuration is selected using the OUTn_MONO
> > > registers.
> 
> > This requires a DT Ack and an entry in the example.
> 
> The DT maintainers have said they're OK with maintainers just merging
> things if they're comfortable with it (see the bindings specific
> submitting-patches.txt) and given their workload and general resulting
> responsiveness it's going to make it difficult go get anything done.

I only tend to poke the DT guys when I am unsure of something in the
binding.  In this case it was a doubt whether we should be encoding
register values inside a property like this.

I would also be happy to take it with your Ack if you're happy with
it?
Charles Keepax Jan. 20, 2015, 4:44 p.m. UTC | #6
On Tue, Jan 20, 2015 at 04:02:48PM +0000, Lee Jones wrote:
> On Tue, 20 Jan 2015, Mark Brown wrote:
> 
> > On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> > > On Fri, 02 Jan 2015, Inha Song wrote:
> > 
> > > > This patch update DT binding to support OUTn_MONO init_data. Each
> > > > output signal can be configurated as a mono differential output.
> > > > The mono differential configuration is selected using the OUTn_MONO
> > > > registers.
> > 
> > > This requires a DT Ack and an entry in the example.
> > 
> > The DT maintainers have said they're OK with maintainers just merging
> > things if they're comfortable with it (see the bindings specific
> > submitting-patches.txt) and given their workload and general resulting
> > responsiveness it's going to make it difficult go get anything done.
> 
> I only tend to poke the DT guys when I am unsure of something in the
> binding.  In this case it was a doubt whether we should be encoding
> register values inside a property like this.
> 
> I would also be happy to take it with your Ack if you're happy with
> it?

In this case really it is a boolean indicating if the
corresponding output is mono or not. It is handled thusly in the
code:

		if (arizona->pdata.out_mono[i])
			val = ARIZONA_OUT1_MONO;
		else
			val = 0;

Perhaps some further wording tweaks on the Documentation patch
would be appropriate, but certainly I am happy enough with the
binding.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones Jan. 20, 2015, 4:57 p.m. UTC | #7
On Tue, 20 Jan 2015, Charles Keepax wrote:

> On Tue, Jan 20, 2015 at 04:02:48PM +0000, Lee Jones wrote:
> > On Tue, 20 Jan 2015, Mark Brown wrote:
> > 
> > > On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> > > > On Fri, 02 Jan 2015, Inha Song wrote:
> > > 
> > > > > This patch update DT binding to support OUTn_MONO init_data. Each
> > > > > output signal can be configurated as a mono differential output.
> > > > > The mono differential configuration is selected using the OUTn_MONO
> > > > > registers.
> > > 
> > > > This requires a DT Ack and an entry in the example.
> > > 
> > > The DT maintainers have said they're OK with maintainers just merging
> > > things if they're comfortable with it (see the bindings specific
> > > submitting-patches.txt) and given their workload and general resulting
> > > responsiveness it's going to make it difficult go get anything done.
> > 
> > I only tend to poke the DT guys when I am unsure of something in the
> > binding.  In this case it was a doubt whether we should be encoding
> > register values inside a property like this.
> > 
> > I would also be happy to take it with your Ack if you're happy with
> > it?
> 
> In this case really it is a boolean indicating if the
> corresponding output is mono or not. It is handled thusly in the
> code:
> 
> 		if (arizona->pdata.out_mono[i])
> 			val = ARIZONA_OUT1_MONO;
> 		else
> 			val = 0;
> 
> Perhaps some further wording tweaks on the Documentation patch
> would be appropriate, but certainly I am happy enough with the
> binding.

Very well.  As you and Mark seem happy with the approach I will be
more lenient on the next submission.  An example and some working
tweaks would improve chances of acceptance further still.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index 7bd1273..cf11d42 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -49,6 +49,13 @@  Optional properties:
     input singals. If values less than the number of input signals, elements
     that has not been specifed are set to 0 by default.
 
+  - wlf,out-mono : A list of OUTn_MONO register values, where n is the number
+    of output signals. Valid values are 0 (Disabled) and 1 (Enabled). If absent,
+    OUTn_MONO registers set to 0 by default. If present, values must be specified
+    less than or equal to the number of output signals. If values less than the
+    number of input signals, elements that has not been specified are set to 0
+    by default.
+
   - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
     they are being externally supplied. As covered in
     Documentation/devicetree/bindings/regulator/regulator.txt