| Message ID | 1404479625-25385-1-git-send-email-s.nawrocki@samsung.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Sylwester, On Fri, Jul 4, 2014 at 2:13 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > This patch adds the sound subsystem driver for Odroid-X2 and > Odroid-U3 boards. The codec works in I2S master mode; there > are two separate audio routing paths defined, as there are > differences in the signal routing between the X2 and U3 boards, > i.e. U3 uses single jack for headphones and microphone. > > Signed-off-by: Chen Zhen <zhen1.chen@samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Testing on ODROID-U2, v3 is not quite working for me, but v2 of the patch was fine. I boot up, run: # speaker-test -c 2 -t wav As soon as I hear the word "front" I press ctrl+c and then run the command again. Now the command hangs with no audible output. Any ideas? Let me know if you have trouble reproducing. Thanks Daniel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 04, 2014 at 03:13:44PM +0200, Sylwester Nawrocki wrote:
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Applied both, thanks. Please use subject lines consistent with the
subsystem style.
Hi Daniel, On 08/07/14 11:15, Daniel Drake wrote: > Testing on ODROID-U2, v3 is not quite working for me, but v2 of the > patch was fine. > I boot up, run: > # speaker-test -c 2 -t wav > > As soon as I hear the word "front" I press ctrl+c and then run the > command again. > Now the command hangs with no audible output. > > Any ideas? Let me know if you have trouble reproducing. I just posted a patch addressing this, please let me know if there are any further issues.
On Thu, Jul 10, 2014 at 5:15 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > On 08/07/14 11:15, Daniel Drake wrote: >> Testing on ODROID-U2, v3 is not quite working for me, but v2 of the >> patch was fine. >> I boot up, run: >> # speaker-test -c 2 -t wav >> >> As soon as I hear the word "front" I press ctrl+c and then run the >> command again. >> Now the command hangs with no audible output. >> >> Any ideas? Let me know if you have trouble reproducing. > > I just posted a patch addressing this, please let me know > if there are any further issues. Sorry for not testing sooner. Your patch solves the issue. Thanks Daniel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/sound/samsung,odroidx2-max98090.txt b/Documentation/devicetree/bindings/sound/samsung,odroidx2-max98090.txt new file mode 100644 index 0000000..9148f72 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,odroidx2-max98090.txt @@ -0,0 +1,35 @@ +Samsung Exynos Odroid X2/U3 audio complex with MAX98090 codec + +Required properties: + - compatible : "samsung,odroidx2-audio" - for Odroid X2 board, + "samsung,odroidu3-audio" - for Odroid U3 board + - samsung,model : the user-visible name of this sound complex + - samsung,i2s-controller : the phandle of the I2S controller + - samsung,audio-codec : the phandle of the MAX98090 audio codec + - samsung,audio-routing : a list of the connections between audio + components; each entry is a pair of strings, the first being the + connection's sink, the second being the connection's source; + valid names for sources and sinks are the MAX98090's pins (as + documented in its binding), and the jacks on the board + For Odroid X2: + * Headphone Jack + * Mic Jack + * DMIC + + For Odroid U3: + * Headphone Jack + * Speakers + +Example: + +sound { + compatible = "samsung,odroidu3-audio"; + samsung,i2s-controller = <&i2s0>; + samsung,audio-codec = <&max98090>; + samsung,model = "Odroid-X2"; + samsung,audio-routing = + "Headphone Jack", "HPL", + "Headphone Jack", "HPR", + "IN1", "Mic Jack", + "Mic Jack", "MICBIAS"; +};
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v2: - none. --- .../bindings/sound/samsung,odroidx2-max98090.txt | 35 ++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,odroidx2-max98090.txt