| Message ID | 1403087508-6710-1-git-send-email-lee.jones@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, 18 Jun 2014, Srinivas Kandagatla wrote: > Shouldn’t you do the same in Makefile? Ah balls! That's what happens when you rush. Respinning. > On Wed, Jun 18, 2014 at 11:31 AM, Lee Jones <lee.jones@linaro.org> wrote: > > > Two reasons for this rename. Firstly, it removes the camel case > > convention which isn't used by any other platform and secondly it > > matches the naming convention for the internal kernel, which can > > become annoying when flipping between the two. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} | 0 > > 1 file changed, 0 insertions(+), 0 deletions(-) > > rename arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} > > (100%) > > > > diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts > > b/arch/arm/boot/dts/stih416-b2020e.dts > > similarity index 100% > > rename from arch/arm/boot/dts/stih416-b2020-revE.dts > > rename to arch/arm/boot/dts/stih416-b2020e.dts > > > >
Hi Lee, On 06/18/2014 12:54 PM, Lee Jones wrote: > Two reasons for this rename. Firstly, it removes the camel case > convention which isn't used by any other platform and secondly it > matches the naming convention for the internal kernel, which can > become annoying when flipping between the two. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Maxime Coquelin <maxime.coquelin@st.com> It will be part of the STi pull-request for 3.16 fixes. Thanks, Maxime > --- > v1 -> v2: Appropriate change to the Makefile. > --- > arch/arm/boot/dts/Makefile | 2 +- > arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} (100%) > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 5986ff6..adb5ed9 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -357,7 +357,7 @@ dtb-$(CONFIG_ARCH_STI)+= stih407-b2120.dtb \ > stih415-b2020.dtb \ > stih416-b2000.dtb \ > stih416-b2020.dtb \ > - stih416-b2020-revE.dtb > + stih416-b2020e.dtb > dtb-$(CONFIG_MACH_SUN4I) += \ > sun4i-a10-a1000.dtb \ > sun4i-a10-cubieboard.dtb \ > diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020e.dts > similarity index 100% > rename from arch/arm/boot/dts/stih416-b2020-revE.dts > rename to arch/arm/boot/dts/stih416-b2020e.dts > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 18 Jun 2014, Maxime Coquelin wrote: > Hi Lee, > > On 06/18/2014 12:54 PM, Lee Jones wrote: > >Two reasons for this rename. Firstly, it removes the camel case > >convention which isn't used by any other platform and secondly it > >matches the naming convention for the internal kernel, which can > >become annoying when flipping between the two. > > > >Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Acked-by: Maxime Coquelin <maxime.coquelin@st.com> > > It will be part of the STi pull-request for 3.16 fixes. Thanks for taking the patch. :) Just a quick side note. As a maintainer, if you're going to take the patch there's no requirement to publicly Ack it. Just let the submitter know that you've applied it to your tree. I use Acks for 2 things; when a patch touches code that I maintain, but is going in via a different tree, or as a marker if there is some reason I can't apply it to my tree right away (waiting on dependencies etc), but equally do not wish to review the same patch twice. > >--- > >v1 -> v2: Appropriate change to the Makefile. > >--- > > arch/arm/boot/dts/Makefile | 2 +- > > arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} (100%) > > > >diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > >index 5986ff6..adb5ed9 100644 > >--- a/arch/arm/boot/dts/Makefile > >+++ b/arch/arm/boot/dts/Makefile > >@@ -357,7 +357,7 @@ dtb-$(CONFIG_ARCH_STI)+= stih407-b2120.dtb \ > > stih415-b2020.dtb \ > > stih416-b2000.dtb \ > > stih416-b2020.dtb \ > >- stih416-b2020-revE.dtb > >+ stih416-b2020e.dtb > > dtb-$(CONFIG_MACH_SUN4I) += \ > > sun4i-a10-a1000.dtb \ > > sun4i-a10-cubieboard.dtb \ > >diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020e.dts > >similarity index 100% > >rename from arch/arm/boot/dts/stih416-b2020-revE.dts > >rename to arch/arm/boot/dts/stih416-b2020e.dts > >
diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020e.dts
similarity index 100%
rename from arch/arm/boot/dts/stih416-b2020-revE.dts
rename to arch/arm/boot/dts/stih416-b2020e.dts
Two reasons for this rename. Firstly, it removes the camel case convention which isn't used by any other platform and secondly it matches the naming convention for the internal kernel, which can become annoying when flipping between the two. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename arch/arm/boot/dts/{stih416-b2020-revE.dts => stih416-b2020e.dts} (100%)