| Message ID | 1386148808-15065-1-git-send-email-dt.tangr@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Dec 04, 2013 at 09:20:07AM +0000, dt.tangr@gmail.com wrote: > From: Daniel Tang <dt.tangr@gmail.com> > > The SoC name was mistakenly used instead of the vendor name in the > device tree binding for nspire-usb. > > This patch fixes this before the driver becomes widely adopted. How widely adopted is it so far? I can't see the binding in mainline yet. > > Signed-off-by: Daniel Tang <dt.tangr@gmail.com> > --- > Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++-- > drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt > index 5ba8e90..ef1fcbf 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt > @@ -1,7 +1,7 @@ > * TI-Nspire USB OTG Controller > > Required properties: > -- compatible: Should be "zevio,nspire-usb" > +- compatible: Should be "lsi,nspire-usb" Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer binding? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 04, 2013 at 08:20:07PM +1100, dt.tangr@gmail.com wrote: > From: Daniel Tang <dt.tangr@gmail.com> > > The SoC name was mistakenly used instead of the vendor name in the > device tree binding for nspire-usb. > > This patch fixes this before the driver becomes widely adopted. > > Signed-off-by: Daniel Tang <dt.tangr@gmail.com> > --- > Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++-- > drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt > index 5ba8e90..ef1fcbf 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt > @@ -1,7 +1,7 @@ > * TI-Nspire USB OTG Controller > > Required properties: > -- compatible: Should be "zevio,nspire-usb" > +- compatible: Should be "lsi,nspire-usb" lsi is vendor name, what are zevio and nspire? Usually, the compatible string should be "vendor_name,soc_name-module_name" > - reg: Should contain registers location and length > - interrupts: Should contain controller interrupt > > @@ -11,7 +11,7 @@ Recommended properies: > Examples: > usb0: usb@B0000000 { > reg = <0xB0000000 0x1000>; > - compatible = "zevio,nspire-usb"; > + compatible = "lsi,nspire-usb"; > interrupts = <8>; > vbus-supply = <&vbus_reg>; > }; > diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c > index 517ce41..c5c2dde 100644 > --- a/drivers/usb/chipidea/ci_hdrc_nspire.c > +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c > @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) > } > > static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { > - { .compatible = "zevio,nspire-usb", }, > + { .compatible = "lsi,nspire-usb", }, > { /* sentinel */ } > }; > > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Hi, On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> wrote: > > lsi is vendor name, what are zevio and nspire? > Usually, the compatible string should be "vendor_name,soc_name-module_name" > Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire. If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers). >> - reg: Should contain registers location and length >> - interrupts: Should contain controller interrupt >> >> @@ -11,7 +11,7 @@ Recommended properies: >> Examples: >> usb0: usb@B0000000 { >> reg = <0xB0000000 0x1000>; >> - compatible = "zevio,nspire-usb"; >> + compatible = "lsi,nspire-usb"; >> interrupts = <8>; >> vbus-supply = <&vbus_reg>; >> }; >> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c >> index 517ce41..c5c2dde 100644 >> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c >> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c >> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) >> } >> >> static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { >> - { .compatible = "zevio,nspire-usb", }, >> + { .compatible = "lsi,nspire-usb", }, >> { /* sentinel */ } >> }; >> >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > > Best Regards, > Peter Chen > Cheers, Daniel Tang-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 04/12/2013, at 11:18 PM, Mark Rutland <mark.rutland@arm.com> wrote: >> >> >> Required properties: >> -- compatible: Should be "zevio,nspire-usb" >> +- compatible: Should be "lsi,nspire-usb" > > Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer > binding? You're right. I'll fix up the patch and send it back in. > > Thanks, > Mark. Cheers, Daniel Tang -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote: > Hi, > > On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> wrote: > > > > > lsi is vendor name, what are zevio and nspire? > > Usually, the compatible string should be "vendor_name,soc_name-module_name" > > > > Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire. > Please wrap the line to 80 characters. The driver is written for the TI-Nspire, and you port this driver for SoC Zevio platform? Since you use chipidea ip, we don't care the usb module name at your platform, we only care the soc name which you are running, it can detect the SoC platform at runtime. At your dts patch, it still uses nspire-usb. http://marc.info/?l=linux-usb&m=138614886720024&w=2 Peter > If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers). > > >> - reg: Should contain registers location and length > >> - interrupts: Should contain controller interrupt > >> > >> @@ -11,7 +11,7 @@ Recommended properies: > >> Examples: > >> usb0: usb@B0000000 { > >> reg = <0xB0000000 0x1000>; > >> - compatible = "zevio,nspire-usb"; > >> + compatible = "lsi,nspire-usb"; > >> interrupts = <8>; > >> vbus-supply = <&vbus_reg>; > >> }; > >> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c > >> index 517ce41..c5c2dde 100644 > >> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c > >> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c > >> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) > >> } > >> > >> static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { > >> - { .compatible = "zevio,nspire-usb", }, > >> + { .compatible = "lsi,nspire-usb", }, > >> { /* sentinel */ } > >> }; > >> > >> -- > >> 1.7.10.4 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > > > > -- > > > > Best Regards, > > Peter Chen > > > > Cheers, > Daniel Tang
Hi, On 05/12/2013, at 7:49 PM, Peter Chen <Peter.Chen@freescale.com> wrote: > On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote: >> Hi, >> >> On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> wrote: >> >>> >>> lsi is vendor name, what are zevio and nspire? >>> Usually, the compatible string should be "vendor_name,soc_name-module_name" >>> >> >> Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire. >> > > Please wrap the line to 80 characters. > > The driver is written for the TI-Nspire, and you port this driver for > SoC Zevio platform? The TI-Nspire runs on the Zevio SoC. > Since you use chipidea ip, we don't care the usb > module name at your platform, we only care the soc name which you are > running, it can detect the SoC platform at runtime. > Yep, that's why the latest patch I sent in renames the device tree binding to "lsi,zevio-usb" since zevio is the name of the SoC that the TI-Nspire uses. > At your dts patch, it still uses nspire-usb. > http://marc.info/?l=linux-usb&m=138614886720024&w=2 I'll send a new one in right now. > > Peter Cheers, Daniel Tang-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Hi, > > On 05/12/2013, at 7:49 PM, Peter Chen <Peter.Chen@freescale.com> wrote: > > > On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote: > >> Hi, > >> > >> On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> > wrote: > >> > >>> > >>> lsi is vendor name, what are zevio and nspire? > >>> Usually, the compatible string should be "vendor_name,soc_name- > module_name" > >>> > >> > >> Because this port uses documentation from reverse engineering, it's > difficult to work out what is SoC specific and what is device specific. > The SoC is Zevio but the driver is written for the TI-Nspire. > >> > > > > Please wrap the line to 80 characters. > > > > The driver is written for the TI-Nspire, and you port this driver for > > SoC Zevio platform? > > The TI-Nspire runs on the Zevio SoC. > > > Since you use chipidea ip, we don't care the usb > > module name at your platform, we only care the soc name which you are > > running, it can detect the SoC platform at runtime. > > > > Yep, that's why the latest patch I sent in renames the device tree > binding to "lsi,zevio-usb" since zevio is the name of the SoC that the > TI-Nspire uses. > > > At your dts patch, it still uses nspire-usb. > > http://marc.info/?l=linux-usb&m=138614886720024&w=2 > > I'll send a new one in right now. OK, in order to avoid changing name again, I will queue your patch at my pending chipidea tree until your dts has applied by arch or dts maintainer, notify me when they are ready. Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt index 5ba8e90..ef1fcbf 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt @@ -1,7 +1,7 @@ * TI-Nspire USB OTG Controller Required properties: -- compatible: Should be "zevio,nspire-usb" +- compatible: Should be "lsi,nspire-usb" - reg: Should contain registers location and length - interrupts: Should contain controller interrupt @@ -11,7 +11,7 @@ Recommended properies: Examples: usb0: usb@B0000000 { reg = <0xB0000000 0x1000>; - compatible = "zevio,nspire-usb"; + compatible = "lsi,nspire-usb"; interrupts = <8>; vbus-supply = <&vbus_reg>; }; diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c index 517ce41..c5c2dde 100644 --- a/drivers/usb/chipidea/ci_hdrc_nspire.c +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev) } static const struct of_device_id ci_hdrc_nspire_dt_ids[] = { - { .compatible = "zevio,nspire-usb", }, + { .compatible = "lsi,nspire-usb", }, { /* sentinel */ } };