diff mbox

[3/3] dt: binding documentation for bq2415x charger

Message ID 1385311771-447-4-git-send-email-sre@debian.org
State Superseded, archived
Headers show

Commit Message

Sebastian Reichel Nov. 24, 2013, 4:49 p.m. UTC
Add devicetree binding documentation for bq2415x charger.

Signed-off-by: Sebastian Reichel <sre@debian.org>
---
 .../devicetree/bindings/power/bq2415x.txt          | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/bq2415x.txt

Comments

Pavel Machek Nov. 25, 2013, 1:07 p.m. UTC | #1
On Sun 2013-11-24 17:49:31, Sebastian Reichel wrote:
> Add devicetree binding documentation for bq2415x charger.
> 
> Signed-off-by: Sebastian Reichel <sre@debian.org>

Thanks!

> +- reg: integer, i2c address of the device
> +- ti,current-limit: integer, current limit in mA

Does this need to be "ti," specific? Most of fields are likely to be
needed for other li-ion chargers....

"Specifies maximum current charger can pull from power supply"

?

> +- ti,charge-current: integer, charging current in mA

...why/how is it different from current-limit? Is the current-limit on
5V, while the charge-current relative to battery voltage... so that
charge-current can be > current-limit when battery voltage is low?

"Maximum current that will be supplied to the battery, as determined
by voltage on current sense resistor"?

> +- ti,weak-battery-voltage: integer, weak battery voltage threshold in mV

It would be good to explain what this threshold means. Voltage so low
that system needs to be shut down?

Hmm, it looks to me like it is "as long as battery is below this
voltage, fast charge is not started. Instead, slow 'precharge' is
performed."

> +- ti,battery-regulation-voltage: integer, battery regulation
>  voltage in mV

"Selects maximum voltage for charging."

> +- ti,termination-current: integer, termination current in mA

"When current in constant-voltage phase drops below this value, charge
is terminated".
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/power/bq2415x.txt b/Documentation/devicetree/bindings/power/bq2415x.txt
new file mode 100644
index 0000000..cb2e753
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/bq2415x.txt
@@ -0,0 +1,43 @@ 
+Binding for TI bq2415x Li-Ion Charger
+
+Required properties:
+- compatible: Should contain one of the following:
+ * "ti,bq24150"
+ * "ti,bq24150"
+ * "ti,bq24150a"
+ * "ti,bq24151"
+ * "ti,bq24151a"
+ * "ti,bq24152"
+ * "ti,bq24153"
+ * "ti,bq24153a"
+ * "ti,bq24155"
+ * "ti,bq24156"
+ * "ti,bq24156a"
+ * "ti,bq24158"
+- reg: integer, i2c address of the device
+- ti,current-limit: integer, current limit in mA
+- ti,weak-battery-voltage: integer, weak battery voltage threshold in mV
+- ti,battery-regulation-voltage: integer, battery regulation voltage in mV
+- ti,charge-current: integer, charging current in mA
+- ti,termination-current: integer, termination current in mA
+- ti,resistor-sense: integer, value of sensing resistor in milliohm
+
+Optional properties:
+- ti,usb-charger-detection: phandle to usb charger detection device
+			    (required for auto mode)
+
+Example from Nokia N900:
+
+bq24150a {
+	compatible = "ti,bq24150a";
+	reg = <0x6b>;
+
+	ti,current-limit = <100>;
+	ti,weak-battery-voltage = <3400>;
+	ti,battery-regulation-voltage = <4200>;
+	ti,charge-current = <650>;
+	ti,termination-current = <100>;
+	ti,resistor-sense = <68>;
+
+	ti,usb-charger-detection = <&isp1704>;
+};