| Message ID | cover.98f979c2af2337c57217016d21d7c68e1ac2ce8a.1592210452.git-series.maxime@cerno.tech |
|---|---|
| Headers | show |
| Series | clk: bcm: rpi: Add support for BCM2711 firmware clocks | expand |
Quoting Maxime Ripard (2020-06-15 01:40:40) > Hi, > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > to split away the two discussions between the firmware clocks and the > HDMI support. > > Let me know what you think, > Maxime Do you want this to go through clk tree? Or looking for acks/review tags?
On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2020-06-15 01:40:40) > > Hi, > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > > to split away the two discussions between the firmware clocks and the > > HDMI support. > > > > Let me know what you think, > > Maxime > > Do you want this to go through clk tree? Or looking for acks/review > tags? > FWIW I don't mind taking the device tree changes trough the RPi soc tree. Regards, Nicolas
Hi Stephen, On Fri, Jun 19, 2020 at 02:37:37AM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2020-06-15 01:40:40) > > Hi, > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > > to split away the two discussions between the firmware clocks and the > > HDMI support. > > > > Let me know what you think, > > Maxime > > Do you want this to go through clk tree? Or looking for acks/review > tags? As far as I understood, you usually apply the bcm patches to the clk tree directly, so if you could apply them it would be awesome :) Maxime
Quoting Nicolas Saenz Julienne (2020-06-19 02:44:54) > On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2020-06-15 01:40:40) > > > Hi, > > > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > > > to split away the two discussions between the firmware clocks and the > > > HDMI support. > > > > > > Let me know what you think, > > > Maxime > > > > Do you want this to go through clk tree? Or looking for acks/review > > tags? > > > > FWIW I don't mind taking the device tree changes trough the RPi soc tree. > Sounds good.
Quoting Maxime Ripard (2020-06-19 04:52:55) > Hi Stephen, > > On Fri, Jun 19, 2020 at 02:37:37AM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2020-06-15 01:40:40) > > > Hi, > > > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > > > to split away the two discussions between the firmware clocks and the > > > HDMI support. > > > > > > Let me know what you think, > > > Maxime > > > > Do you want this to go through clk tree? Or looking for acks/review > > tags? > > As far as I understood, you usually apply the bcm patches to the clk > tree directly, so if you could apply them it would be awesome :) > Ok. Thanks for letting me know.
Quoting Stephen Boyd (2020-06-19 16:57:10) > Quoting Nicolas Saenz Julienne (2020-06-19 02:44:54) > > On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote: > > > Quoting Maxime Ripard (2020-06-15 01:40:40) > > > > Hi, > > > > > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > > > > to split away the two discussions between the firmware clocks and the > > > > HDMI support. > > > > > > > > Let me know what you think, > > > > Maxime > > > > > > Do you want this to go through clk tree? Or looking for acks/review > > > tags? > > > > > > > FWIW I don't mind taking the device tree changes trough the RPi soc tree. > > > > Sounds good. > Just to clarify, that is just the dts patch? Or the binding patches too?
Quoting Stephen Boyd (2020-06-19 17:20:24) > Quoting Stephen Boyd (2020-06-19 16:57:10) > > Quoting Nicolas Saenz Julienne (2020-06-19 02:44:54) > > > On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote: > > > > Quoting Maxime Ripard (2020-06-15 01:40:40) > > > > > Hi, > > > > > > > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > > > > > to split away the two discussions between the firmware clocks and the > > > > > HDMI support. > > > > > > > > > > Let me know what you think, > > > > > Maxime > > > > > > > > Do you want this to go through clk tree? Or looking for acks/review > > > > tags? > > > > > > > > > > FWIW I don't mind taking the device tree changes trough the RPi soc tree. > > > > > > > Sounds good. > > > > Just to clarify, that is just the dts patch? Or the binding patches too? Ok. I'll push everything out now and you can tell me to undo that if it's wrong.
Quoting Maxime Ripard (2020-06-15 01:40:40) > Hi, > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > to split away the two discussions between the firmware clocks and the > HDMI support. > I see one problem. WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/bcm/clk-bcm2711-dvp.o Can you send a followup patch to fix this?
Hi, Since the whole DRM/HDMI support began to grow fairly big, I've chosen to split away the two discussions between the firmware clocks and the HDMI support. Let me know what you think, Maxime Cc: bcm-kernel-feedback-list@broadcom.com Cc: devicetree@vger.kernel.org Cc: Kamal Dasu <kdasu.kdev@gmail.com> Cc: linux-clk@vger.kernel.org Cc: Michael Turquette <mturquette@baylibre.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Stephen Boyd <sboyd@kernel.org> Changes from v4: - Rebased on 5.8-rc1 - Added more tags - Fixed a typo in a variable name Changes from v3: - Moved the firmware structure to the driver, and changed for u32 - Prevented cache issues with MMIO driver - Removed message when discovering min and max rates - Added the gathered tags Changes from v2: - Rebased on top of next-20200526 - Split away from the HDMI series - Fixed an of_node leakage in the firmware driver - Fixed an of_node leakage in the firmware clocks driver - Added the min/max rate retrieval to all the firmware clocks - Added proper name for the firmware clocks - Removed the PLLB setup from the firmware clocks and moved it back to the MMIO driver Florian Fainelli (1): dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML Maxime Ripard (26): dt-bindings: clock: Add a binding for the RPi Firmware clocks firmware: rpi: Only create clocks device if we don't have a node for it clk: bcm: rpi: Allow the driver to be probed by DT clk: bcm: rpi: Statically init clk_init_data clk: bcm: rpi: Use clk_hw_register for pllb_arm clk: bcm: rpi: Remove global pllb_arm clock pointer clk: bcm: rpi: Make sure pllb_arm is removed clk: bcm: rpi: Remove pllb_arm_lookup global pointer clk: bcm: rpi: Switch to clk_hw_register_clkdev clk: bcm: rpi: Make sure the clkdev lookup is removed clk: bcm: rpi: Use CCF boundaries instead of rolling our own clk: bcm: rpi: Create a data structure for the clocks clk: bcm: rpi: Add clock id to data clk: bcm: rpi: Pass the clocks data to the firmware function clk: bcm: rpi: Rename is_prepared function clk: bcm: rpi: Split pllb clock hooks clk: bcm: rpi: Make the PLLB registration function return a clk_hw clk: bcm: rpi: Add DT provider for the clocks clk: bcm: rpi: Add an enum for the firmware clocks clk: bcm: rpi: Discover the firmware clocks clk: bcm: rpi: Give firmware clocks a name Revert "clk: bcm2835: remove pllb" ARM: dts: bcm2711: Add firmware clocks node clk: bcm2835: Allow custom CCF flags for the PLLs clk: bcm2835: Don't cache the PLLB rate clk: bcm: rpi: Remove the quirks for the CPU clock Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.txt | 14 +--- Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 59 ++++++++++++++- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 5 +- drivers/clk/bcm/clk-bcm2835.c | 34 ++++++-- drivers/clk/bcm/clk-raspberrypi.c | 311 +++++++++++++++++++++++++++++++++++++++++++----------------------------- drivers/firmware/raspberrypi.c | 14 +++- 6 files changed, 294 insertions(+), 143 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.txt create mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407