| Message ID | cover.1693218539.git.zhoubinbin@loongson.cn |
|---|---|
| Headers | show |
| Series | soc: loongson: Fix some issues about loongson_pm2 | expand |
On Mon, Aug 28, 2023 at 08:38:33PM +0800, Binbin Zhou wrote: > Add compatible for Loongson-2K2000, which also has the Loongson2 > Power Management Unit system controller. > > This is a missing compatible, now we add it. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > drivers/soc/loongson/loongson2_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c > index 796add6e8b63..6d2b3708e947 100644 > --- a/drivers/soc/loongson/loongson2_pm.c > +++ b/drivers/soc/loongson/loongson2_pm.c > @@ -198,6 +198,7 @@ static int loongson2_pm_probe(struct platform_device *pdev) > static const struct of_device_id loongson2_pm_match[] = { > { .compatible = "loongson,ls2k0500-pmc", }, > { .compatible = "loongson,ls2k1000-pmc", }, > + { .compatible = "loongson,ls2k2000-pmc", }, You've not added any new codepaths for this soc, so it is compatible with the existing ones. Why are you not using fallback compatibles for this?
On 28/08/2023 14:38, Binbin Zhou wrote: > Since commit 67694c076bd7 ("soc: loongson2_pm: add power management > support"), the Loongson-2K PM driver was added, but it didn't update the > Kconfig entry for the INPUT dependency, leading to build errors, so > update the Kconfig entry to depend on INPUT. > > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `loongson2_power_button_init': > /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:101:(.text+0x350): undefined reference to `input_allocate_device' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:109:(.text+0x3dc): undefined reference to `input_set_capability' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:111:(.text+0x3e4): undefined reference to `input_register_device' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:125:(.text+0x3fc): undefined reference to `input_free_device' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_report_key': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:425:(.text+0x58c): undefined reference to `input_event' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_sync': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:450:(.text+0x5a0): undefined reference to `input_event' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_report_key': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:425:(.text+0x5b4): undefined reference to `input_event' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_sync': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:450:(.text+0x5c8): undefined reference to `input_event' Trim unrelated parts of path and trim logs to show only one warning, not everything. Best regards, Krzysztof
Hi-- On 8/28/23 05:38, Binbin Zhou wrote: > Since commit 67694c076bd7 ("soc: loongson2_pm: add power management > support"), the Loongson-2K PM driver was added, but it didn't update the > Kconfig entry for the INPUT dependency, leading to build errors, so > update the Kconfig entry to depend on INPUT. > > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `loongson2_power_button_init': > /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:101:(.text+0x350): undefined reference to `input_allocate_device' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:109:(.text+0x3dc): undefined reference to `input_set_capability' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:111:(.text+0x3e4): undefined reference to `input_register_device' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:125:(.text+0x3fc): undefined reference to `input_free_device' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_report_key': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:425:(.text+0x58c): undefined reference to `input_event' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_sync': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:450:(.text+0x5a0): undefined reference to `input_event' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_report_key': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:425:(.text+0x5b4): undefined reference to `input_event' > /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_sync': > /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:450:(.text+0x5c8): undefined reference to `input_event' > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > drivers/soc/loongson/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/loongson/Kconfig b/drivers/soc/loongson/Kconfig > index 314e13bb3e01..1b57af1e5529 100644 > --- a/drivers/soc/loongson/Kconfig > +++ b/drivers/soc/loongson/Kconfig > @@ -20,6 +20,7 @@ config LOONGSON2_GUTS > config LOONGSON2_PM > bool "Loongson-2 SoC Power Management Controller Driver" > depends on LOONGARCH && OF > + depends on INPUT In the failing .config file, CONFIG_INPUT=m. This bool kconfig item is still set/enabled after this patch and the build still fails. You could use depends on INPUT=y if that is appropriate. I dunno. > help > The Loongson-2's power management controller was ACPI, supports ACPI > S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
On 28/08/2023 14:38, Binbin Zhou wrote: > Add compatible for Loongson-2K2000, which also has the Loongson2 > Power Management Unit system controller. > > This is a missing compatible, now we add it. How is it missing? Was support for it added before but not complete? Best regards, Krzysztof
Hi all: Since commit 67694c076bd7 ("soc: loongson2_pm: add power management support"), the Loongson-2K PM driver was added, some issues have been found and this patch set is planned to fix these issues. Specific: Patch 1: Compilation error found by Randy; Patch 2/3: Add Loongson-2K2000 support; Patch 4/5: Add Loongson-2K SoC reboot/shutdown support as part of power management. Thanks. Binbin Zhou (5): soc: loongson: loongson_pm2: add dependency for INPUT dt-bindings: soc: loongson,ls2k-pmc: Add missing compatible for Loongson-2K2000 soc: loongson: loongson_pm2: Add missing compatible for Loongson-2K2000 dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child soc: loongson: loongson_pm2: Populate children syscon nodes .../soc/loongson/loongson,ls2k-pmc.yaml | 30 ++++++++++++++++++- drivers/soc/loongson/Kconfig | 1 + drivers/soc/loongson/loongson2_pm.c | 7 +++++ 3 files changed, 37 insertions(+), 1 deletion(-)