| Message ID | cover.1680682939.git.quic_varada@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable IPQ9754 USB | expand |
On Wed, Apr 05, 2023 at 02:26:42PM +0530, Varadarajan Narayanan wrote: > Add USB phy and controller related nodes > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Changes in v6: > - Introduce fixed regulators for the phy > - Resolved all 'make dtbs_check' messages > + usb_0_qmpphy: phy@7d000 { > + compatible = "qcom,ipq9574-qmp-usb3-phy"; > + reg = <0x0007d000 0xa00>; > + #phy-cells = <0>; > + > + clocks = <&gcc GCC_USB0_AUX_CLK>, > + <&xo_board_clk>, > + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > + <&gcc GCC_USB0_PIPE_CLK>; > + clock-names = "aux", > + "ref", > + "com_aux", Looks like you just ignored my comment that you need to rename this clock (and update the binding). :( https://lore.kernel.org/lkml/ZCaznloORtzgioOP@hovoldconsulting.com/ > + "pipe"; > + > + resets = <&gcc GCC_USB0_PHY_BCR>, > + <&gcc GCC_USB3PHY_0_PHY_BCR>; > + reset-names = "phy", > + "phy_phy"; > + > + vdda-pll-supply = <®_usb_1p8>; > + vdda-phy-supply = <®_usb_0p925>; > + > + status = "disabled"; > + > + #clock-cells = <0>; > + clock-output-names = "usb0_pipe_clk"; > + };A Johan
On Wed, Apr 05, 2023 at 11:15:41AM +0200, Johan Hovold wrote: > On Wed, Apr 05, 2023 at 02:26:42PM +0530, Varadarajan Narayanan wrote: > > Add USB phy and controller related nodes > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v6: > > - Introduce fixed regulators for the phy > > - Resolved all 'make dtbs_check' messages > > > > + usb_0_qmpphy: phy@7d000 { > > + compatible = "qcom,ipq9574-qmp-usb3-phy"; > > + reg = <0x0007d000 0xa00>; > > + #phy-cells = <0>; > > + > > + clocks = <&gcc GCC_USB0_AUX_CLK>, > > + <&xo_board_clk>, > > + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > > + <&gcc GCC_USB0_PIPE_CLK>; > > + clock-names = "aux", > > + "ref", > > + "com_aux", > > Looks like you just ignored my comment that you need to rename this > clock (and update the binding). :( > > https://lore.kernel.org/lkml/ZCaznloORtzgioOP@hovoldconsulting.com/ Sorry. My mistake. Will post a new patch. Ignore V7. Missed the update in the binding. Thanks Varada > > > + "pipe"; > > + > > + resets = <&gcc GCC_USB0_PHY_BCR>, > > + <&gcc GCC_USB3PHY_0_PHY_BCR>; > > + reset-names = "phy", > > + "phy_phy"; > > + > > + vdda-pll-supply = <®_usb_1p8>; > > + vdda-phy-supply = <®_usb_0p925>; > > + > > + status = "disabled"; > > + > > + #clock-cells = <0>; > > + clock-output-names = "usb0_pipe_clk"; > > + };A > > Johan
This patch series adds the relevant phy and controller configurations for enabling USB on IPQ9754 Depends on: https://lore.kernel.org/all/20230217142030.16012-1-quic_devipriy@quicinc.com/ [v6]: - Incorporated review comments - Resolve make dtbs_check messages - Fixed pcs_usb offset - Board dts file name changed [v5]: - Incorporated review comments - 'make dtbs_check' giving the following messages since ipq9574 doesn't have power domains. Hope this is ok /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: phy@7d000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: usb@8a00000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml - Move qmp phy DT node to newer specification [v4]: - Incorporated review comments - Address all 'make dtbs_check' errors [v3]: - Incorporated review comments regarding coding style [v2]: - Incorporated review comments regarding coding style, maintaining sorted order of entries and unused phy register offsets - Removed NOC clock entries from DT node (will be implemented later with interconnect support) - Fixed 'make dtbs_check' errors/warnings [v1]: https://lore.kernel.org/linux-arm-msm/5dac3aa4-8dc7-f9eb-5cf3-b361efdc9494@linaro.org/T/ Varadarajan Narayanan (8): dt-bindings: phy: qcom,qusb2: Document IPQ9574 compatible dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY dt-bindings: usb: dwc3: Add IPQ9574 compatible clk: qcom: gcc-ipq9574: Add USB related clocks phy: qcom-qusb2: add QUSB2 support for IPQ9574 phy: qcom: qmp: Update IPQ9574 USB Phy initialization Sequence arm64: dts: qcom: ipq9574: Add USB related nodes arm64: dts: qcom: ipq9574: Enable USB .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 3 +- .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 2 +- .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++- arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 16 +++ arch/arm64/boot/dts/qcom/ipq9574.dtsi | 120 +++++++++++++++++++++ drivers/clk/qcom/gcc-ipq9574.c | 37 +++++++ drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 115 ++++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 + include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + 9 files changed, 317 insertions(+), 3 deletions(-)