| Message ID | cover.1586094535.git.agx@sigxcpu.org |
|---|---|
| Headers | show |
| Series | iio: vcnl4000: Export near level property for proximity sensor | expand |
On Sun, 5 Apr 2020 15:50:31 +0200 Guido Günther <agx@sigxcpu.org> wrote: > When an object can be considered close to the sensor is hardware > dependent. Allowing to configure the property via device tree > allows to configure this device specific value. > > This is useful for e.g. iio-sensor-proxy to indicate to userspace > if an object is close to the sensor. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Applied. Thanks, > --- > drivers/iio/light/vcnl4000.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c > index ec803c1e81df..985cc39ede8e 100644 > --- a/drivers/iio/light/vcnl4000.c > +++ b/drivers/iio/light/vcnl4000.c > @@ -83,6 +83,7 @@ struct vcnl4000_data { > struct mutex vcnl4000_lock; > struct vcnl4200_channel vcnl4200_al; > struct vcnl4200_channel vcnl4200_ps; > + uint32_t near_level; > }; > > struct vcnl4000_chip_spec { > @@ -343,6 +344,25 @@ static const struct vcnl4000_chip_spec vcnl4000_chip_spec_cfg[] = { > }, > }; > > +static ssize_t vcnl4000_read_near_level(struct iio_dev *indio_dev, > + uintptr_t priv, > + const struct iio_chan_spec *chan, > + char *buf) > +{ > + struct vcnl4000_data *data = iio_priv(indio_dev); > + > + return sprintf(buf, "%u\n", data->near_level); > +} > + > +static const struct iio_chan_spec_ext_info vcnl4000_ext_info[] = { > + { > + .name = "nearlevel", > + .shared = IIO_SEPARATE, > + .read = vcnl4000_read_near_level, > + }, > + { /* sentinel */ } > +}; > + > static const struct iio_chan_spec vcnl4000_channels[] = { > { > .type = IIO_LIGHT, > @@ -351,6 +371,7 @@ static const struct iio_chan_spec vcnl4000_channels[] = { > }, { > .type = IIO_PROXIMITY, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), > + .ext_info = vcnl4000_ext_info, > } > }; > > @@ -440,6 +461,10 @@ static int vcnl4000_probe(struct i2c_client *client, > dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", > data->chip_spec->prod, data->rev); > > + if (device_property_read_u32(&client->dev, "proximity-near-level", > + &data->near_level)) > + data->near_level = 0; > + > indio_dev->dev.parent = &client->dev; > indio_dev->info = &vcnl4000_info; > indio_dev->channels = vcnl4000_channels;
On Sun, 5 Apr 2020 15:50:32 +0200 Guido Günther <agx@sigxcpu.org> wrote: > The vcnl4000 IIO driver introduced a new attribute > "in_proximity_nearlevel". This adds it to the list of documented ABI > for sysfs-bus-iio. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > Documentation/ABI/testing/sysfs-bus-iio-proximity | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-proximity > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-proximity b/Documentation/ABI/testing/sysfs-bus-iio-proximity > new file mode 100644 > index 000000000000..2172f3bb9c64 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-iio-proximity > @@ -0,0 +1,10 @@ > +What: /sys/bus/iio/devices/iio:deviceX/in_proximity_nearlevel > +Date: March 2020 > +KernelVersion: 5.7 > +Contact: linux-iio@vger.kernel.org > +Description: > + Near level for proximity sensors. This is a single integer > + value that tells user space when an object should be > + considered close to the device. If the value read from the > + sensor is above or equal to the value in this file an object > + should typically be considered near.