mbox series

[v2,0/3] Add support for the Mobileye EyeQ6H SoC

Message ID 20240513-eyeq6h-v2-0-ae8c1974b52b@bootlin.com
Headers show
Series Add support for the Mobileye EyeQ6H SoC | expand

Message

Gregory CLEMENT May 13, 2024, 6:34 p.m. UTC
Hello,

Following the support of the EyeQ5 SoC, this series adds the initial
support for a newer SoC, the EyeQ6H.

The EyeQ6H (or "High") from Mobileye is still based on the MIPS I6500
architecture as the EyeQ5. The 2 clusters of this SoC contain 4 cores
each, which are capable of running 4 threads per core. Besides this,
it features multiple controllers such as the classic UART, high-speed
I2C, SPI, as well as CAN-FD, PCIe Gen4, Octal/Quad SPI Flash
interface, Gigabit Ethernet, MIPI CSI-2, MIPI DSI, and eMMC 5.1. It
also includes a Hardware Security Module, Functional Safety Hardware,
and video encoders, among other features.

For now, this series just adds initial support with UART and Pinctrl
support. Another current limitation pointed out in patch 3 is that
only one CPU is actually running. This limitation will be solved with
upcoming series.

The main change in this new version is the use of the new way to name
the clock nodes.

Regards,

Gregory

To: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
To: Théo Lebrun <theo.lebrun@bootlin.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
Cc: linux-mips@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
cc: Tawfik Bayouk <tawfik.bayouk@mobileye.com>
CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
Changes in v2:

- Renamed clock node names based on
  https://lore.kernel.org/all/20240430180415.657067-1-robh@kernel.org/>
- Use "eyeq6h" instead of "eyeq6" for the compatible string
- Move compatible string as the first property
- Link to v1: https://lore.kernel.org/r/20240506-eyeq6h-v1-0-f29b5269cc43@bootlin.com

---
Gregory CLEMENT (3):
      dt-bindings: mips: Add bindings for a new Mobileye SoC EyeQ6H
      MIPS: mobileye: Add EyeQ6H device tree
      MIPS: mobileye: Add EyeQ6H support

 .../devicetree/bindings/mips/mobileye.yaml         |   5 +
 arch/mips/Kbuild.platforms                         |   2 +-
 arch/mips/Kconfig                                  |   7 +-
 arch/mips/boot/dts/Makefile                        |   2 +-
 arch/mips/boot/dts/mobileye/Makefile               |   1 +
 arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts        |  22 ++++
 .../boot/dts/mobileye/eyeq6h-fixed-clocks.dtsi     |  52 ++++++++++
 arch/mips/boot/dts/mobileye/eyeq6h-pins.dtsi       |  88 ++++++++++++++++
 arch/mips/boot/dts/mobileye/eyeq6h.dtsi            |  98 ++++++++++++++++++
 arch/mips/configs/eyeq5_defconfig                  |   1 +
 arch/mips/configs/eyeq6_defconfig                  | 111 +++++++++++++++++++++
 arch/mips/mobileye/Kconfig                         |  26 +++++
 arch/mips/mobileye/Platform                        |   1 +
 13 files changed, 411 insertions(+), 5 deletions(-)
---
base-commit: 07e6a6d7f1d9fa4685003a195032698ba99577bb
change-id: 20240506-eyeq6h-f4c5a95b0909

Best regards,

Comments

Gregory CLEMENT June 10, 2024, 2:47 p.m. UTC | #1
Hello Thomas,

> Hello,
>
> Following the support of the EyeQ5 SoC, this series adds the initial
> support for a newer SoC, the EyeQ6H.
>
> The EyeQ6H (or "High") from Mobileye is still based on the MIPS I6500
> architecture as the EyeQ5. The 2 clusters of this SoC contain 4 cores
> each, which are capable of running 4 threads per core. Besides this,
> it features multiple controllers such as the classic UART, high-speed
> I2C, SPI, as well as CAN-FD, PCIe Gen4, Octal/Quad SPI Flash
> interface, Gigabit Ethernet, MIPI CSI-2, MIPI DSI, and eMMC 5.1. It
> also includes a Hardware Security Module, Functional Safety Hardware,
> and video encoders, among other features.
>
> For now, this series just adds initial support with UART and Pinctrl
> support. Another current limitation pointed out in patch 3 is that
> only one CPU is actually running. This limitation will be solved with
> upcoming series.
>
> The main change in this new version is the use of the new way to name
> the clock nodes.

I sent this second version a month ago and the first version even before
that, and I still haven't received any feedback from your side. Does it
mean that you will merge it?

If you think there are some changes to be made, please let me know now
so I will have time to implement them.

Thanks,

Gregpry

>
> Regards,
>
> Gregory
>
> To: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
> To: Théo Lebrun <theo.lebrun@bootlin.com>
> To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> Cc: linux-mips@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> cc: Tawfik Bayouk <tawfik.bayouk@mobileye.com>
> CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> Changes in v2:
>
> - Renamed clock node names based on
>   https://lore.kernel.org/all/20240430180415.657067-1-robh@kernel.org/>
> - Use "eyeq6h" instead of "eyeq6" for the compatible string
> - Move compatible string as the first property
> - Link to v1: https://lore.kernel.org/r/20240506-eyeq6h-v1-0-f29b5269cc43@bootlin.com
>
> ---
> Gregory CLEMENT (3):
>       dt-bindings: mips: Add bindings for a new Mobileye SoC EyeQ6H
>       MIPS: mobileye: Add EyeQ6H device tree
>       MIPS: mobileye: Add EyeQ6H support
>
>  .../devicetree/bindings/mips/mobileye.yaml         |   5 +
>  arch/mips/Kbuild.platforms                         |   2 +-
>  arch/mips/Kconfig                                  |   7 +-
>  arch/mips/boot/dts/Makefile                        |   2 +-
>  arch/mips/boot/dts/mobileye/Makefile               |   1 +
>  arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts        |  22 ++++
>  .../boot/dts/mobileye/eyeq6h-fixed-clocks.dtsi     |  52 ++++++++++
>  arch/mips/boot/dts/mobileye/eyeq6h-pins.dtsi       |  88 ++++++++++++++++
>  arch/mips/boot/dts/mobileye/eyeq6h.dtsi            |  98 ++++++++++++++++++
>  arch/mips/configs/eyeq5_defconfig                  |   1 +
>  arch/mips/configs/eyeq6_defconfig                  | 111 +++++++++++++++++++++
>  arch/mips/mobileye/Kconfig                         |  26 +++++
>  arch/mips/mobileye/Platform                        |   1 +
>  13 files changed, 411 insertions(+), 5 deletions(-)
> ---
> base-commit: 07e6a6d7f1d9fa4685003a195032698ba99577bb
> change-id: 20240506-eyeq6h-f4c5a95b0909
>
> Best regards,
> -- 
> Gregory CLEMENT <gregory.clement@bootlin.com>
Thomas Bogendoerfer June 10, 2024, 3:17 p.m. UTC | #2
On Mon, Jun 10, 2024 at 04:47:47PM +0200, Gregory CLEMENT wrote:
> > Following the support of the EyeQ5 SoC, this series adds the initial
> > support for a newer SoC, the EyeQ6H.
> >
> > The EyeQ6H (or "High") from Mobileye is still based on the MIPS I6500
> > architecture as the EyeQ5. The 2 clusters of this SoC contain 4 cores
> > each, which are capable of running 4 threads per core. Besides this,
> > it features multiple controllers such as the classic UART, high-speed
> > I2C, SPI, as well as CAN-FD, PCIe Gen4, Octal/Quad SPI Flash
> > interface, Gigabit Ethernet, MIPI CSI-2, MIPI DSI, and eMMC 5.1. It
> > also includes a Hardware Security Module, Functional Safety Hardware,
> > and video encoders, among other features.
> >
> > For now, this series just adds initial support with UART and Pinctrl
> > support. Another current limitation pointed out in patch 3 is that
> > only one CPU is actually running. This limitation will be solved with
> > upcoming series.
> >
> > The main change in this new version is the use of the new way to name
> > the clock nodes.
> 
> I sent this second version a month ago and the first version even before
> that, and I still haven't received any feedback from your side. Does it
> mean that you will merge it?

I will this week. The second version came around merge window, so I didn't
want to include it.

Thomas.
Thomas Bogendoerfer June 11, 2024, 8:42 a.m. UTC | #3
On Mon, May 13, 2024 at 08:34:14PM +0200, Gregory CLEMENT wrote:
> Hello,
> 
> Following the support of the EyeQ5 SoC, this series adds the initial
> support for a newer SoC, the EyeQ6H.
> 
> The EyeQ6H (or "High") from Mobileye is still based on the MIPS I6500
> architecture as the EyeQ5. The 2 clusters of this SoC contain 4 cores
> each, which are capable of running 4 threads per core. Besides this,
> it features multiple controllers such as the classic UART, high-speed
> I2C, SPI, as well as CAN-FD, PCIe Gen4, Octal/Quad SPI Flash
> interface, Gigabit Ethernet, MIPI CSI-2, MIPI DSI, and eMMC 5.1. It
> also includes a Hardware Security Module, Functional Safety Hardware,
> and video encoders, among other features.
> 
> For now, this series just adds initial support with UART and Pinctrl
> support. Another current limitation pointed out in patch 3 is that
> only one CPU is actually running. This limitation will be solved with
> upcoming series.
> 
> The main change in this new version is the use of the new way to name
> the clock nodes.
> 
> Regards,
> 
> Gregory
> 
> To: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
> To: Théo Lebrun <theo.lebrun@bootlin.com>
> To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> Cc: linux-mips@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> cc: Tawfik Bayouk <tawfik.bayouk@mobileye.com>
> CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> Changes in v2:
> 
> - Renamed clock node names based on
>   https://lore.kernel.org/all/20240430180415.657067-1-robh@kernel.org/>
> - Use "eyeq6h" instead of "eyeq6" for the compatible string
> - Move compatible string as the first property
> - Link to v1: https://lore.kernel.org/r/20240506-eyeq6h-v1-0-f29b5269cc43@bootlin.com
> 
> ---
> Gregory CLEMENT (3):
>       dt-bindings: mips: Add bindings for a new Mobileye SoC EyeQ6H
>       MIPS: mobileye: Add EyeQ6H device tree
>       MIPS: mobileye: Add EyeQ6H support
> 
>  .../devicetree/bindings/mips/mobileye.yaml         |   5 +
>  arch/mips/Kbuild.platforms                         |   2 +-
>  arch/mips/Kconfig                                  |   7 +-
>  arch/mips/boot/dts/Makefile                        |   2 +-
>  arch/mips/boot/dts/mobileye/Makefile               |   1 +
>  arch/mips/boot/dts/mobileye/eyeq6h-epm6.dts        |  22 ++++
>  .../boot/dts/mobileye/eyeq6h-fixed-clocks.dtsi     |  52 ++++++++++
>  arch/mips/boot/dts/mobileye/eyeq6h-pins.dtsi       |  88 ++++++++++++++++
>  arch/mips/boot/dts/mobileye/eyeq6h.dtsi            |  98 ++++++++++++++++++
>  arch/mips/configs/eyeq5_defconfig                  |   1 +
>  arch/mips/configs/eyeq6_defconfig                  | 111 +++++++++++++++++++++
>  arch/mips/mobileye/Kconfig                         |  26 +++++
>  arch/mips/mobileye/Platform                        |   1 +
>  13 files changed, 411 insertions(+), 5 deletions(-)
> ---
> base-commit: 07e6a6d7f1d9fa4685003a195032698ba99577bb
> change-id: 20240506-eyeq6h-f4c5a95b0909

series applied to mips-next.

Thomas.