From patchwork Sun Apr 14 20:34:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Garcia X-Patchwork-Id: 1923521 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=luigi311.com header.i=@luigi311.com header.a=rsa-sha256 header.s=x header.b=vRkf9aeT; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=devicetree+bounces-59177-incoming-dt=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VHhyX6DRPz1yZ2 for ; Mon, 15 Apr 2024 06:40:36 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 84CFC1F211BE for ; Sun, 14 Apr 2024 20:40:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ABE2D136E0D; Sun, 14 Apr 2024 20:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="vRkf9aeT" X-Original-To: devicetree@vger.kernel.org Received: from mail-108-mta173.mxroute.com (mail-108-mta173.mxroute.com [136.175.108.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D255A3D56D for ; Sun, 14 Apr 2024 20:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713127227; cv=none; b=DNsp94c/BAtQ4b/GiZnld46iw6tcyS+5aZnDHDokgPi/+ihMa6t9HlWVJf5yjowVWjes/l9YgWt7XXy9cW1lToBYjbSy06YaG9Ked4FIaX7mvegH1yqmz2/Kns7d/L2ezA2NmyBbqSgdUmv+o/3B2whvXVFo3j8Zb7oTT8OdWwk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713127227; c=relaxed/simple; bh=VavDGKWSNy8j0H6V4AyMT//lgYexExvzph0BfMKV5A8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=HW4cT95QU0OJUT2o+NhQhQvA9FhXD1PPoAZQgrcfDtJeAZZooR+lW6KhEcpmlOnW0rzUPsqwpkFm4Q4naIXzSqO6PIqdtubrgRqdPwE2Xltp3t8Lr+X6BUmtkNtW+CCVdN0PHLMtk7BfruTZTS35KJ3qSica4vrjYPwPzHIcowo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=vRkf9aeT; arc=none smtp.client-ip=136.175.108.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta173.mxroute.com (ZoneMTA) with ESMTPSA id 18ede522e540003bea.00f for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 14 Apr 2024 20:35:11 +0000 X-Zone-Loop: c84d2b34f55cadcfc46cd439ca445fefc95bba4783bf DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eP7ba4MG9I/x9pHxrTh4yLTHg0biLr0j/s9u962DdSs=; b=vRkf9aeTPGOwsFaBv01kTdtyPD /VT+LC1QPodsoGjkPhOCMbJyVNOpBO9J2/jga3dluFQ2F+oFxqMxqlQwWalleCHSD4ZEe/jCW5B3m jkzJjzUWPrepc0xtfNFUbIefo36/9AQtVFH7/3Eic8wnTNQhnNmOCXentLIiO0JnZkyZWECQK8+vI SKYTune7/bTqC84pB/pGEevetqTu7TG1ofPqkWxYheRvOfh67JaRhbF8f/YzTWXiN8dVUWWVc627q ixdg3TC6aqzixKG9LbUwF122sRHfuOR1mgipD8jtlxXgaldyz6j5STrp6xMTInAngONdiFwhmx5Hq 3sYWI1Tg==; From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Luis Garcia Subject: [PATCH v4 00/25] imx258 improvement series Date: Sun, 14 Apr 2024 14:34:38 -0600 Message-ID: <20240414203503.18402-1-git@luigi311.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Authenticated-Id: personal@luigi311.com From: Luis Garcia v4: - Swapped out the use macro patch for a patch that uses the new CCI register access helpers per Sakari Ailus - Fix order of reset and powerdown gpio before disable regulators - Fix formating of all patches - Implemented feedback from Pavel Machek - media: i2c: imx258: Follow normal V4L2 behaviours - media: i2c: imx258: Allow configuration of clock - Implemented feedback from Sakari Ailus - media: i2c: imx258: Add support for powerdown gpio v3 Luis Garcia - Add Use v4l2_link_freq_to_bitmap helper patch per Sakari Ailus - Separate dt-bindings for powerdown per Rob Herring - Fix dt-bindings for imx258.yaml - Fix sign offs per Dang Huynh - Fix versioning per Conor Dooley and Kieran Bingham - Use scripts to validate and fix patches - Implemented feedback from Sakari Ailus - media: i2c: imx258: Add support for 24MHz clock - media: i2c: imx258: Add support for running on 2 CSI data lanes - Implemented feedback from Rob Herring - dt-bindings: media: imx258: Add alternate compatible strings v2 Luis Garcia - Add use macros patch - Add support for powerdown gpio patch - Add support for reset gpio patch - Dropped Add support for long exposure modes patch - Implemented feedback from Jacopo Mondi - media: i2c: imx258: Add regulator control - media: i2c: imx258: Add support for 24MHz clock - media: i2c: imx258: Add support for running on 2 CSI data lanes - media: i2c: imx258: Add get_selection for pixel array information - media: i2c: imx258: Issue reset before starting streaming - media: i2c: imx258: Set pixel_rate range to the same as the value - dt-bindings: media: imx258: Add alternate compatible strings - media: i2c: imx258: Change register settings for variants of the sensor - media: i2c: imx258: Make HFLIP and VFLIP controls writable This adds a few more patches and drops one. The long exposure mode patch was dropped due to the bug that Jacopo found. The powerdown and reset gpio patches were added as that fixes support for the Pinephone Pro, without them the sensor doesn't initialize correctly. Tested on a Pinephone Pro by forcing 24 mhz clock and was able to access all 3 resolutions. The two lower resolutions had some artifacts but that is expected as more changes are required to fix them for the Pinephone Pro specifically, kept all registers the same as Dave's original patch since that works on dedicated imx258 hardware and the artifacts are PPP specific so it shouldn't be a regression. v1 Dave Stevenson This is a set of patches for imx258 that allow it to work with alternate clock frequencies, over either 2 or 4 lanes, and generally adding flexibility to the driver. Tested with an IMX258 module from Soho Enterprises that has a 24MHz oscillator. Both 2 and 4 lane configurations work with correct link frequencies and pixel rates. Jacopo has tested on a PinePhone Pro which has an ~19.2MHz clock fed from the SoC, He confirms that the two lower resolution modes work, but not the full res mode. Comparing to the BSP it looks like they have some weird clock configuration in the 4208x3120 mode (nominally 1224Mb/s/lane instead of 1267). As it has never previously worked directly with the mainline driver this isn't a regression but may indicate that there is a need for support of additional link frequencies in the future. The last patch that makes HFLIP and VFLIP configurable may be contentious as I've retained the default configuration of inverted from the original driver. I know this was discussed recently, but I can't recall the final outcome. I am relying on someone from Intel testing this out, as correcting the cropping and supporting flips has changed the Bayer order. Seeing as this is all above board in V4L2 terms I really hope that the layers above it behave themselves. Cheers Dave Dave Stevenson (20): media: i2c: imx258: Remove unused defines media: i2c: imx258: Make image geometry meet sensor requirements media: i2c: imx258: Disable digital cropping on binned modes media: i2c: imx258: Remove redundant I2C writes. media: i2c: imx258: Add regulator control media: i2c: imx258: Make V4L2_CID_VBLANK configurable. media: i2c: imx258: Split out common registers from the mode based ones media: i2c: imx258: Add support for 24MHz clock media: i2c: imx258: Add support for running on 2 CSI data lanes media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure media: i2c: imx258: Add get_selection for pixel array information media: i2c: imx258: Allow configuration of clock lane behaviour media: i2c: imx258: Correct max FRM_LENGTH_LINES value media: i2c: imx258: Issue reset before starting streaming media: i2c: imx258: Set pixel_rate range to the same as the value media: i2c: imx258: Support faster pixel rate on binned modes dt-bindings: media: imx258: Rename to include vendor prefix dt-bindings: media: imx258: Add alternate compatible strings media: i2c: imx258: Change register settings for variants of the sensor media: i2c: imx258: Make HFLIP and VFLIP controls writable Luis Garcia (5): dt-bindings: media: imx258: Add binding for powerdown-gpio media: i2c: imx258: Add support for powerdown gpio media: i2c: imx258: Add support for reset gpio media:i2c: imx258: Use v4l2_link_freq_to_bitmap helper media: i2c: imx258: Convert to new CCI register access helpers .../i2c/{imx258.yaml => sony,imx258.yaml} | 15 +- MAINTAINERS | 2 +- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx258.c | 1439 ++++++++++------- 4 files changed, 848 insertions(+), 609 deletions(-) rename Documentation/devicetree/bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} (86%) Reviewed-by: Tommaso Merciai Reviewed-by: Tommaso Merciai