| Message ID | 20240318-asrc_8qxp-v7-0-01ce5264a761@nxp.com |
|---|---|
| Headers | show |
| Series | arm64: dts: imx8qxp add asrc and sai | expand |
On Mon, Mar 18, 2024 at 03:00:06PM -0400, Frank Li wrote: > Update binding doc to avoid warning. > Change from v1 to v2 > - Fixed dts DTB_CHECK warning > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Changes in v7: > - Using rob method for dma-names > - Drop conor acked tag form dma-names and interrupt patches > - Fixed warning for interrupts > - Pass dt_bindng check > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,sai.yaml > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/sound/fsl,sai.example.dts > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC_CHK Documentation/devicetree/bindings/sound/fsl,sai.example.dtb > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,spdif.yaml > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/sound/fsl,spdif.example.dts > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC_CHK Documentation/devicetree/bindings/sound/fsl,spdif.example.dtb > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,imx-asrc.yaml > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/sound/fsl,imx-asrc.example.dts > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC_CHK Documentation/devicetree/bindings/sound/fsl,imx-asrc.example.dtb > > - Pass DTB_CHECK, below warning exist because binding doc still be txt. > > from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# > arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: /bus@59000000/amix@59840000: failed to match any schema with compatible: ['fsl,imx8qm-audmix'] > > - Link to v6: https://lore.kernel.org/r/20240308-asrc_8qxp-v6-0-e08f6d030e09@nxp.com > > Changes in v6: > - Add interrupt description in binding doc according to rob suggestion > - Link to v5: https://lore.kernel.org/r/20240307-asrc_8qxp-v5-0-db363740368d@nxp.com > > Changes in v5: > - using rob's suggest logic after fix maxItems. > - sort dts nodes. > - remove spdif1. Add later when do 8qm upstream > - Link to v4: https://lore.kernel.org/r/20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com > > Changes in v4: > Combine comments' from v2 and v3. I hope I address everythings. > > - Krzysztof's comments > - add reson about why change > > - rob's comments > using rob's suggest logic to restrict interrupt number > but for dma-names, still need use oneOf to cover 3 case > - [rx, tx] > - [rx] > - [tx] > > oneOf > - items: > - tx > - rx > - enums: [rx, tx] > > - Conor's comments > - add power-domains required for imx8qxp and imx8qm > - remove dmas descript, not allow use index to get dma-channel. Current > no user using this method. > > - Link to v3: https://lore.kernel.org/r/20240228-asrc_8qxp-v3-0-d4d5935fd3aa@nxp.com > > Changes in v3: > - Fixed dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,spdif.example.dtb: spdif@2004000: interrupts: [[0, 52, 4]] is too short > from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml# > > - Link to v2: https://lore.kernel.org/r/20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com > > --- > Frank Li (4): > ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains property > ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers > ASoC: dt-bindings: fsl-sai: allow only one dma-names @Mark Brown: Could you please pick dt-bindings part? Reviewed by dt team. Frank > arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif0 and sai[4,5] > > .../devicetree/bindings/sound/fsl,imx-asrc.yaml | 14 ++ > .../devicetree/bindings/sound/fsl,sai.yaml | 6 +- > .../devicetree/bindings/sound/fsl,spdif.yaml | 35 ++- > arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi | 267 +++++++++++++++++++++ > 4 files changed, 317 insertions(+), 5 deletions(-) > --- > base-commit: 8552c902efe7ef670b6961fb8885b67961aeb629 > change-id: 20240227-asrc_8qxp-25aa6783840f > > Best regards, > -- > Frank Li <Frank.Li@nxp.com> >
On Tue, Mar 26, 2024 at 10:14:17AM -0400, Frank Li wrote: > @Mark Brown: My name doesn't have any @s in it... > Could you please pick dt-bindings part? Reviewed by dt team. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
Update binding doc to avoid warning. Change from v1 to v2 - Fixed dts DTB_CHECK warning Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Changes in v7: - Using rob method for dma-names - Drop conor acked tag form dma-names and interrupt patches - Fixed warning for interrupts - Pass dt_bindng check make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,sai.yaml LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/sound/fsl,sai.example.dts CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK Documentation/devicetree/bindings/sound/fsl,sai.example.dtb make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,spdif.yaml LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/sound/fsl,spdif.example.dts CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK Documentation/devicetree/bindings/sound/fsl,spdif.example.dtb make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,imx-asrc.yaml LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/sound/fsl,imx-asrc.example.dts CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK Documentation/devicetree/bindings/sound/fsl,imx-asrc.example.dtb - Pass DTB_CHECK, below warning exist because binding doc still be txt. from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: /bus@59000000/amix@59840000: failed to match any schema with compatible: ['fsl,imx8qm-audmix'] - Link to v6: https://lore.kernel.org/r/20240308-asrc_8qxp-v6-0-e08f6d030e09@nxp.com Changes in v6: - Add interrupt description in binding doc according to rob suggestion - Link to v5: https://lore.kernel.org/r/20240307-asrc_8qxp-v5-0-db363740368d@nxp.com Changes in v5: - using rob's suggest logic after fix maxItems. - sort dts nodes. - remove spdif1. Add later when do 8qm upstream - Link to v4: https://lore.kernel.org/r/20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com Changes in v4: Combine comments' from v2 and v3. I hope I address everythings. - Krzysztof's comments - add reson about why change - rob's comments using rob's suggest logic to restrict interrupt number but for dma-names, still need use oneOf to cover 3 case - [rx, tx] - [rx] - [tx] oneOf - items: - tx - rx - enums: [rx, tx] - Conor's comments - add power-domains required for imx8qxp and imx8qm - remove dmas descript, not allow use index to get dma-channel. Current no user using this method. - Link to v3: https://lore.kernel.org/r/20240228-asrc_8qxp-v3-0-d4d5935fd3aa@nxp.com Changes in v3: - Fixed dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,spdif.example.dtb: spdif@2004000: interrupts: [[0, 52, 4]] is too short from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml# - Link to v2: https://lore.kernel.org/r/20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com --- Frank Li (4): ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains property ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers ASoC: dt-bindings: fsl-sai: allow only one dma-names arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif0 and sai[4,5] .../devicetree/bindings/sound/fsl,imx-asrc.yaml | 14 ++ .../devicetree/bindings/sound/fsl,sai.yaml | 6 +- .../devicetree/bindings/sound/fsl,spdif.yaml | 35 ++- arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi | 267 +++++++++++++++++++++ 4 files changed, 317 insertions(+), 5 deletions(-) --- base-commit: 8552c902efe7ef670b6961fb8885b67961aeb629 change-id: 20240227-asrc_8qxp-25aa6783840f Best regards,