| Message ID | 20240103-linux-next-24-01-02-sc8280xp-camss-core-dtsi-v1-0-abacaa63a961@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp: Add CAMSS core dtsi support | expand |
On 3.01.2024 03:18, Bryan O'Donoghue wrote: > sc8280xp has four Camera Control Interface (CCI) blocks which pinout to > two I2C master controllers for each CCI. > > The CCI I2C pins are not muxed so we define them in the dtsi. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 324 +++++++++++++++++++++++++++++++++ > 1 file changed, 324 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index febf28356ff8..4f6acd4a3f00 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -3451,6 +3451,170 @@ usb_1_role_switch: endpoint { > }; > }; > > + cci0: cci@ac4a000 { > + compatible = "qcom,sm8250-cci", "qcom,msm8996-cci"; 8280, 8250 instead > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0 0x0ac4a000 0 0x1000>; > + interrupts = <GIC_SPI 460 IRQ_TYPE_EDGE_RISING>; > + power-domains = <&camcc TITAN_TOP_GDSC>; > + > + clocks = <&camcc CAMCC_CAMNOC_AXI_CLK>, > + <&camcc CAMCC_SLOW_AHB_CLK_SRC>, > + <&camcc CAMCC_CPAS_AHB_CLK>, > + <&camcc CAMCC_CCI_0_CLK>, > + <&camcc CAMCC_CCI_0_CLK_SRC>; Is this _src really necessary? (the one above seems to be) > + clock-names = "camnoc_axi", > + "slow_ahb_src", > + "cpas_ahb", > + "cci", > + "cci_src"; > + > + pinctrl-0 = <&cci0_default>; > + pinctrl-1 = <&cci0_sleep>; > + pinctrl-names = "default", "sleep"; please refer to Documentation/devicetree/bindings/dts-coding-style.rst [...] > + cci0_default: cci0-default-state { > + cci0_i2c0_default: cci0-i2c0-default-pins { > + /* cci_i2c_sda0, cci_i2c_scl0 */ > + pins = "gpio113", "gpio114"; > + function = "cci_i2c"; > + > + bias-pull-up; > + drive-strength = <2>; /* 2 mA */ The mA comments seem unnecessary Also, please follow the style of existing pin nodes: pins function drive-strength bias- output- Konrad
On 03/01/2024 03:18, Bryan O'Donoghue wrote: > This series adds the yaml, CAMSS and CCI dts definitions for the sc8280xp. > > 4 x CCI master busses > 4 x VFE > 4 x VFE Lite > 4 x CSID > 4 x CSIPHY > > Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Bryan O'Donoghue (3): > media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding > arm64: dts: qcom: sc8280xp: camss: Add CCI definitions > arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition > > .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++ > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 563 +++++++++++++++++++++ > 2 files changed, 1075 insertions(+) > --- > base-commit: ab0b3e6ef50d305278b1971891cf1d82ab050b35 BTW, this also does not help, when used on random commit or random tree: $ git show ab0b3e6ef50d305278b1971891cf1d82ab050b35 fatal: bad object ab0b3e6ef50d305278b1971891cf1d82ab050b35 Best regards, Krzysztof
On 04/01/2024 12:42, Krzysztof Kozlowski wrote: > On 03/01/2024 03:18, Bryan O'Donoghue wrote: >> This series adds the yaml, CAMSS and CCI dts definitions for the sc8280xp. >> >> 4 x CCI master busses >> 4 x VFE >> 4 x VFE Lite >> 4 x CSID >> 4 x CSIPHY >> >> Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> Bryan O'Donoghue (3): >> media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding >> arm64: dts: qcom: sc8280xp: camss: Add CCI definitions >> arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition >> >> .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 563 +++++++++++++++++++++ >> 2 files changed, 1075 insertions(+) >> --- >> base-commit: ab0b3e6ef50d305278b1971891cf1d82ab050b35 > > BTW, this also does not help, when used on random commit or random tree: > > $ git show ab0b3e6ef50d305278b1971891cf1d82ab050b35 > fatal: bad object ab0b3e6ef50d305278b1971891cf1d82ab050b35 > > Best regards, > Krzysztof > That's a b4 thing I think, not sure what it uses it for. --- bod
This series adds the yaml, CAMSS and CCI dts definitions for the sc8280xp. 4 x CCI master busses 4 x VFE 4 x VFE Lite 4 x CSID 4 x CSIPHY Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-24-01-02-sc8280xp-camss-core-dtsi Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Bryan O'Donoghue (3): media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding arm64: dts: qcom: sc8280xp: camss: Add CCI definitions arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 563 +++++++++++++++++++++ 2 files changed, 1075 insertions(+) --- base-commit: ab0b3e6ef50d305278b1971891cf1d82ab050b35 change-id: 20240102-linux-next-24-01-02-sc8280xp-camss-core-dtsi-2730a5f7ef98 Best regards,