| Message ID | 20231204185719.569021-1-macroalpha82@gmail.com |
|---|---|
| Headers | show |
| Series | rockchip: Add Powkiddy X55 | expand |
On 04/12/2023 19:57, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Drop the panel specific prepare/unprepare logic. This is now tracked > by the DRM stack [1]. > > [1] commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in > drm_panel") > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > drivers/gpu/drm/panel/panel-himax-hx8394.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c > index c73243d85de7..3823ff388b96 100644 > --- a/drivers/gpu/drm/panel/panel-himax-hx8394.c > +++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c > @@ -68,7 +68,6 @@ struct hx8394 { > struct gpio_desc *reset_gpio; > struct regulator *vcc; > struct regulator *iovcc; > - bool prepared; > > const struct hx8394_panel_desc *desc; > }; > @@ -262,16 +261,11 @@ static int hx8394_unprepare(struct drm_panel *panel) > { > struct hx8394 *ctx = panel_to_hx8394(panel); > > - if (!ctx->prepared) > - return 0; > - > gpiod_set_value_cansleep(ctx->reset_gpio, 1); > > regulator_disable(ctx->iovcc); > regulator_disable(ctx->vcc); > > - ctx->prepared = false; > - > return 0; > } > > @@ -280,9 +274,6 @@ static int hx8394_prepare(struct drm_panel *panel) > struct hx8394 *ctx = panel_to_hx8394(panel); > int ret; > > - if (ctx->prepared) > - return 0; > - > gpiod_set_value_cansleep(ctx->reset_gpio, 1); > > ret = regulator_enable(ctx->vcc); > @@ -301,8 +292,6 @@ static int hx8394_prepare(struct drm_panel *panel) > > msleep(180); > > - ctx->prepared = true; > - > return 0; > > disable_vcc: Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 04/12/2023 19:57, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add support for setting the rotation property for the Himax HX8394 > panel. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > drivers/gpu/drm/panel/panel-himax-hx8394.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c > index d8e590d5e1da..b68ea09f4725 100644 > --- a/drivers/gpu/drm/panel/panel-himax-hx8394.c > +++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c > @@ -68,6 +68,7 @@ struct hx8394 { > struct gpio_desc *reset_gpio; > struct regulator *vcc; > struct regulator *iovcc; > + enum drm_panel_orientation orientation; > > const struct hx8394_panel_desc *desc; > }; > @@ -324,12 +325,20 @@ static int hx8394_get_modes(struct drm_panel *panel, > return 1; > } > > +static enum drm_panel_orientation hx8394_get_orientation(struct drm_panel *panel) > +{ > + struct hx8394 *ctx = panel_to_hx8394(panel); > + > + return ctx->orientation; > +} > + > static const struct drm_panel_funcs hx8394_drm_funcs = { > .disable = hx8394_disable, > .unprepare = hx8394_unprepare, > .prepare = hx8394_prepare, > .enable = hx8394_enable, > .get_modes = hx8394_get_modes, > + .get_orientation = hx8394_get_orientation, > }; > > static int hx8394_probe(struct mipi_dsi_device *dsi) > @@ -347,6 +356,12 @@ static int hx8394_probe(struct mipi_dsi_device *dsi) > return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), > "Failed to get reset gpio\n"); > > + ret = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation); > + if (ret < 0) { > + dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, ret); > + return ret; > + } > + > mipi_dsi_set_drvdata(dsi, ctx); > > ctx->dev = dev; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 04/12/2023 19:57, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add support for the Powkiddy X55 panel as used on the Powkiddy X55 > handheld gaming console. This panel uses a Himax HX8394 display > controller and requires a vendor provided init sequence. The display > resolution is 720x1280 and is 67mm by 121mm as measured with calipers. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > drivers/gpu/drm/panel/panel-himax-hx8394.c | 137 +++++++++++++++++++++ > 1 file changed, 137 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c > index b68ea09f4725..ff0dc08b9829 100644 > --- a/drivers/gpu/drm/panel/panel-himax-hx8394.c > +++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c > @@ -38,6 +38,7 @@ > #define HX8394_CMD_SETMIPI 0xba > #define HX8394_CMD_SETOTP 0xbb > #define HX8394_CMD_SETREGBANK 0xbd > +#define HX8394_CMD_UNKNOWN5 0xbf > #define HX8394_CMD_UNKNOWN1 0xc0 > #define HX8394_CMD_SETDGCLUT 0xc1 > #define HX8394_CMD_SETID 0xc3 > @@ -52,6 +53,7 @@ > #define HX8394_CMD_SETGIP1 0xd5 > #define HX8394_CMD_SETGIP2 0xd6 > #define HX8394_CMD_SETGPO 0xd6 > +#define HX8394_CMD_UNKNOWN4 0xd8 > #define HX8394_CMD_SETSCALING 0xdd > #define HX8394_CMD_SETIDLE 0xdf > #define HX8394_CMD_SETGAMMA 0xe0 > @@ -203,6 +205,140 @@ static const struct hx8394_panel_desc hsd060bhw4_desc = { > .init_sequence = hsd060bhw4_init_sequence, > }; > > +static int powkiddy_x55_init_sequence(struct hx8394 *ctx) > +{ > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > + > + /* 5.19.8 SETEXTC: Set extension command (B9h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETEXTC, > + 0xff, 0x83, 0x94); > + > + /* 5.19.9 SETMIPI: Set MIPI control (BAh) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETMIPI, > + 0x63, 0x03, 0x68, 0x6b, 0xb2, 0xc0); > + > + /* 5.19.2 SETPOWER: Set power (B1h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETPOWER, > + 0x48, 0x12, 0x72, 0x09, 0x32, 0x54, 0x71, 0x71, 0x57, 0x47); > + > + /* 5.19.3 SETDISP: Set display related register (B2h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETDISP, > + 0x00, 0x80, 0x64, 0x2c, 0x16, 0x2f); > + > + /* 5.19.4 SETCYC: Set display waveform cycles (B4h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETCYC, > + 0x73, 0x74, 0x73, 0x74, 0x73, 0x74, 0x01, 0x0c, 0x86, 0x75, > + 0x00, 0x3f, 0x73, 0x74, 0x73, 0x74, 0x73, 0x74, 0x01, 0x0c, > + 0x86); > + > + /* 5.19.5 SETVCOM: Set VCOM voltage (B6h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETVCOM, > + 0x6e, 0x6e); > + > + /* 5.19.19 SETGIP0: Set GIP Option0 (D3h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGIP0, > + 0x00, 0x00, 0x07, 0x07, 0x40, 0x07, 0x0c, 0x00, 0x08, 0x10, > + 0x08, 0x00, 0x08, 0x54, 0x15, 0x0a, 0x05, 0x0a, 0x02, 0x15, > + 0x06, 0x05, 0x06, 0x47, 0x44, 0x0a, 0x0a, 0x4b, 0x10, 0x07, > + 0x07, 0x0c, 0x40); > + > + /* 5.19.20 Set GIP Option1 (D5h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGIP1, > + 0x1c, 0x1c, 0x1d, 0x1d, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, > + 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x24, 0x25, 0x18, 0x18, > + 0x26, 0x27, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, > + 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x20, 0x21, > + 0x18, 0x18, 0x18, 0x18); > + > + /* 5.19.21 Set GIP Option2 (D6h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGIP2, > + 0x1c, 0x1c, 0x1d, 0x1d, 0x07, 0x06, 0x05, 0x04, 0x03, 0x02, > + 0x01, 0x00, 0x0b, 0x0a, 0x09, 0x08, 0x21, 0x20, 0x18, 0x18, > + 0x27, 0x26, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, > + 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x25, 0x24, > + 0x18, 0x18, 0x18, 0x18); > + > + /* 5.19.25 SETGAMMA: Set gamma curve related setting (E0h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETGAMMA, > + 0x00, 0x0a, 0x15, 0x1b, 0x1e, 0x21, 0x24, 0x22, 0x47, 0x56, > + 0x65, 0x66, 0x6e, 0x82, 0x88, 0x8b, 0x9a, 0x9d, 0x98, 0xa8, > + 0xb9, 0x5d, 0x5c, 0x61, 0x66, 0x6a, 0x6f, 0x7f, 0x7f, 0x00, > + 0x0a, 0x15, 0x1b, 0x1e, 0x21, 0x24, 0x22, 0x47, 0x56, 0x65, > + 0x65, 0x6e, 0x81, 0x87, 0x8b, 0x98, 0x9d, 0x99, 0xa8, 0xba, > + 0x5d, 0x5d, 0x62, 0x67, 0x6b, 0x72, 0x7f, 0x7f); > + > + /* Unknown command, not listed in the HX8394-F datasheet */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN1, > + 0x1f, 0x31); > + > + /* 5.19.17 SETPANEL (CCh) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETPANEL, > + 0x0b); > + > + /* Unknown command, not listed in the HX8394-F datasheet */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN3, > + 0x02); > + > + /* 5.19.11 Set register bank (BDh) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETREGBANK, > + 0x02); > + > + /* Unknown command, not listed in the HX8394-F datasheet */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN4, > + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, > + 0xff, 0xff); > + > + /* 5.19.11 Set register bank (BDh) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETREGBANK, > + 0x00); > + > + /* 5.19.11 Set register bank (BDh) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETREGBANK, > + 0x01); > + > + /* 5.19.2 SETPOWER: Set power (B1h) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETPOWER, > + 0x00); > + > + /* 5.19.11 Set register bank (BDh) */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_SETREGBANK, > + 0x00); > + > + /* Unknown command, not listed in the HX8394-F datasheet */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN5, > + 0x40, 0x81, 0x50, 0x00, 0x1a, 0xfc, 0x01); > + > + /* Unknown command, not listed in the HX8394-F datasheet */ > + mipi_dsi_dcs_write_seq(dsi, HX8394_CMD_UNKNOWN2, > + 0xed); > + > + return 0; > +} > + > +static const struct drm_display_mode powkiddy_x55_mode = { > + .hdisplay = 720, > + .hsync_start = 720 + 44, > + .hsync_end = 720 + 44 + 20, > + .htotal = 720 + 44 + 20 + 20, > + .vdisplay = 1280, > + .vsync_start = 1280 + 12, > + .vsync_end = 1280 + 12 + 10, > + .vtotal = 1280 + 12 + 10 + 10, > + .clock = 63290, > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > + .width_mm = 67, > + .height_mm = 121, > +}; > + > +static const struct hx8394_panel_desc powkiddy_x55_desc = { > + .mode = &powkiddy_x55_mode, > + .lanes = 4, > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET, > + .format = MIPI_DSI_FMT_RGB888, > + .init_sequence = powkiddy_x55_init_sequence, > +}; > + > static int hx8394_enable(struct drm_panel *panel) > { > struct hx8394 *ctx = panel_to_hx8394(panel); > @@ -419,6 +555,7 @@ static void hx8394_remove(struct mipi_dsi_device *dsi) > > static const struct of_device_id hx8394_of_match[] = { > { .compatible = "hannstar,hsd060bhw4", .data = &hsd060bhw4_desc }, > + { .compatible = "powkiddy,x55-panel", .data = &powkiddy_x55_desc }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, hx8394_of_match); Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 04/12/2023 19:57, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > The driver shutdown is duplicate as it calls drm_unprepare and > drm_disable which are called anyway when associated drivers are > shutdown/removed. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > drivers/gpu/drm/panel/panel-himax-hx8394.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c > index 3823ff388b96..d8e590d5e1da 100644 > --- a/drivers/gpu/drm/panel/panel-himax-hx8394.c > +++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c > @@ -390,27 +390,11 @@ static int hx8394_probe(struct mipi_dsi_device *dsi) > return 0; > } > > -static void hx8394_shutdown(struct mipi_dsi_device *dsi) > -{ > - struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret = drm_panel_disable(&ctx->panel); > - if (ret < 0) > - dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret); > - > - ret = drm_panel_unprepare(&ctx->panel); > - if (ret < 0) > - dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret); > -} > - > static void hx8394_remove(struct mipi_dsi_device *dsi) > { > struct hx8394 *ctx = mipi_dsi_get_drvdata(dsi); > int ret; > > - hx8394_shutdown(dsi); > - > ret = mipi_dsi_detach(dsi); > if (ret < 0) > dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > @@ -427,7 +411,6 @@ MODULE_DEVICE_TABLE(of, hx8394_of_match); > static struct mipi_dsi_driver hx8394_driver = { > .probe = hx8394_probe, > .remove = hx8394_remove, > - .shutdown = hx8394_shutdown, > .driver = { > .name = DRV_NAME, > .of_match_table = hx8394_of_match, Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Mon, 04 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > console. > > Changes since V1: > - Corrected a bug with the DRM mode flags for the video driver. > - Adjusted panel front and back porch and pixel clock to fix > issues with display that occurred after correcting DRM mode > flag bug. > - Add a new clk frequency for PLL_VPLL to get panel to run at ~60hz. > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [01/10] drm/panel: himax-hx8394: Drop prepare/unprepare tracking https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8c2c5d1d33f0725b7995f44f87a81311d13a441d [02/10] drm/panel: himax-hx8394: Drop shutdown logic https://cgit.freedesktop.org/drm/drm-misc/commit/?id=e4f53a4d921eba6187a2599cf184a3beeb604fe2 [03/10] dt-bindings: display: Document Himax HX8394 panel rotation https://cgit.freedesktop.org/drm/drm-misc/commit/?id=be478bc7ab08127473ce9ed893378cc2a8762611 [04/10] drm/panel: himax-hx8394: Add Panel Rotation Support https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a695a5009c8fd239a98d98209489997ff5397d2b [05/10] dt-bindings: display: himax-hx8394: Add Powkiddy X55 panel https://cgit.freedesktop.org/drm/drm-misc/commit/?id=00830a0d8f0d820335e7beb26e251069d90f2574 [06/10] drm/panel: himax-hx8394: Add Support for Powkiddy X55 panel https://cgit.freedesktop.org/drm/drm-misc/commit/?id=38db985966d2f0f89f7e1891253489a16936fc5e [07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 (no commit info) [08/10] clk: rockchip: rk3568: Add PLL rate for 126.4MHz (no commit info) [09/10] dt-bindings: arm: rockchip: Add Powkiddy X55 (no commit info) [10/10] arm64: dts: rockchip: Add Powkiddy X55 (no commit info)
On 05/12/2023 09:26, Neil Armstrong wrote: > Hi, > > On Mon, 04 Dec 2023 12:57:09 -0600, Chris Morgan wrote: >> From: Chris Morgan <macromorgan@hotmail.com> >> >> Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming >> console. >> >> Changes since V1: >> - Corrected a bug with the DRM mode flags for the video driver. >> - Adjusted panel front and back porch and pixel clock to fix >> issues with display that occurred after correcting DRM mode >> flag bug. >> - Add a new clk frequency for PLL_VPLL to get panel to run at ~60hz. >> >> [...] > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) > > [01/10] drm/panel: himax-hx8394: Drop prepare/unprepare tracking > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8c2c5d1d33f0725b7995f44f87a81311d13a441d > [02/10] drm/panel: himax-hx8394: Drop shutdown logic > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=e4f53a4d921eba6187a2599cf184a3beeb604fe2 > [03/10] dt-bindings: display: Document Himax HX8394 panel rotation > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=be478bc7ab08127473ce9ed893378cc2a8762611 > [04/10] drm/panel: himax-hx8394: Add Panel Rotation Support > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a695a5009c8fd239a98d98209489997ff5397d2b > [05/10] dt-bindings: display: himax-hx8394: Add Powkiddy X55 panel > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=00830a0d8f0d820335e7beb26e251069d90f2574 > [06/10] drm/panel: himax-hx8394: Add Support for Powkiddy X55 panel > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=38db985966d2f0f89f7e1891253489a16936fc5e > [07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 > (no commit info) > [08/10] clk: rockchip: rk3568: Add PLL rate for 126.4MHz > (no commit info) > [09/10] dt-bindings: arm: rockchip: Add Powkiddy X55 > (no commit info) > [10/10] arm64: dts: rockchip: Add Powkiddy X55 > (no commit info) > To clarify, only patches 1 to 6 were applied to drm-misc-next, Thanks, Neil
Am Dienstag, 5. Dezember 2023, 09:28:24 CET schrieb Neil Armstrong: > On 05/12/2023 09:26, Neil Armstrong wrote: > > Hi, > > > > On Mon, 04 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > >> From: Chris Morgan <macromorgan@hotmail.com> > >> > >> Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > >> console. > >> > >> Changes since V1: > >> - Corrected a bug with the DRM mode flags for the video driver. > >> - Adjusted panel front and back porch and pixel clock to fix > >> issues with display that occurred after correcting DRM mode > >> flag bug. > >> - Add a new clk frequency for PLL_VPLL to get panel to run at ~60hz. > >> > >> [...] > > > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) > > > > [01/10] drm/panel: himax-hx8394: Drop prepare/unprepare tracking > > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8c2c5d1d33f0725b7995f44f87a81311d13a441d > > [02/10] drm/panel: himax-hx8394: Drop shutdown logic > > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=e4f53a4d921eba6187a2599cf184a3beeb604fe2 > > [03/10] dt-bindings: display: Document Himax HX8394 panel rotation > > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=be478bc7ab08127473ce9ed893378cc2a8762611 > > [04/10] drm/panel: himax-hx8394: Add Panel Rotation Support > > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a695a5009c8fd239a98d98209489997ff5397d2b > > [05/10] dt-bindings: display: himax-hx8394: Add Powkiddy X55 panel > > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=00830a0d8f0d820335e7beb26e251069d90f2574 > > [06/10] drm/panel: himax-hx8394: Add Support for Powkiddy X55 panel > > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=38db985966d2f0f89f7e1891253489a16936fc5e > > [07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 > > (no commit info) > > [08/10] clk: rockchip: rk3568: Add PLL rate for 126.4MHz > > (no commit info) > > [09/10] dt-bindings: arm: rockchip: Add Powkiddy X55 > > (no commit info) > > [10/10] arm64: dts: rockchip: Add Powkiddy X55 > > (no commit info) > > > > To clarify, only patches 1 to 6 were applied to drm-misc-next, thanks for the clarification (and applying the patches already) Heiko
On Mon, 4 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > console. > > Changes since V1: > - Corrected a bug with the DRM mode flags for the video driver. > - Adjusted panel front and back porch and pixel clock to fix > issues with display that occurred after correcting DRM mode > flag bug. > - Add a new clk frequency for PLL_VPLL to get panel to run at ~60hz. > > [...] Applied, thanks! [07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 commit: 721bf080f249ab2adcc4337abe164230bfb8594f [08/10] clk: rockchip: rk3568: Add PLL rate for 126.4MHz commit: 685da6972647b486980c0cc8fd6bb5d3863fd6b7 Best regards,
On Mon, 4 Dec 2023 12:57:09 -0600, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming > console. > > Changes since V1: > - Corrected a bug with the DRM mode flags for the video driver. > - Adjusted panel front and back porch and pixel clock to fix > issues with display that occurred after correcting DRM mode > flag bug. > - Add a new clk frequency for PLL_VPLL to get panel to run at ~60hz. > > [...] Applied, thanks! [09/10] dt-bindings: arm: rockchip: Add Powkiddy X55 commit: b7d755653790b5f5497df8bfb146c38beeb33b74 [10/10] arm64: dts: rockchip: Add Powkiddy X55 commit: 009e2d0c224913eb4f44e9c2efe7a15789fc0c18 Best regards,
From: Chris Morgan <macromorgan@hotmail.com> Add support for the Rockchip RK3566 based Powkiddy X55 handheld gaming console. Changes since V1: - Corrected a bug with the DRM mode flags for the video driver. - Adjusted panel front and back porch and pixel clock to fix issues with display that occurred after correcting DRM mode flag bug. - Add a new clk frequency for PLL_VPLL to get panel to run at ~60hz. Chris Morgan (10): drm/panel: himax-hx8394: Drop prepare/unprepare tracking drm/panel: himax-hx8394: Drop shutdown logic dt-bindings: display: Document Himax HX8394 panel rotation drm/panel: himax-hx8394: Add Panel Rotation Support dt-bindings: display: himax-hx8394: Add Powkiddy X55 panel drm/panel: himax-hx8394: Add Support for Powkiddy X55 panel clk: rockchip: Mark pclk_usb as critical on rk3568 clk: rockchip: rk3568: Add PLL rate for 126.4MHz dt-bindings: arm: rockchip: Add Powkiddy X55 arm64: dts: rockchip: Add Powkiddy X55 .../devicetree/bindings/arm/rockchip.yaml | 1 + .../bindings/display/panel/himax,hx8394.yaml | 3 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3566-powkiddy-x55.dts | 926 ++++++++++++++++++ drivers/clk/rockchip/clk-rk3568.c | 2 + drivers/gpu/drm/panel/panel-himax-hx8394.c | 180 +++- 6 files changed, 1085 insertions(+), 28 deletions(-) create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-powkiddy-x55.dts