mbox series

[v2,0/3] imx8qm/imx8qxp: Support for inverted PWM

Message ID 20231106151326.812099-1-alexander.stein@ew.tq-group.com
Headers show
Series imx8qm/imx8qxp: Support for inverted PWM | expand

Message

Alexander Stein Nov. 6, 2023, 3:13 p.m. UTC 
Hi,

this small series adds support for inverted PWM output i.MX8QM/QXP.
Driver is already there, but #pwm-cells needs to be adjusted in DT.
While at it, enforce the same #pwm-cells value for all compatibles.

Changes in v2:
* Rework patch 1: Set #pwm-cells fixes to 1
* Rework comment accordingly
  The only compatible for <2> aready uses <3> instead
* Collected Uwe's R-b

Thanks
Alexander

Alexander Stein (3):
  dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles
  arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells
  arm64: dts: freescale: imx8-ss-dma: Fix #pwm-cells

 Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
 arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi     |  2 +-
 arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi    |  8 ++++----
 3 files changed, 9 insertions(+), 11 deletions(-)

Comments

Uwe Kleine-König Nov. 14, 2023, 11:39 a.m. UTC | #1 
On Mon, Nov 06, 2023 at 04:13:23PM +0100, Alexander Stein wrote:
> this small series adds support for inverted PWM output i.MX8QM/QXP.
> Driver is already there, but #pwm-cells needs to be adjusted in DT.
> While at it, enforce the same #pwm-cells value for all compatibles.
> [...]
>  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
>  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi     |  2 +-
>  arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi    |  8 ++++----
>  3 files changed, 9 insertions(+), 11 deletions(-)

What is the merge plan here? pwm or imx? For me both options are fine,
given this only touches bindings and arch/arm64, maybe it's more
suitable to be merged by Shawn?

Best regards
Uwe
Shawn Guo Dec. 5, 2023, 12:32 p.m. UTC | #2 
On Mon, Nov 06, 2023 at 04:13:25PM +0100, Alexander Stein wrote:
> i.MX8QM/QXP supports inverted PWM output, thus #pwm-cells needs to be set
> to 3.
> 
> Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied, thanks!
Shawn Guo Dec. 5, 2023, 12:32 p.m. UTC | #3 
On Mon, Nov 06, 2023 at 04:13:26PM +0100, Alexander Stein wrote:
> i.MX8QXP supports inverted PWM output, thus #pwm-cells needs to be set
> to 3.
> 
> Fixes: f1d6a6b991ef9 ("arm64: dts: imx8qxp: add adma_pwm in adma")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied, thanks!