mbox series

[v3,0/7] Add pinctrl driver support for Realtek DHC SoCs

Message ID 20230919101117.4097-1-tychang@realtek.com
Headers show
Series Add pinctrl driver support for Realtek DHC SoCs | expand

Message

TY_Chang[張子逸] Sept. 19, 2023, 10:11 a.m. UTC 
These patches add the bindings and the pinctrl drivers for Realtek
DHC(Digital Home Center) RTD SoCs(RTD1619B, RTD1319D and RTD1315E).

Change log:
v2 -> v3:
1. Use regmap_update_bits instead of rtd_pinctrl_update_bits.
2. Remove if/then condition under the patternProperties "-pins$".
v1 -> v2:
1. Rename realtek,pdriver, realtek,ndriver and realtek,dcycle
2. Remove the wildcard in the compatible strings
3. Add the description for RTD1315E, RTD1319D and RTD1315E
4. Add the description for P-MOS and N-MOS driving strength

Tzuyi Chang (7):
  pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs
  pinctrl: realtek: Add pinctrl driver for RTD1315E
  pinctrl: realtek: Add pinctrl driver for RTD1319D
  pinctrl: realtek: Add pinctrl driver for RTD1619B
  dt-bindings: pinctrl: realtek: add RTD1315E pinctrl binding
  dt-bindings: pinctrl: realtek: add RTD1319D pinctrl binding
  dt-bindings: pinctrl: realtek: add RTD1619B pinctrl binding

 .../pinctrl/realtek,rtd1315e-pinctrl.yaml     |  188 ++
 .../pinctrl/realtek,rtd1319d-pinctrl.yaml     |  187 ++
 .../pinctrl/realtek,rtd1619b-pinctrl.yaml     |  186 ++
 drivers/pinctrl/Kconfig                       |    1 +
 drivers/pinctrl/Makefile                      |    1 +
 drivers/pinctrl/realtek/Kconfig               |   23 +
 drivers/pinctrl/realtek/Makefile              |    6 +
 drivers/pinctrl/realtek/pinctrl-rtd.c         |  580 ++++++
 drivers/pinctrl/realtek/pinctrl-rtd.h         |  124 ++
 drivers/pinctrl/realtek/pinctrl-rtd1315e.c    | 1439 +++++++++++++++
 drivers/pinctrl/realtek/pinctrl-rtd1319d.c    | 1609 +++++++++++++++++
 drivers/pinctrl/realtek/pinctrl-rtd1619b.c    | 1601 ++++++++++++++++
 12 files changed, 5945 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml
 create mode 100644 drivers/pinctrl/realtek/Kconfig
 create mode 100644 drivers/pinctrl/realtek/Makefile
 create mode 100644 drivers/pinctrl/realtek/pinctrl-rtd.c
 create mode 100644 drivers/pinctrl/realtek/pinctrl-rtd.h
 create mode 100644 drivers/pinctrl/realtek/pinctrl-rtd1315e.c
 create mode 100644 drivers/pinctrl/realtek/pinctrl-rtd1319d.c
 create mode 100644 drivers/pinctrl/realtek/pinctrl-rtd1619b.c

Comments

Linus Walleij Sept. 20, 2023, 11:08 a.m. UTC | #1 
Hi Tzuyi,


On Tue, Sep 19, 2023 at 12:12 PM Tzuyi Chang <tychang@realtek.com> wrote:

> These patches add the bindings and the pinctrl drivers for Realtek
> DHC(Digital Home Center) RTD SoCs(RTD1619B, RTD1319D and RTD1315E).

All patches look good, bindings are reviewed by Rob, my comments
addressed: patches applied for kernel v6.6!

Excellent work on this patch series! Thank you.

Yours,
Linus Walleij
Linus Walleij Sept. 20, 2023, 11:09 a.m. UTC | #2 
On Wed, Sep 20, 2023 at 1:08 PM Linus Walleij <linus.walleij@linaro.org> wrote:

> All patches look good, bindings are reviewed by Rob, my comments
> addressed: patches applied for kernel v6.6!

Sorry, kernel v6.7 at this point obviously. I can't keep numbers
in my head properly :/

Yours,
Linus Walleij
TY_Chang[張子逸] Sept. 21, 2023, 2 a.m. UTC | #3 
Hi Linus,

>
>On Wed, Sep 20, 2023 at 1:08 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> All patches look good, bindings are reviewed by Rob, my comments
>> addressed: patches applied for kernel v6.6!
>
>Sorry, kernel v6.7 at this point obviously. I can't keep numbers in my head
>properly :/
>
>Yours,
>Linus Walleij

I appreciate it! Thank you for the review!

Thanks,
Tzuyi Chang