mbox series

[v2,0/2] Add support for CS40L50

Message ID 20230809135313.731706-1-james.ogletree@cirrus.com
Headers show
Series Add support for CS40L50 | expand

Message

James Ogletree Aug. 9, 2023, 1:53 p.m. UTC 
Changes in V2:
- Fix checkpatch warnings

James Ogletree (2):
  dt-bindings: input: cirrus,cs40l50: Support for CS40L50
  Input: cs40l50 - Initial support for Cirrus Logic CS40L50

 .../bindings/input/cirrus,cs40l50.yaml        |   77 ++
 MAINTAINERS                                   |   11 +
 drivers/input/misc/Kconfig                    |   33 +
 drivers/input/misc/Makefile                   |    3 +
 drivers/input/misc/cs40l50-i2c.c              |   67 ++
 drivers/input/misc/cs40l50-spi.c              |   67 ++
 drivers/input/misc/cs40l50.c                  | 1013 +++++++++++++++++
 include/linux/input/cs40l50.h                 |  321 ++++++
 8 files changed, 1592 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
 create mode 100644 drivers/input/misc/cs40l50-i2c.c
 create mode 100644 drivers/input/misc/cs40l50-spi.c
 create mode 100644 drivers/input/misc/cs40l50.c
 create mode 100644 include/linux/input/cs40l50.h

Comments

Krzysztof Kozlowski Aug. 9, 2023, 2:32 p.m. UTC | #1 
On 09/08/2023 15:53, James Ogletree wrote:
> Introduce support for Cirrus Logic Device CS40L50: a
> haptics driver with waveform memory DSP and closed-loop
> algorithms.


> +static const struct of_device_id cs40l50_of_match[] = {
> +	{ .compatible = "cirrus,cs40l50" },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(of, cs40l50_of_match);
> +
> +static int cs40l50_i2c_probe(struct i2c_client *client)
> +{
> +	struct device *dev = &client->dev;
> +	struct cs40l50_private *cs40l50;
> +
> +	cs40l50 = devm_kzalloc(dev, sizeof(struct cs40l50_private), GFP_KERNEL);

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.


Best regards,
Krzysztof