mbox series

[V6,0/3] nvmem: add fixed cells layout

Message ID 20230327141611.25131-1-zajec5@gmail.com
Headers show
Series nvmem: add fixed cells layout | expand

Message

Rafał Miłecki March 27, 2023, 2:16 p.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

NVMEM bindings received a new feature recently: layouts. They allow 
defining NVMEM device content in a separated DT node named 
"nvmem-layout". That improvement results in cleaner and more generic
bindings.

New bindings & drivers should use layouts design. If possible we should
also try converting existing bindings & drivers to layouts.

This patchset allows defining NVMEM cells in a new way (using NVMEM
layout feature).

This deprecates support for defining NVMEM cells as direct DT device
node subnodes but IT DOESN'T drop support for that.

PLEASE understand what this patchset handles. It adds new & preferred
way of defining NVMEM cells. This patchset does NOT meant to:
1. Convert ALL existing bindings or drivers (it's a task for later)
2. Add support for new extra features (like multiple layouts)
3. Break any backward compatibility (it WON'T happen)

V5:
Support "fixed-layout" internally in NVMEM core (see PATCH 3/3)
V6:
Rename function & add unevaluatedProperties

Rafał Miłecki (3):
  dt-bindings: nvmem: layouts: add fixed-layout
  dt-bindings: nvmem: convert base example to use NVMEM fixed cells
    layout
  nvmem: core: add support for fixed cells *layout*

 .../bindings/nvmem/layouts/fixed-cell.yaml    | 31 ++++++++++
 .../bindings/nvmem/layouts/fixed-layout.yaml  | 50 +++++++++++++++
 .../bindings/nvmem/layouts/nvmem-layout.yaml  |  5 +-
 .../devicetree/bindings/nvmem/nvmem.yaml      | 61 ++++++++-----------
 drivers/nvmem/core.c                          | 32 +++++++++-
 5 files changed, 137 insertions(+), 42 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml
 create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-layout.yaml

Comments

Rafał Miłecki June 5, 2023, 5:49 p.m. UTC | #1
Hi Srini,

On 27.03.2023 16:16, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> NVMEM bindings received a new feature recently: layouts. They allow
> defining NVMEM device content in a separated DT node named
> "nvmem-layout". That improvement results in cleaner and more generic
> bindings.
> 
> New bindings & drivers should use layouts design. If possible we should
> also try converting existing bindings & drivers to layouts.
> 
> This patchset allows defining NVMEM cells in a new way (using NVMEM
> layout feature).
> 
> This deprecates support for defining NVMEM cells as direct DT device
> node subnodes but IT DOESN'T drop support for that.
> 
> PLEASE understand what this patchset handles. It adds new & preferred
> way of defining NVMEM cells. This patchset does NOT meant to:
> 1. Convert ALL existing bindings or drivers (it's a task for later)
> 2. Add support for new extra features (like multiple layouts)
> 3. Break any backward compatibility (it WON'T happen)
> 
> V5:
> Support "fixed-layout" internally in NVMEM core (see PATCH 3/3)
> V6:
> Rename function & add unevaluatedProperties

This patchset seemed ready for 6.4 but I guess it has missed your window

I see you already picked some stuff into your for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git/log/?h=for-next
but I don't see those changes.

Can you pick this work too, please? I would like to avoid waiting
another month before getting this upstreamed.


> Rafał Miłecki (3):
>    dt-bindings: nvmem: layouts: add fixed-layout
>    dt-bindings: nvmem: convert base example to use NVMEM fixed cells
>      layout
>    nvmem: core: add support for fixed cells *layout*
> 
>   .../bindings/nvmem/layouts/fixed-cell.yaml    | 31 ++++++++++
>   .../bindings/nvmem/layouts/fixed-layout.yaml  | 50 +++++++++++++++
>   .../bindings/nvmem/layouts/nvmem-layout.yaml  |  5 +-
>   .../devicetree/bindings/nvmem/nvmem.yaml      | 61 ++++++++-----------
>   drivers/nvmem/core.c                          | 32 +++++++++-
>   5 files changed, 137 insertions(+), 42 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml
>   create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-layout.yaml
>
Srinivas Kandagatla June 6, 2023, 9:48 a.m. UTC | #2
On Mon, 27 Mar 2023 16:16:08 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> NVMEM bindings received a new feature recently: layouts. They allow
> defining NVMEM device content in a separated DT node named
> "nvmem-layout". That improvement results in cleaner and more generic
> bindings.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: nvmem: layouts: add fixed-layout
      commit: 4d0c9ce1a7a26947269a15fad622f1ffb6698627
[2/3] dt-bindings: nvmem: convert base example to use NVMEM fixed cells layout
      commit: 75dd9c7a421a239be6e7bd48e6b3a1474500fe98
[3/3] nvmem: core: add support for fixed cells *layout*
      commit: ac1c0d15aedc0863031bc8d678d5f96ab11d3a41

Best regards,