mbox series

[v3,00/17] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples

Message ID 20221213082449.2721-1-hayashi.kunihiko@socionext.com
Headers show
Series dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples | expand

Message

Kunihiko Hayashi Dec. 13, 2022, 8:24 a.m. UTC 
This series introduces dt-bindings documents for miscellaneous register
blocks implemented in Socionext UniPhier SoCs.

These are previously defined in the devicetree and used in the examples
of subnodes' dt-bindings, however, not documented.

These include two types of the blocks

* independent block including miscellaneous registers and functions for
  the whole SoC (system controller and SoC-glue logic)

* sideband logic including control registers in the component (others)

And prior to adding these dt-bindings, fix examples in the existing
dt-bindings.

This series is part of the previous series shown below:
https://lore.kernel.org/linux-arm-kernel/20221107103410.3443-2-hayashi.kunihiko@socionext.com

Changes since v2:
- Drop redundant nodes in examples (clock, reset, soc-glue-debug)
- Drop parent node in examples
- Add more properties to examples for pinctrl
- Add a patch for regulator change
- Use consistent quotes
- Drop unit address patterns of patternProperties
- Mandatory unit address pattern for efuse (soc-glue-debug)
- Fix additionalProperties (ahci-glue)

Changes since v1:
- Fix examples in the existing dt-bindings (Add PATCH 1-7)
- Add dt-bindings for SoC-glue logic debug part (Add PATCH 10)
- Drop generic and ld6b compatible strings
- Change "usb-controller" node in soc-glue to "usb-hub"
- Change "usb-controller" node in USB glue layer example to "usb"
- Add negation of child properties by compatible string

Kunihiko Hayashi (17):
  dt-bindings: clock: Fix node descriptions in uniphier-clock example
  dt-bindings: reset: Fix node descriptions in uniphier-reset example
  dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl
    example
  dt-bindings: regulator: Fix node descriptions in uniphier-regulator
    example
  dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example
  dt-bindings: thermal: Fix node descriptions in uniphier-thermal
    example
  dt-bindings: phy: Fix node descriptions in uniphier-phy example
  dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example
  dt-bindings: soc: socionext: Add UniPhier system controller
  dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
  dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
  dt-bindings: soc: socionext: Add UniPhier peripheral block
  dt-bindings: soc: socionext: Add UniPhier media I/O block
  dt-bindings: soc: socionext: Add UniPhier SD interface block
  dt-bindings: soc: socionext: Add UniPhier ADAMV block
  dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
  dt-bindings: soc: socionext: Add UniPhier AHCI glue layer

 .../clock/socionext,uniphier-clock.yaml       |  39 +-----
 .../nvmem/socionext,uniphier-efuse.yaml       | 101 +++++++--------
 .../phy/socionext,uniphier-ahci-phy.yaml      |  24 ++--
 .../phy/socionext,uniphier-usb2-phy.yaml      |  41 +++----
 .../phy/socionext,uniphier-usb3hs-phy.yaml    |  29 ++---
 .../phy/socionext,uniphier-usb3ss-phy.yaml    |  26 ++--
 .../pinctrl/socionext,uniphier-pinctrl.yaml   |  17 ++-
 .../socionext,uniphier-regulator.yaml         |  21 ++--
 .../reset/socionext,uniphier-glue-reset.yaml  |  23 ++--
 .../reset/socionext,uniphier-reset.yaml       |  52 +-------
 .../socionext/socionext,uniphier-adamv.yaml   |  50 ++++++++
 .../socionext,uniphier-ahci-glue.yaml         |  77 ++++++++++++
 .../socionext,uniphier-dwc3-glue.yaml         | 106 ++++++++++++++++
 .../socionext/socionext,uniphier-mioctrl.yaml |  65 ++++++++++
 .../socionext,uniphier-perictrl.yaml          |  64 ++++++++++
 .../socionext/socionext,uniphier-sdctrl.yaml  |  61 ++++++++++
 .../socionext,uniphier-soc-glue-debug.yaml    |  68 +++++++++++
 .../socionext,uniphier-soc-glue.yaml          | 115 ++++++++++++++++++
 .../socionext/socionext,uniphier-sysctrl.yaml | 104 ++++++++++++++++
 .../thermal/socionext,uniphier-thermal.yaml   |  15 +--
 .../watchdog/socionext,uniphier-wdt.yaml      |  10 +-
 MAINTAINERS                                   |   1 +
 22 files changed, 843 insertions(+), 266 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-adamv.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-mioctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-perictrl.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sdctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue-debug.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml

Comments

Rob Herring (Arm) Dec. 19, 2022, 3:49 p.m. UTC | #1 
On Tue, Dec 13, 2022 at 05:24:32PM +0900, Kunihiko Hayashi wrote:
> This series introduces dt-bindings documents for miscellaneous register
> blocks implemented in Socionext UniPhier SoCs.
> 
> These are previously defined in the devicetree and used in the examples
> of subnodes' dt-bindings, however, not documented.
> 
> These include two types of the blocks
> 
> * independent block including miscellaneous registers and functions for
>   the whole SoC (system controller and SoC-glue logic)
> 
> * sideband logic including control registers in the component (others)
> 
> And prior to adding these dt-bindings, fix examples in the existing
> dt-bindings.
> 
> This series is part of the previous series shown below:
> https://lore.kernel.org/linux-arm-kernel/20221107103410.3443-2-hayashi.kunihiko@socionext.com
> 
> Changes since v2:
> - Drop redundant nodes in examples (clock, reset, soc-glue-debug)
> - Drop parent node in examples
> - Add more properties to examples for pinctrl
> - Add a patch for regulator change
> - Use consistent quotes
> - Drop unit address patterns of patternProperties
> - Mandatory unit address pattern for efuse (soc-glue-debug)
> - Fix additionalProperties (ahci-glue)
> 
> Changes since v1:
> - Fix examples in the existing dt-bindings (Add PATCH 1-7)
> - Add dt-bindings for SoC-glue logic debug part (Add PATCH 10)
> - Drop generic and ld6b compatible strings
> - Change "usb-controller" node in soc-glue to "usb-hub"
> - Change "usb-controller" node in USB glue layer example to "usb"
> - Add negation of child properties by compatible string
> 
> Kunihiko Hayashi (17):
>   dt-bindings: clock: Fix node descriptions in uniphier-clock example
>   dt-bindings: reset: Fix node descriptions in uniphier-reset example
>   dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl
>     example
>   dt-bindings: regulator: Fix node descriptions in uniphier-regulator
>     example
>   dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example
>   dt-bindings: thermal: Fix node descriptions in uniphier-thermal
>     example
>   dt-bindings: phy: Fix node descriptions in uniphier-phy example
>   dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example
>   dt-bindings: soc: socionext: Add UniPhier system controller
>   dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
>   dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
>   dt-bindings: soc: socionext: Add UniPhier peripheral block
>   dt-bindings: soc: socionext: Add UniPhier media I/O block
>   dt-bindings: soc: socionext: Add UniPhier SD interface block
>   dt-bindings: soc: socionext: Add UniPhier ADAMV block
>   dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
>   dt-bindings: soc: socionext: Add UniPhier AHCI glue layer

You sent this To me, so I'm assuming you want me to apply it?
Otherwise, it can go via the Socionext tree. Let me know and I can fix 
up Krzysztof's comments and apply the series.

Rob
Kunihiko Hayashi Dec. 20, 2022, 1:13 a.m. UTC | #2 
Hi Rob,

On 2022/12/20 0:49, Rob Herring wrote:
> On Tue, Dec 13, 2022 at 05:24:32PM +0900, Kunihiko Hayashi wrote:
>> This series introduces dt-bindings documents for miscellaneous register
>> blocks implemented in Socionext UniPhier SoCs.
>>
>> These are previously defined in the devicetree and used in the examples
>> of subnodes' dt-bindings, however, not documented.
>>
>> These include two types of the blocks
>>
>> * independent block including miscellaneous registers and functions for
>>    the whole SoC (system controller and SoC-glue logic)
>>
>> * sideband logic including control registers in the component (others)
>>
>> And prior to adding these dt-bindings, fix examples in the existing
>> dt-bindings.
>>
>> This series is part of the previous series shown below:
>>
> https://lore.kernel.org/linux-arm-kernel/20221107103410.3443-2-hayashi.kun
> ihiko@socionext.com
>>
>> Changes since v2:
>> - Drop redundant nodes in examples (clock, reset, soc-glue-debug)
>> - Drop parent node in examples
>> - Add more properties to examples for pinctrl
>> - Add a patch for regulator change
>> - Use consistent quotes
>> - Drop unit address patterns of patternProperties
>> - Mandatory unit address pattern for efuse (soc-glue-debug)
>> - Fix additionalProperties (ahci-glue)
>>
>> Changes since v1:
>> - Fix examples in the existing dt-bindings (Add PATCH 1-7)
>> - Add dt-bindings for SoC-glue logic debug part (Add PATCH 10)
>> - Drop generic and ld6b compatible strings
>> - Change "usb-controller" node in soc-glue to "usb-hub"
>> - Change "usb-controller" node in USB glue layer example to "usb"
>> - Add negation of child properties by compatible string
>>
>> Kunihiko Hayashi (17):
>>    dt-bindings: clock: Fix node descriptions in uniphier-clock example
>>    dt-bindings: reset: Fix node descriptions in uniphier-reset example
>>    dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl
>>      example
>>    dt-bindings: regulator: Fix node descriptions in uniphier-regulator
>>      example
>>    dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example
>>    dt-bindings: thermal: Fix node descriptions in uniphier-thermal
>>      example
>>    dt-bindings: phy: Fix node descriptions in uniphier-phy example
>>    dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example
>>    dt-bindings: soc: socionext: Add UniPhier system controller
>>    dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
>>    dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part
>>    dt-bindings: soc: socionext: Add UniPhier peripheral block
>>    dt-bindings: soc: socionext: Add UniPhier media I/O block
>>    dt-bindings: soc: socionext: Add UniPhier SD interface block
>>    dt-bindings: soc: socionext: Add UniPhier ADAMV block
>>    dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer
>>    dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
> 
> You sent this To me, so I'm assuming you want me to apply it?
 > Otherwise, it can go via the Socionext tree. Let me know and I can fix
 > up Krzysztof's comments and apply the series.

Currently I don't have the Socionext tree for pull-request,
so I'd be happy if you could fix up the comments and apply the series.

Thank you,

---
Best Regards
Kunihiko Hayashi
Kunihiko Hayashi Jan. 19, 2023, 8:22 a.m. UTC | #3 
Hi Rob,

On 2022/12/20 10:13, Kunihiko Hayashi wrote:

>> You sent this To me, so I'm assuming you want me to apply it?
>> Otherwise, it can go via the Socionext tree. Let me know and I can fix
>> up Krzysztof's comments and apply the series.
> 
> Currently I don't have the Socionext tree for pull-request,
> so I'd be happy if you could fix up the comments and apply the series.
Could you please do the above?
Or should I submit the fixed v4 to soc@kernel.org and request a merge of
this series?

After fixing the dt-bindings in this series, I'll continue to submit patch
series to update the devicetree.

Thank you,

---
Best Regards
Kunihiko Hayashi
Rob Herring (Arm) Jan. 19, 2023, 7:57 p.m. UTC | #4 
On Thu, Jan 19, 2023 at 2:22 AM Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
>
> Hi Rob,
>
> On 2022/12/20 10:13, Kunihiko Hayashi wrote:
>
> >> You sent this To me, so I'm assuming you want me to apply it?
> >> Otherwise, it can go via the Socionext tree. Let me know and I can fix
> >> up Krzysztof's comments and apply the series.
> >
> > Currently I don't have the Socionext tree for pull-request,
> > so I'd be happy if you could fix up the comments and apply the series.
> Could you please do the above?

Yes, I've already applied this.

Rob
Kunihiko Hayashi Jan. 20, 2023, 12:03 a.m. UTC | #5 
On 2023/01/20 4:57, Rob Herring wrote:
> On Thu, Jan 19, 2023 at 2:22 AM Kunihiko Hayashi
> <hayashi.kunihiko@socionext.com> wrote:
>>
>> Hi Rob,
>>
>> On 2022/12/20 10:13, Kunihiko Hayashi wrote:
>>
>>>> You sent this To me, so I'm assuming you want me to apply it?
>>>> Otherwise, it can go via the Socionext tree. Let me know and I can fix
>>>> up Krzysztof's comments and apply the series.
>>>
>>> Currently I don't have the Socionext tree for pull-request,
>>> so I'd be happy if you could fix up the comments and apply the series.
>> Could you please do the above?
> 
> Yes, I've already applied this.
Thanks a lot for your help!

---
Best Regards
Kunihiko Hayashi