| Message ID | 20220929131309.18337-1-allen-kh.cheng@mediatek.com |
|---|---|
| Headers | show |
| Series | Add vcodec lat and core nodes for mt8192 | expand |
Il 29/09/22 15:13, Allen-KH Cheng ha scritto: > Add vcodec lat and core nodes for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 60 ++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index 6b20376191a7..fd3c3aaeadba 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -1449,6 +1449,66 @@ > power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>; > }; > > + vcodec_dec: video-codec@16000000 { > + compatible = "mediatek,mt8192-vcodec-dec"; > + reg = <0 0x16000000 0 0x1000>; > + mediatek,scp = <&scp>; > + iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > + dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0 0 0 0x16000000 0 0x26000>; > + > + vcodec_lat: video-codec-lat@10000 { There's only one more thing: why do we need the `vcodec_lat:` and `vcodec_core:` phandles here? Platforms that do not support the vcodec can simply set `status = disabled;` on `vcodec_dec`... as it doesn't make real sense to disable only LAT or only CORE. Please drop these two, after which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Hi Angelo, On Fri, 2022-09-30 at 10:37 +0200, AngeloGioacchino Del Regno wrote: > Il 29/09/22 15:13, Allen-KH Cheng ha scritto: > > Add vcodec lat and core nodes for mt8192 SoC. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 60 > > ++++++++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > index 6b20376191a7..fd3c3aaeadba 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -1449,6 +1449,66 @@ > > power-domains = <&spm > > MT8192_POWER_DOMAIN_ISP2>; > > }; > > > > + vcodec_dec: video-codec@16000000 { > > + compatible = "mediatek,mt8192-vcodec-dec"; > > + reg = <0 0x16000000 0 0x1000>; > > + mediatek,scp = <&scp>; > > + iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > > + dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 > > 0xfff00000>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges = <0 0 0 0x16000000 0 0x26000>; > > + > > + vcodec_lat: video-codec-lat@10000 { > > There's only one more thing: why do we need the `vcodec_lat:` and > `vcodec_core:` > phandles here? > > Platforms that do not support the vcodec can simply set `status = > disabled;` on > `vcodec_dec`... as it doesn't make real sense to disable only LAT or > only CORE. > > Please drop these two, after which: > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> It makes sense. I'll update in the following version. Thanks, Allen > >
This series are based on linux-next, tag: next-20220928. We update the child node names from "vcodec" to "video-codec" based on the discussion in [1]. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220926105047.19419-1-allen-kh.cheng@mediatek.com/ Change in v2: - Add a dt-bindings patch for changing "vcodec" to "video-codec" - Rename child names for vcodec lat and core nodes Change in v1: - Replace node names with video-codec [Allen-KH Cheng <allen-kh.cheng@mediatek.com>] Allen-KH Cheng (2): media: dt-bindings: mediatek: Rename child node names for decoder arm64: dts: mt8192: Add vcodec lat and core nodes .../media/mediatek,vcodec-subdev-decoder.yaml | 8 +-- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 60 +++++++++++++++++++ 2 files changed, 64 insertions(+), 4 deletions(-)