| Message ID | 20220113111057.29918-1-yong.wu@mediatek.com |
|---|---|
| Headers | show |
| Series | MT8186 SMI SUPPORT | expand |
On 13/01/2022 12:10, Yong Wu wrote: > Function clk_bulk_prepare_enable() returns 0 for success or a negative > number for error. Fix this code style issue. The message does not really make sense. If negative is returned, then the check (ret < 0) was correct. I guess you wanted to say that common code style is to check for any non-zero return value, just like it's implementation in clk.h does. I'll adjust the commit msg when applying. > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/memory/mtk-smi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index b883dcc0bbfa..e7b1a22b12ea 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev) > int ret; > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks); > - if (ret < 0) > + if (ret) > return ret; > > /* Configure the basic setting for this larb */ > Best regards, Krzysztof
On Mon, 2022-01-17 at 13:01 +0100, Krzysztof Kozlowski wrote: > On 13/01/2022 12:10, Yong Wu wrote: > > Function clk_bulk_prepare_enable() returns 0 for success or a > > negative > > number for error. Fix this code style issue. > > The message does not really make sense. If negative is returned, then > the check (ret < 0) was correct. > > I guess you wanted to say that common code style is to check for any > non-zero return value, just like it's implementation in clk.h does. > > I'll adjust the commit msg when applying. Thanks for the help. > > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/memory/mtk-smi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > index b883dcc0bbfa..e7b1a22b12ea 100644 > > --- a/drivers/memory/mtk-smi.c > > +++ b/drivers/memory/mtk-smi.c > > @@ -480,7 +480,7 @@ static int __maybe_unused > > mtk_smi_larb_resume(struct device *dev) > > int ret; > > > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb- > > >smi.clks); > > - if (ret < 0) > > + if (ret) > > return ret; > > > > /* Configure the basic setting for this larb */ > > Best regards, > Krzysztof
On Thu, 13 Jan 2022 19:10:50 +0800, Yong Wu wrote: > This patchset adds mt8186 smi support. > mainly adds a sleep control function. > > Change note: > v3: a) Add a new binding patch for renaming "clock" to "clocks". > b) Reword the title for the binding patches, more detailed. > c) Add the sleep control error path: if err, return directly. > also change the log from dev_warn to dev_err. > > [...] Applied, thanks! [1/7] dt-bindings: memory: mtk-smi: Rename clock to clocks commit: 5bf7fa48374eafe29dbb30448a0b0c083853583f [2/7] dt-bindings: memory: mtk-smi: No need mediatek,larb-id for mt8167 commit: ddc3a324889686ec9b358de20fdeec0d2668c7a8 [3/7] dt-bindings: memory: mtk-smi: Correct minItems to 2 for the gals clocks commit: 996ebc0e332bfb3091395f9bd286d8349a57be62 [4/7] dt-bindings: memory: mediatek: Add mt8186 support commit: 6d86f23c35fe7b479ceef4d3f1eef925996945fd [5/7] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable commit: a6945f4566d4f77a4054720f6649ff921fe1ae64 [6/7] memory: mtk-smi: Add sleep ctrl function commit: 8956500e5d5bf541a945299999b0bf4866dc0daf [7/7] memory: mtk-smi: mt8186: Add smi support commit: 86a010bfc73983aa8cd914f1e5f73962b0406678 Best regards,
This patchset adds mt8186 smi support. mainly adds a sleep control function. Change note: v3: a) Add a new binding patch for renaming "clock" to "clocks". b) Reword the title for the binding patches, more detailed. c) Add the sleep control error path: if err, return directly. also change the log from dev_warn to dev_err. v2: https://lore.kernel.org/linux-devicetree/20220111063904.7583-1-yong.wu@mediatek.com/ a) Add two patches for the "make dtbs_check" warning. b) Seperate the "sleep control" into two functions. And add a "TODO" comment while sleep control fails. v1: https://lore.kernel.org/linux-mediatek/20211203064027.14993-1-yong.wu@mediatek.com/ Base on v5.16-rc1. Yong Wu (7): dt-bindings: memory: mtk-smi: Rename clock to clocks dt-bindings: memory: mtk-smi: No need mediatek,larb-id for mt8167 dt-bindings: memory: mtk-smi: Correct minItems to 2 for the gals clocks dt-bindings: memory: mediatek: Add mt8186 support memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable memory: mtk-smi: Add sleep ctrl function memory: mtk-smi: mt8186: Add smi support .../mediatek,smi-common.yaml | 32 ++++++------ .../memory-controllers/mediatek,smi-larb.yaml | 19 +++---- drivers/memory/mtk-smi.c | 51 ++++++++++++++++++- 3 files changed, 75 insertions(+), 27 deletions(-)