| Message ID | 20210416133133.2067467-1-balbi@kernel.org |
|---|---|
| Headers | show |
| Series | arm64: sm8150: Add minimal DMA support | expand |
Hi, Felipe Balbi <balbi@kernel.org> writes: > @@ -612,6 +636,8 @@ spi0: spi@880000 { > pinctrl-0 = <&qup_spi0_default>; > interrupts = <GIC_SPI 601 IRQ_TYPE_LEVEL_HIGH>; > spi-max-frequency = <50000000>; > + dmas = <&gpi_dma0 0 0 QCOM_GPI_SPI>, > + <&gpi_dma0 1 0 QCOM_GPI_SPI>; one little note. This was for a quick test. I can either remove, keep it or complete with the rest of the SPIs in this same patch. Let me know what y'all prefer :-)
>one little note. This was for a quick test. I can either remove, keep it >or complete with the rest of the SPIs in this same patch. Let me know >what y'all prefer :-) Yeah, please remove it from this one and send in a separate patch, preferably adding dmas to all the QUPs :) Aaand since I already asked you to re-send, you might as well fix up the properties order under the nodes (compatible first, then reg, with #dma-cells somewhere at the bottom) and the unit name (should be "dma-controller@..."). Konrad
Hi, (looks like your email client is still refusing to break lines at 80 columns) Konrad Dybcio <konrad.dybcio@somainline.org> writes: >>one little note. This was for a quick test. I can either remove, keep it >>or complete with the rest of the SPIs in this same patch. Let me know > >>what y'all prefer :-) > > > Yeah, please remove it from this one and send in a separate patch, preferably > adding dmas to all the QUPs :) done > Aaand since I already asked you to re-send, you might as well fix up the > properties order under the nodes (compatible first, then reg, with #dma-cells > somewhere at the bottom) and the unit name (should be "dma-controller@..."). done and done :-)
From: Felipe Balbi <felipe.balbi@microsoft.com> Hi, With these two patches, GPI DMA probes fine on sm8150 (well, after setting gpi_dma[012] status to okay). Future commits should come to add relevant DMA channel mapping for the various IPs. DTS patch a dependency on I2C patches by Caleb Connolly and SPI patch by yours truly. Felipe Balbi (2): DMA: qcom: gpi: add compatible for sm8150 arm64: boot: dts: qcom: sm8150: Add DMA nodes .../devicetree/bindings/dma/qcom,gpi.yaml | 1 + arch/arm64/boot/dts/qcom/sm8150.dtsi | 72 +++++++++++++++++++ drivers/dma/qcom/gpi.c | 1 + 3 files changed, 74 insertions(+)