Message ID | 20200914214341.14268-1-michael@walle.cc |
---|---|
Headers | show |
Series | Add support for Kontron sl28cpld | expand |
Hi Lee, Hi Shawn, Am 2020-09-14 23:43, schrieb Michael Walle: > The Kontron sl28cpld is a board management chip providing gpio, pwm, > fan > monitoring and an interrupt controller. For now this controller is used > on > the Kontron SMARC-sAL28 board. But because of its flexible nature, it > might also be used on other boards in the future. The individual blocks > (like gpio, pwm, etc) are kept intentionally small. The MFD core driver > then instantiates different (or multiple of the same) blocks. It also > provides the register layout so it might be updated in the future > without a > device tree change; and support other boards with a different layout or > functionalities. [..] Lee, because my last v9 wasn't merged for now, I though I can do a new v10 with the requested fixes. Shawn, do you have any remarks on the "arm64:" patches? Will you merge them through your tree. If there are any remarks, I'd wait and repost them in an own series once the actual drivers are merged. I guess there is no need to have all the maintainters on CC for these patches anymore.
On Mon, 14 Sep 2020, Michael Walle wrote: > Add support for the PWM controller of the sl28cpld board management > controller. This is part of a multi-function device driver. > > The controller has one PWM channel and can just generate four distinct > frequencies. > > Signed-off-by: Michael Walle <michael@walle.cc> > Acked-by: Thierry Reding <thierry.reding@gmail.com> > --- > Changes since v9: > - fixed double whitespace in Kconfig > - improved comment about division Uwe, are you happy with this now?
On Mon, Sep 14, 2020 at 11:43:34PM +0200, Michael Walle wrote: > Add support for the PWM controller of the sl28cpld board management > controller. This is part of a multi-function device driver. > > The controller has one PWM channel and can just generate four distinct > frequencies. > > Signed-off-by: Michael Walle <michael@walle.cc> > Acked-by: Thierry Reding <thierry.reding@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> @Lee: From my side taking the patch via your mfd tree is fine. Thanks for your effort to align your patch to my reviews Uwe
On Mon, Sep 14, 2020 at 11:43:39PM +0200, Michael Walle wrote: > Now that we have support for GPIO lines of the SMARC connector, enable > LED support on the KBox A-230-LS. There are two LEDs without fixed > functions, one is yellow and one is green. Unfortunately, it is just one > multi-color LED, thus while it is possible to enable both at the same > time it is hard to tell the difference between "yellow only" and "yellow > and green". > > Signed-off-by: Michael Walle <michael@walle.cc> > Acked-by: Pavel Machek <pavel@ucw.cz> > --- > Changes since v9: > - none > > Changes since v8: > - none > > Changes since v7: > - use new "function" and "color" properties instead of a label > - added default-on trigger for the power-led > > Changes since v6: > - none > > Changes since v5: > - changed the label, suggested by Pavel Machek > > Changes since v4: > - none > > Changes since v3: > - see cover letter > > .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > index 4b4cc6a1573d..dd516c0efd8b 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > @@ -11,11 +11,29 @@ > > /dts-v1/; > #include "fsl-ls1028a-kontron-sl28-var4.dts" > +#include <dt-bindings/leds/common.h> > > / { > model = "Kontron KBox A-230-LS"; > compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var4", > "kontron,sl28", "fsl,ls1028a"; > + > + leds { > + compatible = "gpio-leds"; > + > + alarm-led { > + function = LED_FUNCTION_ALARM; > + color = <LED_COLOR_ID_YELLOW>; > + gpios = <&sl28cpld_gpio0 0 0>; > + }; > + > + power-led { > + linux,default-trigger = "default-on"; > + function = LED_FUNCTION_POWER; > + color = <LED_COLOR_ID_GREEN>; > + gpios = <&sl28cpld_gpio1 3 0>; Use GPIO_ACTIVE_HIGH for polarity to improve the readability. I fixed them up and applied patch #9 ~ #13. Shawn > + }; > + }; > }; > > &enetc_mdio_pf3 { > -- > 2.20.1 >