mbox series

[v6,0/5] Add USB PHY support for new Ingenic SoCs.

Message ID 20200725035159.31231-1-zhouyanjie@wanyeetech.com
Headers show
Series Add USB PHY support for new Ingenic SoCs. | expand

Message

Zhou Yanjie July 25, 2020, 3:51 a.m. UTC
v5->v6:
1.Fix the warning that appears during compilation.
2.Used the generic PHY framework API to create the PHY,
  and move the driver to driver/phy/ingenic.

周琰杰 (Zhou Yanjie) (5):
  dt-bindings: USB: Add bindings for new Ingenic SoCs.
  USB: PHY: JZ4770: Unify code style and simplify code.
  USB: PHY: JZ4770: Add support for new Ingenic SoCs.
  USB: PHY: JZ4770: Reformat the code to align it.
  USB: PHY: JZ4770: Usethe generic PHY framework.

 .../bindings/usb/ingenic,jz4770-phy.yaml           |   6 +-
 drivers/phy/Kconfig                                |   1 +
 drivers/phy/Makefile                               |   1 +
 drivers/phy/ingenic/Kconfig                        |  12 +
 drivers/phy/ingenic/Makefile                       |   2 +
 drivers/phy/ingenic/phy-ingenic-usb.c              | 403 +++++++++++++++++++++
 drivers/usb/phy/Kconfig                            |   8 -
 drivers/usb/phy/Makefile                           |   1 -
 drivers/usb/phy/phy-jz4770.c                       | 243 -------------
 9 files changed, 424 insertions(+), 253 deletions(-)
 create mode 100644 drivers/phy/ingenic/Kconfig
 create mode 100644 drivers/phy/ingenic/Makefile
 create mode 100644 drivers/phy/ingenic/phy-ingenic-usb.c
 delete mode 100644 drivers/usb/phy/phy-jz4770.c

Comments

Felipe Balbi July 25, 2020, 6:16 a.m. UTC | #1
Hi,

周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> writes:
> Add support for probing the phy-jz4770 driver on the JZ4780 SoC,
> the X1000 SoC and the X1830 SoC from Ingenic.
>
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> Co-developed-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
> Signed-off-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

It would be better to move this driver to drivers/phy before adding
support for new SoCs. We want to remove drivers/usb/phy/ in the near
future, any help is welcome.
Zhou Yanjie July 25, 2020, 7:34 a.m. UTC | #2
Hi Felipe,

在 2020/7/25 下午2:16, Felipe Balbi 写道:
> Hi,
>
> 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> writes:
>> Add support for probing the phy-jz4770 driver on the JZ4780 SoC,
>> the X1000 SoC and the X1830 SoC from Ingenic.
>>
>> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
>> Co-developed-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
>> Signed-off-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> It would be better to move this driver to drivers/phy before adding
> support for new SoCs. We want to remove drivers/usb/phy/ in the near
> future, any help is welcome.
>
Seems my mailbox have something wrong, the [5/5] patch in this series is 
used to move this river to drivers/phy, but seems that it has not been 
sent out correctly, I already resend it.

Thanks and best regards!
Vinod Koul July 27, 2020, 9:51 a.m. UTC | #3
On 25-07-20, 09:16, Felipe Balbi wrote:
> 
> Hi,
> 
> 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> writes:
> > Add support for probing the phy-jz4770 driver on the JZ4780 SoC,
> > the X1000 SoC and the X1830 SoC from Ingenic.
> >
> > Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> > Co-developed-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
> > Signed-off-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
> > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> 
> It would be better to move this driver to drivers/phy before adding
> support for new SoCs. We want to remove drivers/usb/phy/ in the near
> future, any help is welcome.

Yeah I was about to ask why should this patch up drivers/usb/phy/ rather
than move to drivers/phy, thanks for confirming that :)

Looking forward to move
Vinod Koul July 27, 2020, 9:53 a.m. UTC | #4
On 25-07-20, 15:34, Zhou Yanjie wrote:
> Hi Felipe,
> 
> 在 2020/7/25 下午2:16, Felipe Balbi 写道:
> > Hi,
> > 
> > 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> writes:
> > > Add support for probing the phy-jz4770 driver on the JZ4780 SoC,
> > > the X1000 SoC and the X1830 SoC from Ingenic.
> > > 
> > > Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> > > Co-developed-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
> > > Signed-off-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
> > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > It would be better to move this driver to drivers/phy before adding
> > support for new SoCs. We want to remove drivers/usb/phy/ in the near
> > future, any help is welcome.
> > 
> Seems my mailbox have something wrong, the [5/5] patch in this series is
> used to move this river to drivers/phy, but seems that it has not been sent
> out correctly, I already resend it.

I have resend patches in my inbox but that seems missing patches too :(
Zhou Yanjie July 28, 2020, 3:11 p.m. UTC | #5
Hi Vinod,

在 2020/7/27 下午5:53, Vinod Koul 写道:
> On 25-07-20, 15:34, Zhou Yanjie wrote:
>> Hi Felipe,
>>
>> 在 2020/7/25 下午2:16, Felipe Balbi 写道:
>>> Hi,
>>>
>>> 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> writes:
>>>> Add support for probing the phy-jz4770 driver on the JZ4780 SoC,
>>>> the X1000 SoC and the X1830 SoC from Ingenic.
>>>>
>>>> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
>>>> Co-developed-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
>>>> Signed-off-by: 漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>
>>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>>> It would be better to move this driver to drivers/phy before adding
>>> support for new SoCs. We want to remove drivers/usb/phy/ in the near
>>> future, any help is welcome.
>>>
>> Seems my mailbox have something wrong, the [5/5] patch in this series is
>> used to move this river to drivers/phy, but seems that it has not been sent
>> out correctly, I already resend it.
> I have resend patches in my inbox but that seems missing patches too :(
>
I'm very sorry, but the problem with my mailbox has not been completely 
resolved. In the past week, it still has frequent mail delays and mail 
loss :(