mbox series

[v3,0/2] Exynos5 DMC minor fixes

Message ID 20190919092641.4407-1-l.luba@partner.samsung.com
Headers show
Series Exynos5 DMC minor fixes | expand

Message

Lukasz Luba Sept. 19, 2019, 9:26 a.m. UTC
Hi all,

This is a follow up patch set for the Exynos5 Dynamic Memory Controller
driver v13 [1]. The patches are for Krzysztof's branch [2]
for-v5.4-5.5/memory-samsung-dmc
and/or linux-next where Dan Carpenter reported the issue (patch 1/2).
There are a few fixes captured during static analysis and a new
binding for 'samsung,K3QF2F20DB' LPDDR3 memory.

Regards,
Lukasz Luba

[1] https://lkml.org/lkml/2019/8/21/283
[2] https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.4-5.5/memory-samsung-dmc

Lukasz Luba (2):
  memory: samsung: exynos5422-dmc: Fix kfree() of devm-allocated memory
    and missing static
  dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories

 Documentation/devicetree/bindings/ddr/lpddr3.txt | 10 +++++++---
 drivers/memory/samsung/exynos5422-dmc.c          |  6 ++----
 2 files changed, 9 insertions(+), 7 deletions(-)

Comments

Dan Carpenter Sept. 19, 2019, 9:32 a.m. UTC | #1
Thanks!  Looks good.

regards,
dan carpenter
Krzysztof Kozlowski Sept. 19, 2019, 6:19 p.m. UTC | #2
On Thu, Sep 19, 2019 at 11:26:40AM +0200, Lukasz Luba wrote:
> Fix issues captured by static checkers: used kfree() and missing 'static'
> in the private function.
> 
> Fixes Smatch warning:
>     drivers/memory/samsung/exynos5422-dmc.c:272
>         exynos5_init_freq_table() warn: passing devm_ allocated variable to kfree. 'dmc->opp'
> 
> Fixes Sparse warning:
>     drivers/memory/samsung/exynos5422-dmc.c:736:1:
>         warning: symbol 'exynos5_dmc_align_init_freq' was not declared.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
>  drivers/memory/samsung/exynos5422-dmc.c | 6 ++----

Thanks, applied.

Best regards,
Krzysztof