| Message ID | 20190819163748.18318-1-tdas@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add Global Clock controller (GCC) driver for SC7180 | expand |
Hi Stephen, Thanks for your review. On 8/21/2019 11:31 PM, Stephen Boyd wrote: > Quoting Taniya Das (2019-08-19 09:37:48) >> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig >> index e1ff83cc361e..ebd4902afd9f 100644 >> --- a/drivers/clk/qcom/Kconfig >> +++ b/drivers/clk/qcom/Kconfig >> @@ -322,5 +331,4 @@ config KRAITCC >> help >> Support for the Krait CPU clocks on Qualcomm devices. >> Say Y if you want to support CPU frequency scaling. >> - >> endif > > Please remove this hunk > Would remove this. >> diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c >> new file mode 100644 >> index 000000000000..8718b675d609 >> --- /dev/null >> +++ b/drivers/clk/qcom/gcc-sc7180.c > [...] >> + }, >> +}; >> + >> +/* Camera Subsystem requires always ON. */ > > Yes, but why? This comment is useful unless it explains why. > Next patch would take care. >> +static struct clk_branch gcc_camera_ahb_clk = { >> + .halt_reg = 0xb008, >> + .halt_check = BRANCH_HALT, >> + .hwcg_reg = 0xb008, >> + .hwcg_bit = 1, >> + .clkr = { >> + .enable_reg = 0xb008, >> + .enable_mask = BIT(0), >> + .hw.init = &(struct clk_init_data){ >> + .name = "gcc_camera_ahb_clk", >> + .flags = CLK_IS_CRITICAL, >> + .ops = &clk_branch2_ops, >> + }, >> + }, >> +}; >> + >> +static struct clk_branch gcc_camera_hf_axi_clk = { >> + .halt_reg = 0xb020, >> + .halt_check = BRANCH_HALT, >> + .clkr = { >> + .enable_reg = 0xb020, >> + .enable_mask = BIT(0),
[v2] * Update the DFS macro for RCG to reflect the hw init similar to clock name. * Update the Documentation binding of GCC to YAML schemas. * Add comments for CRITICAL clocks, remove PLL forward declarations and unwanted comments/prints. [v1] * Add driver support for Global Clock controller for SC7180 and also update device tree bindings for the various clocks supported in the clock controller. Taniya Das (3): clk: qcom: rcg: update the DFS macro for RCG dt-bindings: clk: qcom: Add YAML schemas for the GCC clock bindings clk: qcom: Add Global Clock controller (GCC) driver for SC7180 .../devicetree/bindings/clock/qcom,gcc.yaml | 141 + drivers/clk/qcom/Kconfig | 10 +- drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/clk-rcg.h | 2 +- drivers/clk/qcom/gcc-sc7180.c | 2497 +++++++++++++++++ drivers/clk/qcom/gcc-sdm845.c | 96 +- include/dt-bindings/clock/qcom,gcc-sc7180.h | 155 + 7 files changed, 2852 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc.yaml create mode 100644 drivers/clk/qcom/gcc-sc7180.c create mode 100644 include/dt-bindings/clock/qcom,gcc-sc7180.h -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.