mbox series

[0/6] H6 Cedrus support

Message ID 20190128205504.11225-1-jernej.skrabec@siol.net
Headers show
Series H6 Cedrus support | expand

Message

Jernej Škrabec Jan. 28, 2019, 8:54 p.m. UTC
This patch series adds basic support for H6 VPU. VPU itself has some new
features like 10-bit HEVC decoding, support for AFBC output format when
decoding HEVC and IOMMU. However, none of that is currently implemented.

Please take a look.

Best regards,
Jernej

Jernej Skrabec (6):
  dt-bindings: media: cedrus: Add H6 compatible
  media: cedrus: Add a quirk for not setting DMA offset
  media: cedrus: Add support for H6
  dt-bindings: sram: sunxi: Add compatible for the H6 SRAM C1
  arm64: dts: allwinner: h6: Add support for the SRAM C1 section
  arm64: dts: allwinner: h6: Add Video Engine node

 .../devicetree/bindings/media/cedrus.txt      |  1 +
 .../devicetree/bindings/sram/sunxi-sram.txt   |  1 +
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi  | 25 +++++++++++++++++++
 drivers/staging/media/sunxi/cedrus/cedrus.c   |  9 +++++++
 drivers/staging/media/sunxi/cedrus/cedrus.h   |  3 +++
 .../staging/media/sunxi/cedrus/cedrus_hw.c    |  3 ++-
 6 files changed, 41 insertions(+), 1 deletion(-)

Comments

Maxime Ripard Jan. 29, 2019, 9:07 a.m. UTC | #1
On Mon, Jan 28, 2019 at 09:55:00PM +0100, Jernej Skrabec wrote:
> H6 VPU doesn't work if DMA offset is set.
> 
> Add a quirk for it.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Maxime
Maxime Ripard Jan. 29, 2019, 9:08 a.m. UTC | #2
On Mon, Jan 28, 2019 at 09:55:01PM +0100, Jernej Skrabec wrote:
> H6 has improved VPU. It supports 10-bit HEVC decoding and AFBC output
> format for HEVC.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Maxime
Maxime Ripard Jan. 29, 2019, 9:08 a.m. UTC | #3
On Mon, Jan 28, 2019 at 09:55:03PM +0100, Jernej Skrabec wrote:
> Add a node for H6 SRAM C1 section.
> 
> Manual calls it VE SRAM, but for consistency with older SoCs, SRAM C1
> name is used.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Applied, thanks!
Maxime
Paul Kocialkowski March 19, 2019, 8:50 a.m. UTC | #4
Hi,

Le lundi 28 janvier 2019 à 21:55 +0100, Jernej Skrabec a écrit :
> This adds the Video engine node for H6. It can use whole DRAM range so
> there is no need for reserved memory node.

Looks like the patch adding SRAM support made it through but this one
didn't. It looks ready to be picked up though.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> index 247dc0a5ce89..de4b7a1f1012 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -146,6 +146,17 @@
>  			};
>  		};
>  
> +		video-codec@1c0e000 {
> +			compatible = "allwinner,sun50i-h6-video-engine";
> +			reg = <0x01c0e000 0x2000>;
> +			clocks = <&ccu CLK_BUS_VE>, <&ccu CLK_VE>,
> +				 <&ccu CLK_MBUS_VE>;
> +			clock-names = "ahb", "mod", "ram";
> +			resets = <&ccu RST_BUS_VE>;
> +			interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> +			allwinner,sram = <&ve_sram 1>;
> +		};
> +
>  		syscon: syscon@3000000 {
>  			compatible = "allwinner,sun50i-h6-system-control",
>  				     "allwinner,sun50i-a64-system-control";
> -- 
> 2.20.1
>
Maxime Ripard March 19, 2019, 9:49 a.m. UTC | #5
On Tue, Mar 19, 2019 at 09:50:24AM +0100, Paul Kocialkowski wrote:
> Le lundi 28 janvier 2019 à 21:55 +0100, Jernej Skrabec a écrit :
> > This adds the Video engine node for H6. It can use whole DRAM range so
> > there is no need for reserved memory node.
>
> Looks like the patch adding SRAM support made it through but this one
> didn't. It looks ready to be picked up though.
>
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Merged, thanks

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com