mbox series

[v2,0/5] leds: add devicetree functionality to lltc, lt3593 driver

Message ID 20180618194301.5667-1-daniel@zonque.org
Headers show
Series leds: add devicetree functionality to lltc, lt3593 driver | expand

Message

Daniel Mack June 18, 2018, 7:42 p.m. UTC 
This is v2 of the series that brings devicetree support for the
lltc,lt3593 LED driver.

Before this series, the driver supported controlling multiple LEDs
through an array in the platform data. IOW, a single instance of the
driver was able to control multiple hardware chips.

This series changes that, and requires a distinct platform device to
be set up for each of them, if a board has multiple of these hardware
chips. The reason is that in DT, nodes should represent hardware, and
it's much cleaner this way.

As stated earlier in the thread for v1, the driver currently only has
one user in mainline (the Raumfeld platform) which is soon to be
replaced by a devicetree file. This user only uses one LED via pdata, so
the change mentioned above does not cause a regression.

Once the platform is fully ported to DT, I'll send another patch that
removes pdata handling from this driver completely, but it's kept around
as legacy bridge for now.


Changelog:

v1 → v2:

* Moved LED-specific properties into a sub-node in DT, as requested by
  Jacek Anaszewski.


Daniel Mack (5):
  dt-bindings: leds: Add bindings for lltc,lt3593
  leds: lt3593: merge functions and clean up code
  leds: lt3593: switch to gpiod interface
  leds: lt3593: Add device tree probing glue
  leds: lt3593: update email address

 .../devicetree/bindings/leds/leds-lt3593.txt  |  35 ++++
 drivers/leds/leds-lt3593.c                    | 175 +++++++++++-------
 2 files changed, 142 insertions(+), 68 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lt3593.txt

Comments

Daniel Mack June 20, 2018, 8:12 p.m. UTC | #1 
Hi Jacek,

On Wednesday, June 20, 2018 09:41 PM, Jacek Anaszewski wrote:
> This patch doesn't apply cleanly.
> Could you please double check if it applies to LED tree
> on your side? Below is the conflict as reported by > git am --3way.

Oops, sorry. My series was based on 4.17. I'll rebase to 4.18-rc1 and 
resend.


Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html