| Message ID | 1695359525-4548-1-git-send-email-quic_rohiagar@quicinc.com |
|---|---|
| Headers | show |
| Series | Add USB Support on Qualcomm's SDX75 Platform | expand |
On Fri, 22 Sept 2023 at 08:12, Rohit Agarwal <quic_rohiagar@quicinc.com> wrote: > > Add support for USB3 QMP PHY found in SDX75 platform. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > --- > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 173 ++++++++++++++++++++++++++++++++ > 1 file changed, 173 insertions(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >
On 22-09-23, 10:42, Rohit Agarwal wrote: > Hi, > > Changes in v4: > - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5. > > Changes in v3: > - Removed the unnecessary change introduced in v2 of patch 2/5 > - Added Fixes tag in patch 3/5 > - Rebased patch 5/5 on Dmitry's cleanup patches. > https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ > https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ > > Changes in v2: > - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy > and reusing the bindings. > - Rephrased the commit message of patch 3/5 > - Removed stray lines from the patch 5/5 > > This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform. The phy patches fail to apply, can you please rebase the three patches and resend
On 10/13/2023 3:59 PM, Vinod Koul wrote: > On 22-09-23, 10:42, Rohit Agarwal wrote: >> Hi, >> >> Changes in v4: >> - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5. >> >> Changes in v3: >> - Removed the unnecessary change introduced in v2 of patch 2/5 >> - Added Fixes tag in patch 3/5 >> - Rebased patch 5/5 on Dmitry's cleanup patches. >> https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ >> https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ >> >> Changes in v2: >> - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy >> and reusing the bindings. >> - Rephrased the commit message of patch 3/5 >> - Removed stray lines from the patch 5/5 >> >> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform. > The phy patches fail to apply, can you please rebase the three patches > and resend Can you please apply these two series. This series depends on it for successful compilation. [1] https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ [2] https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ Thanks, Rohit.
On 13-10-23, 16:08, Rohit Agarwal wrote: > > On 10/13/2023 3:59 PM, Vinod Koul wrote: > > On 22-09-23, 10:42, Rohit Agarwal wrote: > > > Hi, > > > > > > Changes in v4: > > > - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5. > > > > > > Changes in v3: > > > - Removed the unnecessary change introduced in v2 of patch 2/5 > > > - Added Fixes tag in patch 3/5 > > > - Rebased patch 5/5 on Dmitry's cleanup patches. > > > https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ > > > https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ > > > > > > Changes in v2: > > > - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy > > > and reusing the bindings. > > > - Rephrased the commit message of patch 3/5 > > > - Removed stray lines from the patch 5/5 > > > > > > This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform. > > The phy patches fail to apply, can you please rebase the three patches > > and resend > Can you please apply these two series. This series depends on it for > successful compilation. > [1] https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ This one has a pending comment bw Konrad and Dmitry.. > [2] https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ This one is already in -next > > Thanks, > Rohit.
On 10/13/2023 4:15 PM, Vinod Koul wrote: > On 13-10-23, 16:08, Rohit Agarwal wrote: >> On 10/13/2023 3:59 PM, Vinod Koul wrote: >>> On 22-09-23, 10:42, Rohit Agarwal wrote: >>>> Hi, >>>> >>>> Changes in v4: >>>> - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5. >>>> >>>> Changes in v3: >>>> - Removed the unnecessary change introduced in v2 of patch 2/5 >>>> - Added Fixes tag in patch 3/5 >>>> - Rebased patch 5/5 on Dmitry's cleanup patches. >>>> https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ >>>> https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ >>>> >>>> Changes in v2: >>>> - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy >>>> and reusing the bindings. >>>> - Rephrased the commit message of patch 3/5 >>>> - Removed stray lines from the patch 5/5 >>>> >>>> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform. >>> The phy patches fail to apply, can you please rebase the three patches >>> and resend >> Can you please apply these two series. This series depends on it for >> successful compilation. >> [1] https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ > This one has a pending comment bw Konrad and Dmitry.. Ok, Will wait for this to get resolved. Thanks, Rohit. > >> [2] https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ > This one is already in -next > >> Thanks, >> Rohit.
On Fri, 22 Sep 2023 10:42:00 +0530, Rohit Agarwal wrote: > Changes in v4: > - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5. > > Changes in v3: > - Removed the unnecessary change introduced in v2 of patch 2/5 > - Added Fixes tag in patch 3/5 > - Rebased patch 5/5 on Dmitry's cleanup patches. > https://lore.kernel.org/all/20230911203842.778411-1-dmitry.baryshkov@linaro.org/ > https://lore.kernel.org/linux-phy/20230824211952.1397699-1-dmitry.baryshkov@linaro.org/ > > [...] Applied, thanks! [1/5] dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75 (no commit info) [2/5] dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY (no commit info) [5/5] phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support commit: 7f6f9e0def00cfaeb1d034fd13dbd84470aeccbd Best regards,