mbox series

[0/5] Add some clocks support for i.MX8qxp DC0/MIPI-LVDS subsystems

Message ID 1605688290-21805-1-git-send-email-victor.liu@nxp.com
Headers show
Series Add some clocks support for i.MX8qxp DC0/MIPI-LVDS subsystems | expand

Message

Ying Liu Nov. 18, 2020, 8:31 a.m. UTC
This patch set adds some clocks support for i.MX8qxp DC0/MIPI-LVDS subsystems,
which includes some SCU controlled clocks and some LPCG clocks.

With this patch set, some basic clocks for i.MX8qxp LVDS displays can be got
by drivers.

This patch set follows the legacy/deprecated way to add the clocks support
in clock drivers instead of the new 'two cells' dt-binding way.  The reason
behind this is that the existing i.MX8qxp SoC device tree is using the legacy
way(no conversion effort is seen) and there is not i.MX8qm(with a similar
architecture) SoC device tree for us to enable display yet.

Liu Ying (5):
  clk: imx: clk-imx8qxp: Add SCU clocks support for DC0 PLL clocks
  clk: imx: clk-imx8qxp-lpcg: Add display controller LPCG clocks support
  clk: imx: clk-imx8qxp: Add some SCU clocks support for MIPI-LVDS
    subsystems
  dt-bindings: clock: imx8qxp-lpcg: Add compatibles for MIPI-LVDS
    subsystems
  clk: imx: clk-imx8qxp-lpcg: Add some LPCG clocks support for MIPI-LVDS
    subsystems

 .../devicetree/bindings/clock/imx8qxp-lpcg.yaml    |  2 +
 drivers/clk/imx/clk-imx8qxp-lpcg.c                 | 79 ++++++++++++++++++++++
 drivers/clk/imx/clk-imx8qxp-lpcg.h                 | 29 ++++++++
 drivers/clk/imx/clk-imx8qxp.c                      | 12 ++++
 include/dt-bindings/clock/imx8-clock.h             | 61 +++++++++++++++++
 5 files changed, 183 insertions(+)

Comments

Dong Aisheng Nov. 18, 2020, 10:31 a.m. UTC | #1
> From: Ying Liu <victor.liu@nxp.com>
> Sent: Wednesday, November 18, 2020 4:31 PM
> 
> This patch set adds some clocks support for i.MX8qxp DC0/MIPI-LVDS
> subsystems, which includes some SCU controlled clocks and some LPCG clocks.
> 
> With this patch set, some basic clocks for i.MX8qxp LVDS displays can be got by
> drivers.
> 
> This patch set follows the legacy/deprecated way to add the clocks support in
> clock drivers instead of the new 'two cells' dt-binding way.  The reason behind
> this is that the existing i.MX8qxp SoC device tree is using the legacy way(no
> conversion effort is seen) and there is not i.MX8qm(with a similar
> architecture) SoC device tree for us to enable display yet.

Hi Ying,

Please don't do this.
You know the legacy clock binding will be removed and not used anymore.

Regards
Aisheng

> 
> Liu Ying (5):
>   clk: imx: clk-imx8qxp: Add SCU clocks support for DC0 PLL clocks
>   clk: imx: clk-imx8qxp-lpcg: Add display controller LPCG clocks support
>   clk: imx: clk-imx8qxp: Add some SCU clocks support for MIPI-LVDS
>     subsystems
>   dt-bindings: clock: imx8qxp-lpcg: Add compatibles for MIPI-LVDS
>     subsystems
>   clk: imx: clk-imx8qxp-lpcg: Add some LPCG clocks support for MIPI-LVDS
>     subsystems
> 
>  .../devicetree/bindings/clock/imx8qxp-lpcg.yaml    |  2 +
>  drivers/clk/imx/clk-imx8qxp-lpcg.c                 | 79
> ++++++++++++++++++++++
>  drivers/clk/imx/clk-imx8qxp-lpcg.h                 | 29 ++++++++
>  drivers/clk/imx/clk-imx8qxp.c                      | 12 ++++
>  include/dt-bindings/clock/imx8-clock.h             | 61
> +++++++++++++++++
>  5 files changed, 183 insertions(+)
> 
> --
> 2.7.4