| Message ID | 1602873815-1677-1-git-send-email-tdas@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add Camera clock controller driver for SC7180 | expand |
Quoting Taniya Das (2020-10-16 11:43:32) > Introduce clk_alpha_pll_write_config and alpha_pll_check_rate_margin > helper functions to be across PLL configure functions and PLL set rate > functions. > > Signed-off-by: Taniya Das <tdas@codeaurora.org> > --- Applied to clk-next
Quoting Taniya Das (2020-10-16 11:43:33) > Add programming sequence support for managing the Agera PLLs. > > Signed-off-by: Taniya Das <tdas@codeaurora.org> > --- Applied to clk-next
Quoting Taniya Das (2020-10-16 11:43:35) > Add support for the camera clock controller found on SC7180 based devices. > This would allow camera drivers to probe and control their clocks. > > Signed-off-by: Taniya Das <tdas@codeaurora.org> > --- Applied to clk-next with some minor fixups.
On Thu, Nov 5, 2020 at 5:52 AM Stephen Boyd <sboyd@kernel.org> wrote: > Quoting Taniya Das (2020-10-16 11:43:35) > > Add support for the camera clock controller found on SC7180 based devices. > > This would allow camera drivers to probe and control their clocks. > > > > Signed-off-by: Taniya Das <tdas@codeaurora.org> > > --- > > Applied to clk-next with some minor fixups. On Fri, Nov 6, 2020 at 8:43 AM <noreply@ellerman.id.au> wrote: > FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Fri Nov 06, 18:35 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14393224/ > > Commit: Add linux-next specific files for 20201106 > c34f157421f6905e6b4a79a312e9175dce2bc607 > Compiler: m68k-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30 > > Possible errors > --------------- > > drivers/clk/qcom/camcc-sc7180.c:1672:8: error: implicit declaration of function 'pm_clk_runtime_resume'; did you mean 'pm_runtime_resume'? [-Werror=implicit-function-declaration] > drivers/clk/qcom/camcc-sc7180.c:1681:3: error: implicit declaration of function 'pm_clk_runtime_suspend'; did you mean 'pm_runtime_suspend'? [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors > make[4]: *** [scripts/Makefile.build:283: drivers/clk/qcom/camcc-sc7180.o] Error 1 > make[3]: *** [scripts/Makefile.build:500: drivers/clk/qcom] Error 2 The pm_clk_runtime_*() functions are only available if CONFIG_PM=y. No dummies are provided for the CONFIG_PM=n case yet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
[v3] * Introduce helper functions to be used across pll configure and pll rate margins. * Update the Agera PLL configure/set rate to use the new helper functions. * Update documentation binding to update the header inclusion. * Update the vco table to 'const'. * Fix the failure path of probe. [v2] * Update PLL set rate function : clk_alpha_pll_agera_set_rate * Remove mb() [v1] * Add support for Agera PLL which is used in the camera clock controller. * Add driver support for camera clock controller for SC7180 and also update device tree bindings for the various clocks supported in the clock controller. Taniya Das (4): clk: qcom: clk-alpha-pll: Add support for helper functions clk: qcom: clk-alpha-pll: Add support for controlling Agera PLLs dt-bindings: clock: Add YAML schemas for the QCOM Camera clock bindings. clk: qcom: camcc: Add camera clock controller driver for SC7180 .../bindings/clock/qcom,sc7180-camcc.yaml | 73 + drivers/clk/qcom/Kconfig | 9 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/camcc-sc7180.c | 1736 ++++++++++++++++++++ drivers/clk/qcom/clk-alpha-pll.c | 217 ++- drivers/clk/qcom/clk-alpha-pll.h | 4 + include/dt-bindings/clock/qcom,camcc-sc7180.h | 121 ++ 7 files changed, 2072 insertions(+), 89 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml create mode 100644 drivers/clk/qcom/camcc-sc7180.c create mode 100644 include/dt-bindings/clock/qcom,camcc-sc7180.h -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.