| Message ID | 1596231144-12554-1-git-send-email-skomatineni@nvidia.com |
|---|---|
| Headers | show |
| Series | Support for Tegra video capture from external sensor | expand |
01.08.2020 00:32, Sowjanya Komatineni пишет: ... > +static int tegra_csi_channels_alloc(struct tegra_csi *csi) > +{ > + struct device_node *node = csi->dev->of_node; > + struct v4l2_fwnode_endpoint v4l2_ep = { > + .bus_type = V4L2_MBUS_CSI2_DPHY > + }; > + struct fwnode_handle *fwh; > + struct device_node *channel; > + struct device_node *ep; > + unsigned int lanes, portno, num_pads; > + int ret; > + > + for_each_child_of_node(node, channel) { > + if (!of_node_name_eq(channel, "channel")) > + continue; > + > + ret = of_property_read_u32(channel, "reg", &portno); > + if (ret < 0) > + continue; > + > + if (portno >= csi->soc->csi_max_channels) { > + dev_err(csi->dev, "invalid port num %d\n", portno); The "channel" node should be put on error. > + return -EINVAL; > + } > + > + ep = of_graph_get_endpoint_by_regs(channel, 0, 0); > + if (!ep) > + continue; > + > + fwh = of_fwnode_handle(ep); > + ret = v4l2_fwnode_endpoint_parse(fwh, &v4l2_ep); > + of_node_put(ep); > + if (ret) { > + dev_err(csi->dev, > + "failed to parse v4l2 endpoint: %d\n", ret); > + return ret; > + } > + > + lanes = v4l2_ep.bus.mipi_csi2.num_data_lanes; > + if (!lanes || ((lanes & (lanes - 1)) != 0)) { > + dev_err(csi->dev, "invalid data-lanes %d\n", lanes); > + return -EINVAL; > + } > + > + num_pads = of_graph_get_endpoint_count(channel); > + if (num_pads == TEGRA_CSI_PADS_NUM) { > + ret = tegra_csi_channel_alloc(csi, channel, portno, > + lanes, num_pads); > + if (ret < 0) > + return ret; > + } > } ... > +static int tegra_vi_channels_alloc(struct tegra_vi *vi) > +{ > + struct device_node *node = vi->dev->of_node; > + struct device_node *ep = NULL; > + struct device_node *ports; > + struct device_node *port; > + unsigned int port_num; > + int ret; > + > + ports = of_get_child_by_name(node, "ports"); > + if (!ports) > + return -ENODEV; > + > + for_each_child_of_node(ports, port) { > + if (!of_node_name_eq(port, "port")) > + continue; > + > + ret = of_property_read_u32(port, "reg", &port_num); > + if (ret < 0) > + continue; > + > + if (port_num > vi->soc->vi_max_channels) { > + of_node_put(ports); s/ports/port/ > + dev_err(vi->dev, "invalid port num %d\n", port_num); > + return -EINVAL; > + } > + > + ep = of_get_child_by_name(port, "endpoint"); > + if (!ep) > + continue; > + > + of_node_put(ep); > + ret = tegra_vi_channel_alloc(vi, port_num, port); > + if (ret < 0) { > + of_node_put(ports); s/ports/port/ > + return ret; > + } > }
01.08.2020 00:32, Sowjanya Komatineni пишет: > CSI MIPI pads need to be enabled and calibrated for capturing from > the external sensor or transmitter. > > MIPI CAL unit calibrates MIPI pads pull-up, pull-down and termination > impedances. Calibration is done by co-work of MIPI BIAS pad and MIPI > CAL control unit. > > Triggering calibration start can happen any time after MIPI pads are > enabled but calibration results will be latched and applied to MIPI > pads by MIPI CAL unit only when the link is in LP11 state and then > calibration status register gets updated. > > This patch enables CSI MIPI pads and calibrates them during streaming. > > Tegra CSI receiver is able to catch the very first clock transition. > So, CSI receiver is always enabled prior to sensor streaming and > trigger of calibration start is done during CSI subdev streaming and > status of calibration is verified after sensor stream on. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > drivers/staging/media/tegra-video/TODO | 1 - > drivers/staging/media/tegra-video/csi.c | 61 +++++++++++++++++++++++++++++++-- > drivers/staging/media/tegra-video/csi.h | 2 ++ > drivers/staging/media/tegra-video/vi.c | 28 ++++++++++++--- > 4 files changed, 84 insertions(+), 8 deletions(-) Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
This series adds support for video capture from external camera sensor to Tegra video driver. Jetson TX1 has camera expansion connector and supports custom camera module designed as per TX1 design specification. This series also enables camera capture support for Jetson Nano which has Raspberry PI camera header. This series is tested with IMX274 and IMX219 camera sensors. This series include, Tegra video driver updates - TPG Vs Non-TPG based on Kconfig - Support for external sensor video capture based on device graph from DT - Support for selection ioctl operations - Tegra MIPI CSI pads calibration - CSI T-CLK and T-HS settle time computation based on clock rates - dt-binding doc update Host1x driver updates - Keep MIPI clock enabled till calibration is done Delta between patch versions: [v7]: Includes minor feedback from v6 - Patch-0009 has minor update Note: Patch-0006 has compilation dependency on https://patchwork.kernel.org/patch/11659521/ [v6]: Includes below changes based on v5 feedback - Patches are based on latest linux-next. - separated stream enable and disable implementations into separate functions for tegra_channel_set_stream() and tegra_csi_s_stream(). - changed dev_err to dev_warn on MIPI calibration failure after sensor streaming as its not critical error. Note: Patch-0006 has compilation dependency on https://patchwork.kernel.org/patch/11659521/ [v5]: Includes below minor change based on v4 feedback Patch-0012: renames APIs to use calibration instead of calibrate. Note: Patch-0010 has compilation dependency on https://patchwork.kernel.org/patch/11659521/ [v4]: Includes below fix based on v3 feedback - Patches are based on latest linux-next. - With split of tegra_mipi_calibrate() and tegra_mipi_wait(), mipi clock is not left enabled till calibration done. This series adds a patch to fix this by keeping clock enabled till calibration is done. Note: Patch-0010 has compilation dependency on https://patchwork.kernel.org/patch/11659521/ [v3]: Includes v2 feedback - Uses separate helper function for retrieving remote csi subdevice and source subdevice. - Added check for presence of subdevice ops set/get_selection - dropped vb2_queue_release from driver and using vb2_video_unregister_device instead of video_unregister_device. - video device register should happen in the last after all video device related setup is done in the driver. This is being addressed in below RFC patch. Once proper implementation of this is available will update Tegra video driver to use split APIs and do all setup prior to device register. Added this as TODO in the driver. https://www.spinics.net/lists/linux-media/msg172761.html Note: Patch-0012 has compilation dependency on https://patchwork.kernel.org/patch/11659521/ [v2]: Includes below changes based on v1 feedback - dt-binding document and the driver update for device graph to use separate ports for sink endpoint and source endpoint for csi. - Use data-lanes endpoint property for csi. - Update tegra_mipi_request() to take device node pointer argument rather than adding extra API. - Remove checking for clk pointer before clk_disable. Sowjanya Komatineni (10): media: tegra-video: Fix channel format alignment media: tegra-video: Enable TPG based on kernel config media: tegra-video: Update format lookup to offset based dt-bindings: tegra: Update VI and CSI bindings with port info media: tegra-video: Separate CSI stream enable and disable implementations media: tegra-video: Add support for external sensor capture media: tegra-video: Add support for selection ioctl ops gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done media: tegra-video: Add CSI MIPI pads calibration media: tegra-video: Compute settle times based on the clock rate .../display/tegra/nvidia,tegra20-host1x.txt | 92 ++- drivers/gpu/drm/tegra/dsi.c | 4 +- drivers/gpu/host1x/mipi.c | 19 +- drivers/staging/media/tegra-video/Kconfig | 7 + drivers/staging/media/tegra-video/TODO | 6 - drivers/staging/media/tegra-video/csi.c | 305 +++++++- drivers/staging/media/tegra-video/csi.h | 8 + drivers/staging/media/tegra-video/tegra210.c | 25 +- drivers/staging/media/tegra-video/vi.c | 836 +++++++++++++++++++-- drivers/staging/media/tegra-video/vi.h | 25 +- drivers/staging/media/tegra-video/video.c | 23 +- include/linux/host1x.h | 5 +- 12 files changed, 1239 insertions(+), 116 deletions(-)