mbox series

[0/4] Split ipq8074 reset bindings from clock bindings

Message ID 1594739122-29327-1-git-send-email-sivaprak@codeaurora.org
Headers show
Series Split ipq8074 reset bindings from clock bindings | expand

Message

Sivaprakash Murugesan July 14, 2020, 3:05 p.m. UTC 
The patch series https://lwn.net/Articles/825325/ wrongly added clock
bindings into reset bindings. This is caught by 
kernel test robot <lkp@intel.com> after it got merged into the clk-next
tree.

To avoid these kind of future mistakes it is better we split up the reset
bindings from clock bindings.

Since the clock patches in https://lwn.net/Articles/825325/ are applied to
clk-next it would be better if all the changes in this series to go through
clk-next.

Sivaprakash Murugesan (4):
  clk: qcom: ipq8074: remove gcc reset bindings
  reset: qcom: ipq8074: Add ipq8074 gcc resets
  arm64: dts: ipq8074: include reset bindings
  clk: qcom: ipq8074: include gcc reset bindings

 arch/arm64/boot/dts/qcom/ipq8074.dtsi        |   1 +
 drivers/clk/qcom/gcc-ipq8074.c               |   1 +
 include/dt-bindings/clock/qcom,gcc-ipq8074.h | 139 +-------------------------
 include/dt-bindings/reset/qcom,gcc-ipq8074.h | 141 +++++++++++++++++++++++++++
 4 files changed, 146 insertions(+), 136 deletions(-)
 create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq8074.h

Comments

Stephen Boyd July 16, 2020, 12:55 a.m. UTC | #1 
Quoting Sivaprakash Murugesan (2020-07-14 08:05:18)
> The patch series https://lwn.net/Articles/825325/ wrongly added clock
> bindings into reset bindings. This is caught by 
> kernel test robot <lkp@intel.com> after it got merged into the clk-next
> tree.
> 
> To avoid these kind of future mistakes it is better we split up the reset
> bindings from clock bindings.
> 
> Since the clock patches in https://lwn.net/Articles/825325/ are applied to
> clk-next it would be better if all the changes in this series to go through
> clk-next.

I disagree. We've put them all in the same file because they're all used
provided by the same compatible string. Please keep doing that and just
fix the number scheme if that is the problem. Also, use lore.kernel.org
for your links next time (i.e. https://lore.kernel.org/r/<message-id>)
so that we don't need to rely on lwn.net links.